From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 91985] [regression, bisected] FTBFS with commit f9caabe8f1: R600_UCP_CONST_BUFFER is undefined Date: Sat, 12 Sep 2015 08:24:38 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0767240692==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 1888D6E665 for ; Sat, 12 Sep 2015 01:24:38 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0767240692== Content-Type: multipart/alternative; boundary="1442046278.60083.15168"; charset="UTF-8" --1442046278.60083.15168 Date: Sat, 12 Sep 2015 08:24:38 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=91985 Kai changed: What |Removed |Added ---------------------------------------------------------------------------- CC|vljn@ovi.com |airlied@freedesktop.org Summary|[regression, bisected] |[regression, bisected] |FTBFS with commit |FTBFS with commit |f9f5c92f73: |f9caabe8f1: |R600_UCP_CONST_BUFFER is |R600_UCP_CONST_BUFFER is |undefined |undefined --- Comment #2 from Kai --- Ahrg, pasted wrong commit, the following is the correct one: commit f9caabe8f1bff86d19b53d9ecba5c72b238d9e23 Author: Dave Airlie Date: Fri Sep 11 04:43:53 2015 +0100 r600g: lower number of driver const buffers I'm going to want a driver constant buffer for tess to coordinate LDS storage, so before I go tackling that I decided to merge the clip/samplepos and texture info buffers into one. So I can steal the spare one. This creates a single constant buffer between the two, with clip/samplepos taking up a reserved 128 bytes at the start. Reviewed-by: Edward O'Callaghan Reviewed-by: Glenn Kennard Signed-off-by: Dave Airlie It's basically that R600_UCP_CONST_BUFFER was replaced by R600_BUFFER_INFO_CONST_BUFFER AFAICT and this place in r600_llvm.c was forgotten. -- You are receiving this mail because: You are the assignee for the bug. --1442046278.60083.15168 Date: Sat, 12 Sep 2015 08:24:38 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" changed bug 91985
What Removed Added
CC vljn@ovi.com airlied@freedesktop.org
Summary [regression, bisected] FTBFS with commit f9f5c92f73: R600_UCP_CONST_BUFFER is undefined [regression, bisected] FTBFS with commit f9caabe8f1: R600_UCP_CONST_BUFFER is undefined

Comment # 2 on bug 91985 from 
Ahrg, pasted wrong commit, the following is the correct one:

commit f9caabe8f1bff86d19b53d9ecba5c72b238d9e23
Author: Dave Airlie <airlied@redhat.com>
Date:   Fri Sep 11 04:43:53 2015 +0100

    r600g: lower number of driver const buffers

    I'm going to want a driver constant buffer for tess to coordinate
    LDS storage, so before I go tackling that I decided to merge the
    clip/samplepos and texture info buffers into one. So I can steal
    the spare one.

    This creates a single constant buffer between the two, with
    clip/samplepos taking up a reserved 128 bytes at the start.

    Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
    Reviewed-by: Glenn Kennard <glenn.kennard@gmail.com>
    Signed-off-by: Dave Airlie <airlied@redhat.com>

It's basically that R600_UCP_CONST_BUFFER was replaced by
R600_BUFFER_INFO_CONST_BUFFER AFAICT and this place in r600_llvm.c was
forgotten.

You are receiving this mail because:
  • You are the assignee for the bug.
--1442046278.60083.15168-- --===============0767240692== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0767240692==--