From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 92184] Many piglit assertion failures in radeon_unmap_renderbuffer
Date: Tue, 01 Dec 2015 00:26:42 +0000 [thread overview]
Message-ID: <bug-92184-502-A6EKf7kdsl@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-92184-502@http.bugs.freedesktop.org/>
[-- Attachment #1.1: Type: text/plain, Size: 1134 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=92184
--- Comment #2 from Roland Scheidegger <sroland@vmware.com> ---
Not sure, but I don't think there should be a fallback for the blit in this
case. This is for map/unmap_renderbuffer after all, and if it asserts in unmap
this means the blit from the rb to some temp buffer was succesful. I see no
reason why it shouldn't be possible to blit it back - it was a rb after all, so
should have all the required alignment, format etc. in the first place.
Some of the examples you listed actually look like they should only really
map/unmap zs buf not color, albeit the fallback might just map/unmap everything
always (IIRC that was actually the case last I checked several years ago, and
sometimes responsible for some huge slowdown compared to some old dri1 code -
you draw a single point with some unsupported setup, and 99.999% of the time
spent in the fallback was just for blitting everything to some buffer and
back). Or could there be a problem if there's not actually a color rb and it
tries to blit that?
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1924 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-12-01 0:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 21:24 [Bug 92184] Many piglit assertion failures in radeon_unmap_renderbuffer bugzilla-daemon
2015-11-30 23:27 ` bugzilla-daemon
2015-12-01 0:26 ` bugzilla-daemon [this message]
2016-02-05 5:39 ` bugzilla-daemon
2019-09-18 18:40 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-92184-502-A6EKf7kdsl@http.bugs.freedesktop.org/ \
--to=bugzilla-daemon@freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).