From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 92184] Many piglit assertion failures in radeon_unmap_renderbuffer Date: Tue, 01 Dec 2015 00:26:42 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1211220159==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id BCC5D6E0F1 for ; Mon, 30 Nov 2015 16:26:42 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1211220159== Content-Type: multipart/alternative; boundary="1448929602.Be07aFB51.1433"; charset="UTF-8" --1448929602.Be07aFB51.1433 Date: Tue, 1 Dec 2015 00:26:42 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=92184 --- Comment #2 from Roland Scheidegger --- Not sure, but I don't think there should be a fallback for the blit in this case. This is for map/unmap_renderbuffer after all, and if it asserts in unmap this means the blit from the rb to some temp buffer was succesful. I see no reason why it shouldn't be possible to blit it back - it was a rb after all, so should have all the required alignment, format etc. in the first place. Some of the examples you listed actually look like they should only really map/unmap zs buf not color, albeit the fallback might just map/unmap everything always (IIRC that was actually the case last I checked several years ago, and sometimes responsible for some huge slowdown compared to some old dri1 code - you draw a single point with some unsupported setup, and 99.999% of the time spent in the fallback was just for blitting everything to some buffer and back). Or could there be a problem if there's not actually a color rb and it tries to blit that? -- You are receiving this mail because: You are the assignee for the bug. --1448929602.Be07aFB51.1433 Date: Tue, 1 Dec 2015 00:26:42 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 2 on bug 92184 from 
Not sure, but I don't think there should be a fallback for the blit in this
case. This is for map/unmap_renderbuffer after all, and if it asserts in unmap
this means the blit from the rb to some temp buffer was succesful. I see no
reason why it shouldn't be possible to blit it back - it was a rb after all, so
should have all the required alignment, format etc. in the first place.
Some of the examples you listed actually look like they should only really
map/unmap zs buf not color, albeit the fallback might just map/unmap everything
always (IIRC that was actually the case last I checked several years ago, and
sometimes responsible for some huge slowdown compared to some old dri1 code -
you draw a single point with some unsupported setup, and 99.999% of the time
spent in the fallback was just for blitting everything to some buffer and
back). Or could there be a problem if there's not actually a color rb and it
tries to blit that?

You are receiving this mail because:
  • You are the assignee for the bug.
--1448929602.Be07aFB51.1433-- --===============1211220159== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1211220159==--