dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 93147] [regression bisected] Stuttering in games caused by commit 4dfd6486 "drm: Use vblank timestamps to guesstimate how many vblanks were missed"
Date: Thu, 03 Dec 2015 15:02:23 +0000	[thread overview]
Message-ID: <bug-93147-502-Q9lveczmfE@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-93147-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 1000 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93147

--- Comment #10 from Mario Kleiner <mario.kleiner@tuebingen.mpg.de> ---
Created attachment 120301
  --> https://bugs.freedesktop.org/attachment.cgi?id=120301&action=edit
First proposed patch to fix this on radeon-kms

Ok, the attached patch works on my test systems with my timing tests and
hardware timing measurement equipment and i think it hopefully avoids the races
Ville and me could come up with so far.

One thing which might make sense for improved efficiency is to replace the
udelay(5) in the radeon_flip_work_func() with a usleep_range() that avoids
polling and sleeps the right minimum amount of time. I'll try to try that
today.

For the line buffer sizes for < DCE4 i just guessed values which are hopefully
big enough to cover earlier asics. I think too big is not a big problem for
correctness, but potentially for performance under higher graphics load.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2253 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2015-12-03 15:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-28  3:08 [Bug 93147] [regression bisected] Stuttering in games caused by commit 4dfd6486 "drm: Use vblank timestamps to guesstimate how many vblanks were missed" bugzilla-daemon
2015-11-28  3:10 ` bugzilla-daemon
2015-11-28  6:43 ` bugzilla-daemon
2015-11-28 13:11 ` bugzilla-daemon
2015-11-30  3:52 ` bugzilla-daemon
2015-11-30 20:12 ` bugzilla-daemon
2015-12-01  2:56 ` bugzilla-daemon
2015-12-01  2:57 ` bugzilla-daemon
2015-12-01 12:55 ` bugzilla-daemon
2015-12-01 13:26 ` bugzilla-daemon
2015-12-03 15:02 ` bugzilla-daemon [this message]
2015-12-03 17:35 ` bugzilla-daemon
2015-12-04  5:00 ` bugzilla-daemon
2015-12-04 15:10 ` bugzilla-daemon
2015-12-04 15:11 ` bugzilla-daemon
2015-12-04 15:13 ` bugzilla-daemon
2015-12-04 17:52 ` bugzilla-daemon
2015-12-04 20:16 ` bugzilla-daemon
2015-12-04 20:44 ` bugzilla-daemon
2015-12-05  1:04 ` bugzilla-daemon
2015-12-06  2:29 ` bugzilla-daemon
2015-12-18  8:16 ` bugzilla-daemon
2015-12-18 15:00 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-93147-502-Q9lveczmfE@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox