From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start Date: Tue, 26 Apr 2016 06:49:46 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1494247481==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id CEAD26E74A for ; Tue, 26 Apr 2016 06:49:46 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1494247481== Content-Type: multipart/alternative; boundary="14616533863.BB53.534"; charset="UTF-8" --14616533863.BB53.534 Date: Tue, 26 Apr 2016 06:49:46 +0000 MIME-Version: 1.0 Content-Type: text/plain https://bugs.freedesktop.org/show_bug.cgi?id=93551 Jamey Sharp changed: What |Removed |Added ---------------------------------------------------------------------------- OS|Linux (All) |All CC| |jamey@minilop.net Component|Drivers/Gallium/radeonsi |Mesa core QA Contact|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop. |.org |org Hardware|x86-64 (AMD64) |All Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop. |.org |org --- Comment #10 from Jamey Sharp --- (In reply to smidjar2.reg from comment #6) > I disassembled ApplyConstants() where the game crashes when using OpenGL > override to 4.2. I spent a while poking at this crash in gdb, and I was definitely seeing the same segfault at the same instruction and call-stack. I've sent a (one-line!) patch to mesa-dev that fixes this segfault on startup: https://lists.freedesktop.org/archives/mesa-dev/2016-April/114614.html And a Piglit patch that tests for the non-conforming behavior that led to this crash: https://lists.freedesktop.org/archives/mesa-dev/2016-April/114613.html Thanks to Karol Herbst's mesa-dev post, linked from comment #7, for pointing me in the right direction to find this Mesa bug. Granted, the game developers ought to check for errors returned from glLinkProgram and fail more gracefully than a segfault, but I doubt we're going to get them to do *that*... I can now play this game somewhat successfully on i965 with MESA_GL_VERSION_OVERRIDE=4.2. There are still plenty of rendering bugs I haven't dug into yet, but I played for an hour without crashes, at least! I don't have (or particularly want) a commit bit on Mesa or Piglit, so now we need somebody to review and hopefully merge these patches. -- You are receiving this mail because: You are the assignee for the bug. --14616533863.BB53.534 Date: Tue, 26 Apr 2016 06:49:46 +0000 MIME-Version: 1.0 Content-Type: text/html changed bug 93551
What Removed Added
OS Linux (All) All
CC   jamey@minilop.net
Component Drivers/Gallium/radeonsi Mesa core
QA Contact dri-devel@lists.freedesktop.org mesa-dev@lists.freedesktop.org
Hardware x86-64 (AMD64) All
Assignee dri-devel@lists.freedesktop.org mesa-dev@lists.freedesktop.org

Comment # 10 on bug 93551 from 
(In reply to smidjar2.reg from comment #6)
> I disassembled ApplyConstants() where the game crashes when using OpenGL
> override to 4.2.

I spent a while poking at this crash in gdb, and I was definitely seeing the
same segfault at the same instruction and call-stack.

I've sent a (one-line!) patch to mesa-dev that fixes this segfault on startup:

https://lists.freedesktop.org/archives/mesa-dev/2016-April/114614.html

And a Piglit patch that tests for the non-conforming behavior that led to this
crash:

https://lists.freedesktop.org/archives/mesa-dev/2016-April/114613.html

Thanks to Karol Herbst's mesa-dev post, linked from comment #7, for pointing me
in the right direction to find this Mesa bug.

Granted, the game developers ought to check for errors returned from
glLinkProgram and fail more gracefully than a segfault, but I doubt we're going
to get them to do *that*...

I can now play this game somewhat successfully on i965 with
MESA_GL_VERSION_OVERRIDE=4.2. There are still plenty of rendering bugs I
haven't dug into yet, but I played for an hour without crashes, at least!

I don't have (or particularly want) a commit bit on Mesa or Piglit, so now we
need somebody to review and hopefully merge these patches.

You are receiving this mail because:
  • You are the assignee for the bug.
--14616533863.BB53.534-- --===============1494247481== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1494247481==--