[Bug 93594] Flickering Shadows in The Talos Principle

[bugzilla-daemon@freedesktop.org]

[-- Attachment #1.1: Type: text/plain, Size: 1316 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93594

--- Comment #16 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Interesting information about D3D10, thank you.

The GLSL 4.50 spec says:

"The discard keyword is only allowed within fragment shaders. It can be used
within a fragment shader to abandon the operation on the current fragment. This
keyword causes the fragment to be discarded and no updates to any buffers will
occur. Control flow exits the shader, and subsequent implicit or explicit
derivatives are undefined when this exit is non-uniform."

One annoying aspect of this language is that one can reasonably read it as
non-uniformity only being relevant for non-helper fragments. If a pixel quad is
partial covered by the original primitive, and discard is used in a way that
keeps the covered pixels but discard the helper ones, should derivatives be
defined or not?

As Michel said, I am indeed currently working on a patch changing exec mask
behavior in LLVM for stores and atomics in pixel shaders. While what I have so
far does not fix this bug yet, it already requires switching back and forth
between WQM and non-WQM/"exact" modes. Extending this to keep full quads alive
after KILL_IF should not add much more overhead.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2087 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel