[Bug 93760] radeonsi vaapi mpeg2 decode slightly corrupt or asserts.

[Bug 93760] radeonsi vaapi mpeg2 decode slightly corrupt or asserts.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1309 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93760

            Bug ID: 93760
           Summary: radeonsi vaapi mpeg2 decode slightly corrupt or
                    asserts.
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: adf.lists@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 121114
  --> https://bugs.freedesktop.org/attachment.cgi?id=121114&action=edit
assert

I mentioned in a mail that I noticed mpeg2 vaapi decode was slightly corrupt -
more noticeable on some samples than others.

While testing with mesa built with --enable-debug I can't even run - getting an
assert.

FWIW I am currently on an unstable agd5f drm-next with pp on and while running
a non asserting mesa to look at the corruption I just hard locked - just luck I
guess as powerplay does sometimes lock - but I got a trace, which doesn't
always happen so attaching that as well.

The dirty is patches from -

https://bugs.freedesktop.org/show_bug.cgi?id=93721

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2892 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93760] radeonsi vaapi mpeg2 decode slightly corrupt or asserts.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 305 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93760

--- Comment #1 from Andy Furniss <adf.lists@gmail.com> ---
Created attachment 121115
  --> https://bugs.freedesktop.org/attachment.cgi?id=121115&action=edit
lock hung task trace

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1217 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93760] radeonsi vaapi mpeg2 decode slightly corrupt or asserts.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 283 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93760

--- Comment #2 from Andy Furniss <adf.lists@gmail.com> ---
Time moves on - I can't actually lock (so far) testing now, but output is still
corrupt.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1078 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93760] radeonsi vaapi mpeg2 decode slightly corrupt or asserts.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 498 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93760

--- Comment #3 from Christian König <deathsimple@vodafone.de> ---
Sorry totally missed that bug.

The problem is most likely that GStreamer sends multiple slices in one request
to VA-API and we can't handle that in the state tracker.

Should be easy to fix actually, but we need somebody to look into it and
reproduce this.

Another task for Nayan maybe?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1301 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93760] radeonsi vaapi mpeg2 decode slightly corrupt or asserts.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 306 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93760

--- Comment #4 from Nayan Deshmukh <nayan26deshmukh@gmail.com> ---
I can reproduce the issue. I will look more into this over the weekend and also
read more about VA-API.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1109 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93760] radeonsi vaapi mpeg2 decode slightly corrupt or asserts.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 526 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93760

--- Comment #5 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Christian König from comment #3)
> Sorry totally missed that bug.
> 
> The problem is most likely that GStreamer sends multiple slices in one
> request to VA-API and we can't handle that in the state tracker.

Though it seems gstreamer also has issues, I only first tried it today.
This bug is testing with mpv.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1400 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93760] radeonsi vaapi mpeg2 decode slightly corrupt or asserts.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 416 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93760

Andy Furniss <adf.lists@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121115|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1103 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93760] radeonsi vaapi mpeg2 decode slightly corrupt or asserts.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 766 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93760

--- Comment #6 from Nayan Deshmukh <nayan26deshmukh@gmail.com> ---
(In reply to Christian König from comment #3)
> Sorry totally missed that bug.
> 
> The problem is most likely that GStreamer sends multiple slices in one
> request to VA-API and we can't handle that in the state tracker.
> 
> Should be easy to fix actually, but we need somebody to look into it and
> reproduce this.
>
What changes do we need to make to handle multiple slices?
The video plays fine with vdpau. Can you point me to the code where vdpau
handles multiple slices as both of them share similar code path.

> Another task for Nayan maybe?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1691 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93760] radeonsi vaapi mpeg2 decode slightly corrupt or asserts.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 568 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93760

--- Comment #7 from Christian König <deathsimple@vodafone.de> ---
Take a look at vlVaHandleSliceParameterBufferMPEG12 and the assert.

We probably just need to handle the case of multiple buffers here and in
handleVASliceDataBufferType.

The later is a bit tricky, since you need to search all slice buffers for the
start code and call begin_frame() only once even when you get multiple buffers
and/or calls to that function.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1371 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93760] radeonsi vaapi mpeg2 decode slightly corrupt or asserts.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 585 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93760

Nayan Deshmukh <nayan26deshmukh@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
                   |.org                        |org
         QA Contact|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
                   |.org                        |org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1372 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel