dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 95911] Recursive error in radeon device driver module after resume from hibernation
Date: Wed, 02 Sep 2015 23:57:47 +0000	[thread overview]
Message-ID: <bug-95911-2300-xicxiKrB15@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-95911-2300@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=95911

--- Comment #23 from gitne@excite.co.jp ---
(In reply to Alex Deucher from comment #20)
> Does this help?
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
> b/drivers/gpu/drm/radeon/radeon_drv.c
> index 5751446..1b4ac44 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -435,14 +435,14 @@ static int radeon_pmops_freeze(struct device *dev)
> {
> struct pci_dev *pdev = to_pci_dev(dev);
> struct drm_device *drm_dev = pci_get_drvdata(pdev);
> - return radeon_suspend_kms(drm_dev, false, true);
> + return radeon_suspend_kms(drm_dev, true, true);
> }
>
> static int radeon_pmops_thaw(struct device *dev)
> {
> struct pci_dev *pdev = to_pci_dev(dev);
> struct drm_device *drm_dev = pci_get_drvdata(pdev);
> - return radeon_resume_kms(drm_dev, false, true);
> + return radeon_resume_kms(drm_dev, true, true);
> }
>
> static int radeon_pmops_runtime_suspend(struct device *dev)

Thank you for digging into this. Again, I do not have the capacity to build a
Linux kernel. Could you do this for me? Then, I could also test it on my older
machine, which could potentially greatly improve support for many other
machines at the same time.

So far, radeon.msi=0 works for me as a workaround. I do not know how much of a
performance penalty this incurs but things seem to work smoothly. To quantify
any penalty, some exact measurements are required. However, since radeon.msi=1
does not work smoothly, it is going to be difficult to assess any quantifiable
results (and be able to compare them to radeon.msi=0) in this case. Can you
give me a hint as to what benchmarks I could/should run?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2015-09-02 23:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01  0:49 [Bug 95911] New: Recursive error in radeon device driver module after resume from hibernation bugzilla-daemon
2015-04-01  0:50 ` [Bug 95911] " bugzilla-daemon
2015-04-01  0:53 ` bugzilla-daemon
2015-04-01  0:54 ` bugzilla-daemon
2015-04-01  0:54 ` bugzilla-daemon
2015-04-01  0:55 ` bugzilla-daemon
2015-04-01  0:57 ` bugzilla-daemon
2015-04-01  2:13 ` bugzilla-daemon
2015-04-27 11:36 ` bugzilla-daemon
2015-04-30  9:25 ` bugzilla-daemon
2015-04-30  9:59 ` bugzilla-daemon
2015-04-30 11:51 ` bugzilla-daemon
2015-05-01  0:56 ` bugzilla-daemon
2015-05-01  6:41 ` bugzilla-daemon
2015-05-06 16:39 ` bugzilla-daemon
2015-05-07  1:17 ` bugzilla-daemon
2015-05-12 13:59 ` bugzilla-daemon
2015-05-27 19:26 ` bugzilla-daemon
2015-06-08 23:05 ` bugzilla-daemon
2015-08-04 22:43 ` bugzilla-daemon
2015-08-18  7:23 ` bugzilla-daemon
2015-08-18 15:01 ` bugzilla-daemon
2015-08-19  2:53 ` bugzilla-daemon
2015-08-19  2:57 ` bugzilla-daemon
2015-09-02 23:57 ` bugzilla-daemon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-95911-2300-xicxiKrB15@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).