[Bug 96343] oom since st/mesa: implement PBO downloads for ReadPixels

[Bug 96343] oom since st/mesa: implement PBO downloads for ReadPixels

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1763 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96343

            Bug ID: 96343
           Summary: oom since st/mesa: implement PBO downloads for
                    ReadPixels
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: adf.lists@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 124282
  --> https://bugs.freedesktop.org/attachment.cgi?id=124282&action=edit
oom

Tonga with xserver 1.8.3, agd5f drm-next-4.8-wip, git
mesa/llvm/libdrm/xf86-video-amdgpu.

Desktop is fluxbox = non-compositing.

Since -

commit ed0e9862c56d13381f0414b5a835fd31960edfe6
Author: Nicolai Hähnle <nicolai.haehnle@amd.com>
Date:   Tue Apr 26 13:19:28 2016 -0500

    st/mesa: implement PBO downloads for ReadPixels

    v2: require PIPE_CAP_SAMPLER_VIEW_TARGET; technically only needed for some
of
        the texture targets, but all hardware that has shader images should
also
        have this cap.

I can provoke an oom on xorg as attached by displaying a couple of 1920 xwds
with display from ImageMagick and flipping between then, plus some middle mouse
clicking (which magnifys a section and gives info on the pixel clicked).

Oom is not instant - may take a couple of minutes clicking/flipping.

Polling free when doing this doesn't indicate any issue until it triggers so
it's not slowly leaking, but goes quickly at some point filling swap then oom.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3281 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96343] oom since st/mesa: implement PBO downloads for ReadPixels

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 364 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96343

--- Comment #1 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Thank you for testing and reporting :)

Please try https://patchwork.freedesktop.org/patch/91150/ - it fixes a related
resource leak, hopefully there's nothing else.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1224 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96343] oom since st/mesa: implement PBO downloads for ReadPixels

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 443 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96343

--- Comment #2 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Nicolai Hähnle from comment #1)
> Thank you for testing and reporting :)
> 
> Please try https://patchwork.freedesktop.org/patch/91150/ - it fixes a
> related resource leak, hopefully there's nothing else.

That fixes it, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1380 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96343] oom since st/mesa: implement PBO downloads for ReadPixels

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 535 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96343

Nicolai Hähnle <nhaehnle@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Nicolai Hähnle <nhaehnle@gmail.com> ---
This has now been fixed in Mesa master.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2059 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel