[Bug 96360] VM fault with kernel 4.7-rc1 on Alien: Isolation

[Bug 96360] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1275 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

            Bug ID: 96360
           Summary: VM fault with kernel 4.7-rc1 on Alien: Isolation
           Product: DRI
           Version: DRI git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/Radeon
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: alexandre.f.demers@gmail.com

Created attachment 124312
  --> https://bugs.freedesktop.org/attachment.cgi?id=124312&action=edit
VM faults in dmesg triggered by Alien: Isolation

Hi,

I've recently begun playing Alien: Isolation now that the compute shaders are
available when combining latest Mesa with a 4.7-git kernel. However, my
computer freezes after sometime. Poking dmesg got me a repeating VM fault which
goes on as long as I'm in the game (playing, not the menu or while loading).

Setup:
GPU -> R9 280X
Kernel -> 4.7-rc1
Distribution -> Archlinux 64
Mesa, drm, ddx -> using latest code from git repositories

I'll try with a 4.6 kernel to see if this bug was introduced in or exposed by
the 4.7 branch. 

Attaching dmesg

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2771 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1066 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

--- Comment #1 from Alexandre Demers <alexandre.f.demers@gmail.com> ---
So this is the commit that exposes the bug.

3d02b7fee9c3ece1746f5b06c4143b511383fc6b is the first bad commit
commit 3d02b7fee9c3ece1746f5b06c4143b511383fc6b
Author: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Date:   Fri Apr 15 02:47:49 2016 +0200

    drm/radeon: Allow setting shader registers using DMA/COPY packet3 on SI.

    Mesa uses a COPY_DATA packet to copy the grid size for indirect dispatches
    into COMPUTE_USER_DATA_*.

    Setting those registers with a SET_SH_REG packet is allowed, not allowing
    them with other packets seems like an oversight.

    v2: Clarify commit message.

    Signed-off-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

:040000 040000 ec4d58f4c4e5bd746474776c852a7c70763183a7
8ba67a00f061b454d1600838bf620e1e937e9461 M      drivers

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2037 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 536 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

Alexandre Demers <alexandre.f.demers@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|VM fault with kernel        |[bisected] VM fault with
                   |4.7-rc1 on Alien: Isolation |kernel 4.7-rc1 on Alien:
                   |                            |Isolation

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1192 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected: 3d02b7] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 544 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

Alexandre Demers <alexandre.f.demers@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[bisected] VM fault with    |[bisected: 3d02b7] VM fault
                   |kernel 4.7-rc1 on Alien:    |with kernel 4.7-rc1 on
                   |Isolation                   |Alien: Isolation

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1219 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected: 3d02b7] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 267 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

--- Comment #2 from Alexandre Demers <alexandre.f.demers@gmail.com> ---
Still a problem with today's latest mesa and kernel 4.7-rc2.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1097 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected: 3d02b7] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 254 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

--- Comment #3 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Can you provide an apitrace that reproduces the VM faults?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1073 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected: 3d02b7] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 530 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

--- Comment #4 from Alexandre Demers <alexandre.f.demers@gmail.com> ---
(In reply to Nicolai Hähnle from comment #3)
> Can you provide an apitrace that reproduces the VM faults?

I'll do that later. However, it may end up as a big apitrace since it takes a
lot of time before being able to actually play de game, which is when the VM
faults appear. I'll figure out a way of putting a link.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1430 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected: 3d02b7] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 319 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

--- Comment #5 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Thanks, that would be much appreciated. Most people tend to use Google Drive -
I've downloaded GB-sized traces from there.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1138 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected: 3d02b7] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 361 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

--- Comment #6 from Alexandre Demers <alexandre.f.demers@gmail.com> ---
And here is the trace that you can download from Google Drive (I hope it works
correctly):
https://drive.google.com/open?id=0Bw_tZdWsNa4BV0VKMGVaeFBDaEE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1267 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected: 3d02b7] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 338 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

--- Comment #7 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Thanks! No VM faults here on Tonga, so this may be specific to SI. Do you get
VM faults in dmesg when you play the trace back on your system?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1157 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected: 3d02b7] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 470 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

--- Comment #8 from Alexandre Demers <alexandre.f.demers@gmail.com> ---
(In reply to Nicolai Hähnle from comment #7)
> Thanks! No VM faults here on Tonga, so this may be specific to SI. Do you
> get VM faults in dmesg when you play the trace back on your system?

Yes it does, I just tested it with the trace I've shared with you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1373 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected: 3d02b7] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 464 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

--- Comment #9 from Alexandre Demers <alexandre.f.demers@gmail.com> ---
(In reply to Nicolai Hähnle from comment #7)
> Thanks! No VM faults here on Tonga, so this may be specific to SI. Do you
> get VM faults in dmesg when you play the trace back on your system?

Anything I can provide you with? Any specific test or steps?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1367 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected: 3d02b7] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 511 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

--- Comment #10 from Nicolai Hähnle <nhaehnle@gmail.com> ---
No, thank you. I can reproduce this on a Verde, so it does seem to be
SI-specific (perhaps also CI) or perhaps a radeon vs. amdgpu issue.

I've seen a VM fault even with GALLIUM_DDEBUG=800 (i.e. frequent flushes)
happen at

901138 @3 glDispatchCompute(num_groups_x = 128, num_groups_y = 2, num_groups_z
= 1)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1335 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected: 3d02b7] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 518 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

--- Comment #11 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Created attachment 124514
  --> https://bugs.freedesktop.org/attachment.cgi?id=124514&action=edit
preliminary patch

Problem understood - we're generating bad shader code - though I still need to
double-check all the possible corner cases.

In the meantime, the attached patch for LLVM should fix Alien: Isolation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1549 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected: 3d02b7] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 519 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

Nicolai Hähnle <nhaehnle@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Fixed in LLVM r272761.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2074 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96360] [bisected: 3d02b7] VM fault with kernel 4.7-rc1 on Alien: Isolation

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 320 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96360

--- Comment #13 from Alexandre Demers <alexandre.f.demers@gmail.com> ---
(In reply to Nicolai Hähnle from comment #12)
> Fixed in LLVM r272761.

Thank you, I'll test it later today.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1274 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel