From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 97305] Gallium: TBOs and images set the offset in elements, not bytes Date: Mon, 29 Aug 2016 17:42:22 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0794802324==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 375366E065 for ; Mon, 29 Aug 2016 17:42:22 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0794802324== Content-Type: multipart/alternative; boundary="14724925420.b8D1.18889"; charset="UTF-8" --14724925420.b8D1.18889 Date: Mon, 29 Aug 2016 17:42:22 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D97305 Matias N. Goldberg changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #18 from Matias N. Goldberg --- You're awesome! I can confirm it works on both the sample repro I provided and my actual re= al case. Small note: We discovered there was a potential for a crash because at cert= ain points we assume SIMD alignment; so we're now enforcing 16-byte alignment as minimum in our code. I'm doing this remark because Mesa is the only (or amo= ng the very few) implementations that return alignments <16; which can reveal hidden bugs in program code that runs fine everywhere else. If you ever see= a bug report of these sorts (e.g. crashing in movaps, movntdqa), this is something to keep in mind. I appreciate the 4 byte alignment as 256 reported by others is excessively wasteful. Thanks. For the record it was fixed in https://cgit.freedesktop.org/mesa/mesa/commit/?id=3D7cd256ce7e4bad680bb77d0= 33cf5dd662abab2dd and https://cgit.freedesktop.org/mesa/mesa/commit/?id=3D325379096f54dde39171d1b= 8804e29a8003bb3c7 --=20 You are receiving this mail because: You are the assignee for the bug.= --14724925420.b8D1.18889 Date: Mon, 29 Aug 2016 17:42:22 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated Matias N. Goldberg changed bug 97305<= /a>
What Removed Added
Resolution --- FIXED
Status REOPENED RESOLVED

Commen= t # 18 on bug 97305<= /a> from Matias N. Goldberg 
You're awesome!

I can confirm it works on both the sample repro I provided and my actual re=
al
case.

Small note: We discovered there was a potential for a crash because at cert=
ain
points we assume SIMD alignment; so we're now enforcing 16-byte alignment as
minimum in our code. I'm doing this remark because Mesa is the only (or amo=
ng
the very few) implementations that return alignments <16; which can reve=
al
hidden bugs in program code that runs fine everywhere else. If you ever see=
 a
bug report of these sorts (e.g. crashing in movaps, movntdqa), this is
something to keep in mind.

I appreciate the 4 byte alignment as 256 reported by others is excessively
wasteful. Thanks.

For the record it was fixed in
https://cgit.freedesktop.org/mesa/mesa/commit=
/?id=3D7cd256ce7e4bad680bb77d033cf5dd662abab2dd
and
https://cgit.freedesktop.org/mesa/mesa/commit=
/?id=3D325379096f54dde39171d1b8804e29a8003bb3c7

You are receiving this mail because:
  • You are the assignee for the bug.
= --14724925420.b8D1.18889-- --===============0794802324== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0794802324==--