[Bug 97969] [radeonsi, bisected: fb827c0] Video decoding shows green artifacts

[Bug 97969] [radeonsi, bisected: fb827c0] Video decoding shows green artifacts

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1847 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97969

            Bug ID: 97969
           Summary: [radeonsi, bisected: fb827c0] Video decoding shows
                    green artifacts
           Product: Mesa
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: alexandre.f.demers@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Using R9 280X. Since today, playing videos with VLC displays green artifacts.
Tested with a few videos (mostly mp4 and mkv).

---
Extended renderer info (GLX_MESA_query_renderer):
    Vendor: X.Org (0x1002)
    Device: AMD TAHITI (DRM 2.46.0 / 4.7.0-AGD5F-g4ae4f77-dirty, LLVM 4.0.0)
(0x6798)
    Version: 12.1.0
    Accelerated: yes
    Video memory: 3072MB
    Unified memory: no
    Preferred profile: core (0x1)
    Max core profile version: 4.3
    Max compat profile version: 3.0
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.1
---

Bisecting points to the following bad commit

fb827c055cb1bdd2b18d0687c06c56b537d805f3 is the first bad commit
commit fb827c055cb1bdd2b18d0687c06c56b537d805f3
Author: Nicolai Hähnle <nicolai.haehnle@amd.com>
Date:   Mon Sep 12 12:19:47 2016 +0200

    winsys/radeon: enable buffer allocation from slabs

    Only enable for chips with GPUVM, because older driver paths do not take
the
    required offset into account.

    Reviewed-by: Marek Olšák <marek.olsak@amd.com>

:040000 040000 4e1327d4b72890178a2057d2341971001f2de54d
d162404a219307e5f6cda1009b864e66f23f4e63 M      src

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3331 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97969] [radeonsi, bisected: fb827c0] Video decoding shows green artifacts

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 380 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97969

Alexandre Demers <alexandre.f.demers@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |git

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1106 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97969] [radeonsi, bisected: fb827c0] Video decoding shows green artifacts

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 512 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97969

Alex Deucher <alexdeucher@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adf.lists@gmail.com

--- Comment #1 from Alex Deucher <alexdeucher@gmail.com> ---
*** Bug 97976 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2120 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97969] [radeonsi, bisected: fb827c0] Video decoding shows green artifacts

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 360 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97969

--- Comment #2 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Created attachment 126871
  --> https://bugs.freedesktop.org/attachment.cgi?id=126871&action=edit
possible fix

Does the attached patch fix the problem for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1378 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97969] [radeonsi, bisected: fb827c0] Video decoding shows green artifacts

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 991 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97969

--- Comment #3 from Alexandre Demers <alexandre.f.demers@gmail.com> ---
With the patch, when playing problematic videos, I get a black screen instead
of a partial display with green artifacts.

Also, with and without the patch, dmesg catches the following when playing the
problematic videos (I should have had a look previously):
[76261.125581] [drm:radeon_uvd_cs_parse [radeon]] *ERROR* Handle 0x8fd80001
already in use!
[76261.125594] [drm:radeon_cs_ioctl [radeon]] *ERROR* Invalid command stream !
[76261.126059] [drm:radeon_uvd_cs_parse [radeon]] *ERROR* Handle 0x8fd80001
already in use!
[76261.126072] [drm:radeon_cs_ioctl [radeon]] *ERROR* Invalid command stream !
[76261.126441] [drm:radeon_uvd_cs_parse [radeon]] *ERROR* Handle 0x8fd80001
already in use!
[76261.126452] [drm:radeon_cs_ioctl [radeon]] *ERROR* Invalid command stream !

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97969] [radeonsi, bisected: fb827c0] Video decoding shows green artifacts

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 623 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97969

Nicolai Hähnle <nhaehnle@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Should be fixed in Mesa master as of commit
13cb41f666212ed50a7939a37a373b4431a84033. Please re-open if the problem
persists.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2174 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97969] [radeonsi, bisected: fb827c0] Video decoding shows green artifacts

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1532 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97969

Alexandre Demers <alexandre.f.demers@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #5 from Alexandre Demers <alexandre.f.demers@gmail.com> ---
(In reply to Nicolai Hähnle from comment #4)
> Should be fixed in Mesa master as of commit
> 13cb41f666212ed50a7939a37a373b4431a84033. Please re-open if the problem
> persists.

I still get a black screen when plating problematic videos with the latest Mesa
from git as of this morning. And I still get the following error:
[...]
[  286.174162] [drm:radeon_uvd_cs_parse [radeon]] *ERROR* invalid reloc offset
13FA000!
[  286.174174] [drm:radeon_cs_ioctl [radeon]] *ERROR* Invalid command stream !
[  286.198203] [drm:radeon_uvd_cs_parse [radeon]] *ERROR* invalid reloc offset
148F000!
[  286.198215] [drm:radeon_cs_ioctl [radeon]] *ERROR* Invalid command stream !
[  286.246226] [drm:radeon_uvd_cs_parse [radeon]] *ERROR* invalid reloc offset
1524000!
[  286.246238] [drm:radeon_cs_ioctl [radeon]] *ERROR* Invalid command stream !
[  286.270245] [drm:radeon_uvd_cs_parse [radeon]] *ERROR* invalid reloc offset
A1D000!
[  286.270257] [drm:radeon_cs_ioctl [radeon]] *ERROR* Invalid command stream !

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3140 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97969] [radeonsi, bisected: fb827c0] Video decoding shows green artifacts

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 793 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97969

--- Comment #6 from Tom <neatnoise@gmail.com> ---
I confirm a bug. It occurs when playing h264 encoded videos using hardware
vdpau acceleration. It happens using many players (tested with mpv, vlc),
kernel 4.7, 4.8 and current mesa-git.

glxinfo:

OpenGL renderer string: Gallium 0.4 on AMD BONAIRE (DRM 2.46.0 /
4.8.0-rc8-mainline, LLVM 4.0.0)
OpenGL core profile version string: 4.3 (Core Profile) Mesa 12.1.0-devel
(git-1d466b9)


dmesg messages while playing videos:

[  212.406985] [drm:radeon_uvd_cs_parse [radeon]] *ERROR* Handle 0x3a200001
already in use!
[  212.406999] [drm:radeon_cs_ioctl [radeon]] *ERROR* Invalid command stream !

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1619 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97969] [radeonsi, bisected: fb827c0] Video decoding shows green artifacts

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 508 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97969

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gringo@slonko.net

--- Comment #7 from Michel Dänzer <michel@daenzer.net> ---
*** Bug 98010 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2103 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97969] [radeonsi, bisected: fb827c0] Video decoding shows green artifacts

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 409 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97969

--- Comment #8 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Now that I actually got to test this on radeon rather than just amdgpu, the
problem was pretty obvious. It's fixed for me with
https://patchwork.freedesktop.org/patch/113573/. I apologize for the
inconvenience.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1308 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97969] [radeonsi, bisected: fb827c0] Video decoding shows green artifacts

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 835 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97969

Alexandre Demers <alexandre.f.demers@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Alexandre Demers <alexandre.f.demers@gmail.com> ---
(In reply to Nicolai Hähnle from comment #8)
> Now that I actually got to test this on radeon rather than just amdgpu, the
> problem was pretty obvious. It's fixed for me with
> https://patchwork.freedesktop.org/patch/113573/. I apologize for the
> inconvenience.

Tested and it seems fixed over here. Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2554 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel