Comment=
# 8
on bug 98005<=
/a>
from Boyuan Zhang
(In reply to Andy Furniss from comment #7)
> (In reply to Boyuan Zhang from comment #6)
> > Hi Andy,
> >=20
> > I just submitted 2 reviews for fixing the bit-rate issue. The 2 p=
atches can
> > be found at
> > https://lists.freedesktop.org/archives/mesa-dev/2016-N=
ovember/134944.html
> >=20
> > 0001-st/va: force to submit two consecutive single jobs
> > 0002-st/va: fix gop size for rate control
> >=20
> > Please give a try and let me know how it works.
> >=20
> > Regards,
> > Boyuan
>=20
> Hi, I can't get those to apply to current mesa head.
>=20
> Checking patch src/gallium/state_trackers/va/picture.c...
> Hunk #1 succeeded at 413 (offset 1 line).
> Hunk #2 succeeded at 568 (offset 1 line).
> Checking patch src/gallium/state_trackers/va/surface.c...
> error: while searching for:
>=20
> if (context->decoder->entrypoint =3D=3D PIPE_VIDEO_ENTRYPOINT=
_ENCODE) {
> int frame_diff;
> if (context->desc.h264enc.frame_num_cnt > surf->frame_n=
um_cnt)
> frame_diff =3D context->desc.h264enc.frame_num_cnt -
> surf->frame_num_cnt;
> else
> frame_diff =3D 0xFFFFFFFF - surf->frame_num_cnt + 1 +
> context->desc.h264enc.frame_num_cnt;
> if (frame_diff < 2)
> context->decoder->flush(context->decoder);
> context->decoder->get_feedback(context->decoder, surf-&=
gt;feedback,
> &(surf->coded_buf->coded_size));
> }
> pipe_mutex_unlock(drv->mutex);
>=20
> error: patch failed: src/gallium/state_trackers/va/surface.c:119
> error: src/gallium/state_trackers/va/surface.c: patch does not apply
> Checking patch src/gallium/state_trackers/va/va_private.h...
> Hunk #2 succeeded at 275 (offset 1 line).
>=20
> and
>=20
> Checking patch src/gallium/state_trackers/va/picture.c...
> Hunk #1 succeeded at 351 (offset 1 line).
> error: while searching for:
> context->desc.h264enc.not_referenced =3D false;
> context->desc.h264enc.is_idr =3D (h264->pic_fields.bits.idr_p=
ic_flag =3D=3D 1);
> context->desc.h264enc.pic_order_cnt =3D h264->CurrPic.TopFiel=
dOrderCnt / 2;
> if (context->desc.h264enc.is_idr)
> context->desc.h264enc.i_remain =3D 1;
> else
> context->desc.h264enc.i_remain =3D 0;
>=20
> context->desc.h264enc.p_remain =3D context->desc.h264enc.gop_=
size -
> context->desc.h264enc.gop_cnt - context->desc.h264enc.i_remain;
>=20
>=20
> error: patch failed: src/gallium/state_trackers/va/picture.c:390
> error: src/gallium/state_trackers/va/picture.c: patch does not apply
> Checking patch src/gallium/state_trackers/va/va_private.h...
Hi Andy,
Sorry about that. Just rebased my codes. Please find the new patches here:
https://lists.freedesktop.org/archives/mesa-dev/2016-November/13=
5076.html
https://lists.freedesktop.org/archives/mesa-dev/2016-November/13=
5077.html
Regards,
Boyuan