From mboxrd@z Thu Jan 1 00:00:00 1970
From: bugzilla-daemon@freedesktop.org
Subject: [Bug 98664] Fragment shader while loop causes geometry corruption
Date: Thu, 17 Nov 2016 17:01:20 +0000
Message-ID:
References:
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0129196859=="
Return-path:
Received: from culpepper.freedesktop.org (culpepper.freedesktop.org
[IPv6:2610:10:20:722:a800:ff:fe98:4b55])
by gabe.freedesktop.org (Postfix) with ESMTP id 3FA156E833
for ; Thu, 17 Nov 2016 17:01:20 +0000 (UTC)
In-Reply-To:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel"
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org
--===============0129196859==
Content-Type: multipart/alternative; boundary="14794020801.dAAe.3724";
charset="UTF-8"
--14794020801.dAAe.3724
Date: Thu, 17 Nov 2016 17:01:20 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
https://bugs.freedesktop.org/show_bug.cgi?id=3D98664
--- Comment #12 from Ilia Mirkin ---
(In reply to Nicolai H=C3=A4hnle from comment #10)
> The geometry shader is incorrect. I guess it works on i965 because the NIR
> path skips some optimizations that are allowed by the GLSL spec, which has
> this to say about EmitVertex():
>=20
> "Emits the current values of output variables to the current
> output primitive. On return from this call, the values of
> output variables are undefined."
>=20
> In other words, you need to store outMinEdge / outMaxEdge in temporary
> variables.
FWIW I've noticed that NVIDIA blob tends to go exactly counter to this, and
explicitly "latches" the values. (While i965 hardware behaves this way by
default, NVIDIA hw does not - it takes extra effort to make it do that, and=
the
NVIDIA blob does it. We've resorted to doing it for gl_Layer/gl_ViewportInd=
ex
in nouveau, but not other varyings.)
Note that it's not necessary to re-emit flat varyings for every vertex, just
the provoking vertex. This tends to be the last vertex by default, I believ=
e.
(And I don't know if that's prior to strip decomposition or not.)
--=20
You are receiving this mail because:
You are the assignee for the bug.=
--14794020801.dAAe.3724
Date: Thu, 17 Nov 2016 17:01:20 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
Commen=
t # 12
on bug 98664<=
/a>
from Ilia Mirkin
(In reply to Nicolai H=C3=A4hnle from comment #10)
> The geometry shader is incorrect. I guess it wor=
ks on i965 because the NIR
> path skips some optimizations that are allowed by the GLSL spec, which=
has
> this to say about EmitVertex():
>=20
> "Emits the current values of output variables to the current
> output primitive. On return from this call, the values of
> output variables are undefined."
>=20
> In other words, you need to store outMinEdge / outMaxEdge in temporary
> variables.
FWIW I've noticed that NVIDIA blob tends to go exactly counter to this, and
explicitly "latches" the values. (While i965 hardware behaves thi=
s way by
default, NVIDIA hw does not - it takes extra effort to make it do that, and=
the
NVIDIA blob does it. We've resorted to doing it for gl_Layer/gl_ViewportInd=
ex
in nouveau, but not other varyings.)
Note that it's not necessary to re-emit flat varyings for every vertex, just
the provoking vertex. This tends to be the last vertex by default, I believ=
e.
(And I don't know if that's prior to strip decomposition or not.)
You are receiving this mail because:
- You are the assignee for the bug.
=
--14794020801.dAAe.3724--
--===============0129196859==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==
--===============0129196859==--