From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground Date: Thu, 17 Nov 2016 16:37:01 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1215836524==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C5B06E821 for ; Thu, 17 Nov 2016 16:37:01 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1215836524== Content-Type: multipart/alternative; boundary="14794006210.bD020f6d.1845"; charset="UTF-8" --14794006210.bD020f6d.1845 Date: Thu, 17 Nov 2016 16:37:01 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D98761 Bug ID: 98761 Summary: [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: arek.rusi@gmail.com QA Contact: dri-devel@lists.freedesktop.org Created attachment 128044 --> https://bugs.freedesktop.org/attachment.cgi?id=3D128044&action=3Dedit ground looks weird mesa/llvm git/trunk kernel 4.8.x & drm-next-4.10-wip this is happend on polaris(rx470) verde works corectly (for radeon drv, amdgpu not tested yet) bisected: 74e39de9324d2d2333cda6adca50ae2a3fc36de2 is the first bad commit commit 74e39de9324d2d2333cda6adca50ae2a3fc36de2 Author: Marek Ol=C5=A1=C3=A1k Date: Fri Oct 28 23:08:50 2016 +0200 radeonsi: set IF_THRESHOLD to 3 Piglit regressions (radeonsi or LLVM bugs, they pass on softpipe): - glsl-1.10/execution/variable-indexing/vs-output-array-vec3-index-wr - glsl-1.10/execution/variable-indexing/vs-output-array-vec4-index-wr - glsl-110/execution/variable-indexing/vs-temp-array-mat2-index-col-row= -wr - glsl-110/execution/variable-indexing/vs-temp-array-mat2-index-row-wr Totals: SGPRS: 1132185 -> 1168801 (3.23 %) VGPRS: 907856 -> 906204 (-0.18 %) Spilled SGPRs: 2011 -> 2425 (20.59 %) Spilled VGPRs: 368 -> 96 (-73.91 %) Scratch VGPRs: 1344 -> 1060 (-21.13 %) dwords per thread Code Size: 35916164 -> 35705372 (-0.59 %) bytes LDS: 767 -> 767 (0.00 %) blocks Max Waves: 194010 -> 194921 (0.47 %) Wait states: 0 -> 0 (0.00 %) Before: VGPR SPILLING APPS Shaders SpillVGPR ScratchVGPR alien_isolation 2938 38 40 bioshock-infinite 1769 245 732 dirt-showdown 548 85 72 f1-2015 776 0 320 ue4_lightroom_inter.. 74 0 180 After: VGPR SPILLING APPS Shaders SpillVGPR ScratchVGPR alien_isolation 2938 38 40 bioshock-infinite 1769 0 480 dirt-showdown 548 58 40 f1-2015 776 0 320 ue4_lightroom_inter.. 74 0 180 Bioshock and DiRT benefit. If I set IF_THRESHOLD=3D4, tesseract starts spilling VGPRs Reviewed-by: Nicolai H=C3=A4hnle :040000 040000 2c773601e2956578e8da4a6031cb02837255b953 7d5f7c3faebe4a11631e70bde258d78fa7357008 M src --=20 You are receiving this mail because: You are the assignee for the bug.= --14794006210.bD020f6d.1845 Date: Thu, 17 Nov 2016 16:37:01 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 98761
Summary [regression][radeonsi][polaris]"radeonsi: set IF_THRESHO= LD to 3" breaks Wither2's ground
Product Mesa
Version git
Hardware Other
OS All
Status NEW
Severity normal
Priority medium
Component Drivers/Gallium/radeonsi
Assignee dri-devel@lists.freedesktop.org
Reporter arek.rusi@gmail.com
QA Contact dri-devel@lists.freedesktop.org 

Created attachment 128044=
 [details]
ground looks weird

mesa/llvm git/trunk
kernel 4.8.x & drm-next-4.10-wip

this is happend on polaris(rx470)
verde works corectly (for radeon drv, amdgpu not tested yet)


bisected:
74e39de9324d2d2333cda6adca50ae2a3fc36de2 is the first bad commit
commit 74e39de9324d2d2333cda6adca50ae2a3fc36de2
Author: Marek Ol=C5=A1=C3=A1k <marek.olsak@amd.com>
Date:   Fri Oct 28 23:08:50 2016 +0200

    radeonsi: set IF_THRESHOLD to 3

    Piglit regressions (radeonsi or LLVM bugs, they pass on softpipe):
    - glsl-1.10/execution/variable-indexing/vs-output-array-vec3-index-wr
    - glsl-1.10/execution/variable-indexing/vs-output-array-vec4-index-wr
    - glsl-110/execution/variable-indexing/vs-temp-array-mat2-index-col-row=
-wr
    - glsl-110/execution/variable-indexing/vs-temp-array-mat2-index-row-wr

    Totals:
    SGPRS: 1132185 -> 1168801 (3.23 %)
    VGPRS: 907856 -> 906204 (-0.18 %)
    Spilled SGPRs: 2011 -> 2425 (20.59 %)
    Spilled VGPRs: 368 -> 96 (-73.91 %)
    Scratch VGPRs: 1344 -> 1060 (-21.13 %) dwords per thread
    Code Size: 35916164 -> 35705372 (-0.59 %) bytes
    LDS: 767 -> 767 (0.00 %) blocks
    Max Waves: 194010 -> 194921 (0.47 %)
    Wait states: 0 -> 0 (0.00 %)

    Before:
     VGPR SPILLING APPS   Shaders SpillVGPR ScratchVGPR
     alien_isolation         2938        38        40
     bioshock-infinite       1769       245       732
     dirt-showdown            548        85        72
     f1-2015                  776         0       320
     ue4_lightroom_inter..     74         0       180

    After:
     VGPR SPILLING APPS   Shaders SpillVGPR ScratchVGPR
     alien_isolation         2938        38        40
     bioshock-infinite       1769         0       480
     dirt-showdown            548        58        40
     f1-2015                  776         0       320
     ue4_lightroom_inter..     74         0       180

    Bioshock and DiRT benefit.

    If I set IF_THRESHOLD=3D4, tesseract starts spilling VGPRs

    Reviewed-by: Nicolai H=C3=A4hnle <nicolai.haehnle@amd.com>

:040000 040000 2c773601e2956578e8da4a6031cb02837255b953
7d5f7c3faebe4a11631e70bde258d78fa7357008 M      src

You are receiving this mail because:
  • You are the assignee for the bug.
= --14794006210.bD020f6d.1845-- --===============1215836524== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1215836524==--