Comment=
# 9
on bug 99349<=
/a>
from Gert Wollny
It turns out that in r600_shader.c:tgsi_split_constant the con=
stants should be
moved to the GPR range, but for large shaders this is not sufficient, since=
the
temporary registers used there may be beyond 127 which is the limit for GPR=
s.=20
tgsi_split_constant doesn't move all constants and if an operator uses the =
same
constant as source more than once, then one of the instances of the constan=
ts
is moved to a new address, and this may even be counter productive.=20
Now to fix this bug, a partial workaround is in the repo I've given above, =
the
patch changes the register handling to reserve a few registers in the low r=
ange
and moves constants there if necessary. Note, however, that it also contains
additional debugging output.=20
However, for the instruction=20
LRP TEMP[0].xyz, CONST[31].wwww, CONST[31].xyzz, TEMP[0].xyzz
check_and_set_bank_swizzle still fails. (This is, by the way, one such case
where=20
tgsi_split_constant moves one of the instances of CONST[31] to another plac=
e.)=20
I will try to correct tgsi_split_constant to not move the values around if
they are originally from the same source and see whether this fixes the
problem.