[Bug 99850] Tessellation bug on Carrizo

[Bug 99850] Tessellation bug on Carrizo

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1953 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99850

            Bug ID: 99850
           Summary: Tessellation bug on Carrizo
           Product: Mesa
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: tom.stdenis@amd.com
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 129692
  --> https://bugs.freedesktop.org/attachment.cgi?id=129692&action=edit
carrizo run with HEAD

Tessellation is broken on Carrizo (A12-9800) hardware and apparently has been
for a while.  The offending commit is 

commit a4e2146a9d24592ed7e3bf778e3c21c6cfb89330
Author: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Date:   Mon May 2 14:55:52 2016 +0200

    radeonsi: Use buffer loads and stores for passing data from TCS to TES.

    We always try to use 4-component loads, as LLVM does not combine loads
    and they bypass the L1 cache.

    We can't use a similar strategy for stores and this is especially
    notable with the tess factors, as they are often set with separate
    MOV's per component in the TGSI.

    We keep storing to LDS and the LDS space, so we can load the outputs
    later, either due to the shader, of for wrting the tess factors.

    Signed-off-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
    Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
    Reviewed-by: Marek Olšák <marek.olsak@amd.com>

I found it via running Unigine-Heaven with tessellation enabled.

The bug doesn't occur on other VI hardware (Polaris10, FIJI).

I can confirm that the HEAD~ commit leads to spec/arb_tessellation_shader/*
tests (in piglit) passing compared to running with HEAD.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3671 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99850] Tessellation bug on Carrizo

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 316 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99850

--- Comment #1 from Tom St Denis <tom.stdenis@amd.com> ---
Created attachment 129693
  --> https://bugs.freedesktop.org/attachment.cgi?id=129693&action=edit
Carrizo run with HEAD~

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99850] Tessellation bug on Carrizo

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 358 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99850

--- Comment #2 from Tom St Denis <tom.stdenis@amd.com> ---
Dug up the original thread that introduced this patch.  Might prove useful in
debugging it.

https://lists.freedesktop.org/archives/mesa-dev/2016-May/116152.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1178 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99850] Tessellation bug on Carrizo

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 468 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99850

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bas@basnieuwenhuizen.nl

--- Comment #3 from Michel Dänzer <michel@daenzer.net> ---
Bas, any ideas?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1729 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99850] Tessellation bug on Carrizo

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1014 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99850

--- Comment #4 from Tom St Denis <tom.stdenis@amd.com> ---
Alex commented that mesa could use this addition to the kmd to selectively
enable/disable this feature on APUs

commit 921e71c548b313f704745dcc609ffb0206da1afe                  
Author:     Junwei Zhang <Jerry.Zhang@amd.com>                   
AuthorDate: Fri Feb 17 11:05:49 2017 +0800                       
Commit:     Junwei Zhang <Jerry.Zhang@amd.com>                   
CommitDate: Tue Feb 21 10:22:30 2017 +0800                       

    drm/amdgpu: export gfx config double offchip LDS buffers (v3)

    v2: move the config struct to drm_amdgpu_info_device
    v3: move the config feature to amdgpu_gca_config

    Change-Id: I9651ab3e06a2d3c891b4c52a5da5b4a45d5809e5
    Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com>            
    Reviewed-by: Christian König <christian.koenig@amd.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1976 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99850] Tessellation bug on Carrizo

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 493 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99850

--- Comment #5 from Alex Deucher <alexdeucher@gmail.com> ---
(In reply to Tom St Denis from comment #4)
> Alex commented that mesa could use this addition to the kmd to selectively
> enable/disable this feature on APUs

Not to selectively enable, but I think it might be related.  We may need some
adjustments in the UMD to deal with the hw differences.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1305 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99850] Tessellation bug on Carrizo

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1126 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99850

--- Comment #6 from Marek Olšák <maraeo@gmail.com> ---
You can try this diff:

diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c
b/src/gallium/drivers/radeonsi/si_state_shaders.c
index f615aa8..750cdd6 100644
--- a/src/gallium/drivers/radeonsi/si_state_shaders.c
+++ b/src/gallium/drivers/radeonsi/si_state_shaders.c
@@ -2312,7 +2312,9 @@ static bool si_update_spi_tmpring_size(struct si_context
*sctx)

 static void si_init_tess_factor_ring(struct si_context *sctx)
 {
-       bool double_offchip_buffers = sctx->b.chip_class >= CIK;
+       bool double_offchip_buffers = sctx->b.chip_class >= CIK &&
+                                     sctx->b.family != CHIP_CARRIZO &&
+                                     sctx->b.family != CHIP_STONEY;
        unsigned max_offchip_buffers_per_se = double_offchip_buffers ? 128 :
64;
        unsigned max_offchip_buffers = max_offchip_buffers_per_se *
                                       sctx->screen->b.info.max_se;

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1917 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99850] Tessellation bug on Carrizo

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99850

--- Comment #7 from Tom St Denis <tom.stdenis@amd.com> ---
I'll try this momentarily (rig is configured for polaris10).

Probably cleaner though to check the flag from the KMD though in the long run
right?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1080 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99850] Tessellation bug on Carrizo

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 598 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99850

Tom St Denis <tom.stdenis@amd.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #8 from Tom St Denis <tom.stdenis@amd.com> ---
With that diff applied unigine-heaven works with tess enabled on the tip of
mesa{master} as of right now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2028 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99850] Tessellation bug on Carrizo

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 290 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99850

--- Comment #9 from Tom St Denis <tom.stdenis@amd.com> ---
Confirmed 1759 "pass"'es with tessellation tests in piglit vs 1724 passes with
HEAD~.

Yipee.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1089 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99850] Tessellation bug on Carrizo

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 786 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99850

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #10 from Michel Dänzer <michel@daenzer.net> ---
Bug reports should only be resolved once the fix has landed in Git, preferably
with a reference to the commit fixing it.

BTW, always specify explicit Git commit hashes instead of "HEAD". HEAD refers
to the currently checked out commit, it has no meaning outside of your local
repository.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99850] Tessellation bug on Carrizo

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 426 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99850

--- Comment #11 from Tom St Denis <tom.stdenis@amd.com> ---
Thanks Michel, I was a bit quick in closing the bug.

Note the bug description mentions the offending commit hash so instead of
pasting that everywhere I called that HEAD and the good commit HEAD~. 
Conventions I suppose... :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1184 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99850] Tessellation bug on Carrizo

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 571 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99850

Samuel Pitoiset <samuel.pitoiset@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #12 from Samuel Pitoiset <samuel.pitoiset@gmail.com> ---
Should be fixed by 35915af6c9ab4bdc0f1f8584ca346602405bd7e4.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2025 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel