From: Melissa Wen <mwen@igalia.com>
To: airlied@gmail.com, alexander.deucher@amd.com,
christian.koenig@amd.com, harry.wentland@amd.com,
simona@ffwll.ch, sunpeng.li@amd.com
Cc: "Xaver Hugl" <xaver.hugl@gmail.com>,
"Christopher Snowhill" <kode54@gmail.com>,
"Michel Dänzer" <mdaenzer@redhat.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kernel-dev@igalia.com
Subject: Re: [PATCH 0/2] drm/amd/display: don't overwrite regamma LUT with empty data
Date: Mon, 1 Sep 2025 18:46:45 -0300 [thread overview]
Message-ID: <c10c7918-a073-4c3f-85c5-3ebb25133723@igalia.com> (raw)
In-Reply-To: <20250822211552.1472375-1-mwen@igalia.com>
On 22/08/2025 18:14, Melissa Wen wrote:
> Hey,
>
>
> KDE/Plasma users reported some flickering when applying the regamma CRTC
> LUT to an AMD display hardware set using an external or integrated
> screen. There is some instability in how the driver stores and updates
> color blocks based on color management changes or full update request.
> It uses update_flag bits for surface and stream and forces some color
> blocks to update without considering the previous settings.
>
> This two-patch series avoids this issue by
> (1) not calling set_output_transfer_func when the output TF has not
> changed;
> (2) preserve the previous out_tf value in the case of a full
> update, which was unconditionally setting all update_flag bits to true
> regardless of previous values.
>
> This modifies DC and may affect behavior on other platforms. On the
> other hand, it avoids unnecessary reprogramming of MPC output gamma.
FWIW, I just sent a v2 with a completely different approach that solves
all Gamma LUT issues on DM (without touching DC).
https://lore.kernel.org/amd-gfx/20250901214413.12675-1-mwen@igalia.com/
Melissa
>
> Melissa
>
> Melissa Wen (2):
> Revert "drm/amd/display: program output tf when required"
> drm/amd/display: don't update out gamma if out_tf didn't change
>
> drivers/gpu/drm/amd/display/dc/core/dc.c | 5 +++++
> drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 5 +----
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
prev parent reply other threads:[~2025-09-01 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 21:14 [PATCH 0/2] drm/amd/display: don't overwrite regamma LUT with empty data Melissa Wen
2025-08-22 21:14 ` [PATCH 1/2] Revert "drm/amd/display: program output tf when required" Melissa Wen
2025-08-22 21:14 ` [PATCH 2/2] drm/amd/display: don't update out gamma if out_tf didn't change Melissa Wen
2025-08-22 21:22 ` [PATCH 0/2] drm/amd/display: don't overwrite regamma LUT with empty data Melissa Wen
2025-09-01 21:46 ` Melissa Wen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c10c7918-a073-4c3f-85c5-3ebb25133723@igalia.com \
--to=mwen@igalia.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=kernel-dev@igalia.com \
--cc=kode54@gmail.com \
--cc=mdaenzer@redhat.com \
--cc=simona@ffwll.ch \
--cc=sunpeng.li@amd.com \
--cc=xaver.hugl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).