From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 13/16] drm/omap: use u32 instead of enum omap_color_mode Date: Wed, 24 May 2017 13:37:48 +0300 Message-ID: References: <1493893412-12178-1-git-send-email-tomi.valkeinen@ti.com> <1493893412-12178-14-git-send-email-tomi.valkeinen@ti.com> <2936246.4Oq3uqjSjE@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0365963773==" Return-path: Received: from lelnx194.ext.ti.com (lelnx194.ext.ti.com [198.47.27.80]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E8ED8984E for ; Wed, 24 May 2017 10:37:53 +0000 (UTC) In-Reply-To: <2936246.4Oq3uqjSjE@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Jyri Sarha , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0365963773== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UceWB0cxmlKULIKgua7jhAJ3b4LOVFLhR" --UceWB0cxmlKULIKgua7jhAJ3b4LOVFLhR Content-Type: multipart/mixed; boundary="e5u6inf9Noa8saE74bgK6mgiOUMWtNH5Q"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Jyri Sarha Message-ID: Subject: Re: [PATCH 13/16] drm/omap: use u32 instead of enum omap_color_mode References: <1493893412-12178-1-git-send-email-tomi.valkeinen@ti.com> <1493893412-12178-14-git-send-email-tomi.valkeinen@ti.com> <2936246.4Oq3uqjSjE@avalon> In-Reply-To: <2936246.4Oq3uqjSjE@avalon> --e5u6inf9Noa8saE74bgK6mgiOUMWtNH5Q Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 24/05/17 13:28, Laurent Pinchart wrote: > Hi Tomi, >=20 > Thank you for the patch. >=20 > On Thursday 04 May 2017 13:23:29 Tomi Valkeinen wrote: >> In this step we drop 'enum omap_color_mode', and use u32 instead. >> >> Signed-off-by: Tomi Valkeinen >=20 > I believe this should go before 12/16, otherwise you end up temporarily= =20 > storing DRM_FORMAT_* values in enum omap_color_mode variables. That's on purpose, I mention it in the previous patch. Do you see a problem with it? If I change the order, then I'd be going back and forth with u32 and enum omap_color_mode. But I could squash this and 12 together. That's perhaps the technically most correct option, but I wanted to split the changes into a bit smaller pieces. Tomi --e5u6inf9Noa8saE74bgK6mgiOUMWtNH5Q-- --UceWB0cxmlKULIKgua7jhAJ3b4LOVFLhR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZJWJ8AAoJEPo9qoy8lh71xHMQAJkAfVzLYROOw9bNxkCC2EGJ KSo9068Z0SdfHqQaWN6XjYnEwNiW7wHhGXkuYPDObHH0bYANYNbGXtgdPuJ1kojt 1bZV/ZmasA4FCarsI4vo2SjSxQzsxrKn/diNmKzvm2icvucaFcVaHEz1zuA6Aa// ZfdhOPSPEFHMYuDGB/H5LXGGoBvWz3MznRc5mfqym4W1tkYjv41qSgFwkvwF+8Ua GqO0FKnytb+f7RWmIzy7XMDiNGsswSVsivB06ridrL6ICdWioY7tbKYKBw8HnBXT ttjPA6wofFNqdNvFLMa+PHNlPXnzuYTd7Bz3jmGYv8BTJ2Mdj2J5cnUXEFM1HZHk gU4hFUt7ckiV52pqd7sEfEJ80tz9zLnduKUmdopYD0w9a/DILUeIckk38eWphH0G XHnvznAUs2Dsgkdc40AaTPyNGU5qCA2dAPvG2y7+VM6sfW8C0qFj73SAdlQo+DKL ByEoyYKLfdGrk5nw9nhRiRTJJR5yowxr+FkqT9FNMTK5pnY9GvhntuwBrnIQhFQ2 dL5PxhT6PKxfyg1vyqh4dzK+XT4qgfnbZTD5HfhoGxp8XzKHRb1SGZXzzRVwiClV zsRw8QNMyleO6HP9hvwIGVK6q7E5RyUY9nyfedkbuCWOo4Q5f+jdw6G8fpDWTaa7 VSMLASOgEEuy0XRR7XIB =KRqX -----END PGP SIGNATURE----- --UceWB0cxmlKULIKgua7jhAJ3b4LOVFLhR-- --===============0365963773== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0365963773==--