From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Kuehling Subject: Re: [PATCH] drm/amdkfd: Fix potential NULL pointer dereferences Date: Wed, 10 Jan 2018 13:33:20 -0500 Message-ID: References: <20180110165008.GA10691@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180110165008.GA10691-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org> Content-Language: en-CA List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Gustavo A. R. Silva" , Oded Gabbay , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: dri-devel@lists.freedesktop.org SGkgR3VzdGF2bywKClRoYW5rcyBmb3IgY2F0Y2hpbmcgdGhhdC4gV2hlbiByZXR1cm5pbmcgYSBm YXVsdCwgSSB0aGluayB5b3UgYWxzbyBuZWVkCnRvIHNyY3VfcmVhZF91bmxvY2soJmtmZF9wcm9j ZXNzZXNfc3JjdSwgaWR4KS4KCkhvd2V2ZXIsIGluc3RlYWQgb2YgcmV0dXJuaW5nIGFuIGVycm9y LCBJIHRoaW5rIEknZCBwcmVmZXIgdG8gc2tpcCBQRERzCnRoYXQgY2FuJ3QgYmUgZm91bmQgd2l0 aCBjb250aW51ZSBzdGF0ZW1lbnRzLiBUaGF0IHdheSBvdGhlcnMgd291bGQKc3RpbGwgc3VzcGVu ZCBhbmQgcmVzdW1lIHN1Y2Nlc3NmdWxseS4gTWF5YmUganVzdCBwcmludCBhIFdBUk5fT04gZm9y ClBERHMgdGhhdCBhcmVuJ3QgZm91bmQsIGJlY2F1c2UgdGhhdCdzIGFuIHVuZXhwZWN0ZWQgc2l0 dWF0aW9uLApjdXJyZW50bHkuIE1heWJlIGluIHRoZSBmdXR1cmUgaXQgY291bGQgYmUgbm9ybWFs IHRoaW5nIGlmIHdlIGV2ZXIKc3VwcG9ydCBHUFUgaG90cGx1Zy4KClJlZ2FyZHMsCsKgIEZlbGl4 CgoKT24gMjAxOC0wMS0xMCAxMTo1MCBBTSwgR3VzdGF2byBBLiBSLiBTaWx2YSB3cm90ZToKPiBJ biBjYXNlIGtmZF9nZXRfcHJvY2Vzc19kZXZpY2VfZGF0YSByZXR1cm5zIG51bGwsIHRoZXJlIGFy ZSBzb21lCj4gbnVsbCBwb2ludGVyIGRlcmVmZXJlbmNlcyBpbiBmdW5jdGlvbnMga2ZkX2JpbmRf cHJvY2Vzc2VzX3RvX2RldmljZQo+IGFuZCBrZmRfdW5iaW5kX3Byb2Nlc3Nlc19mcm9tX2Rldmlj ZS4KPgo+IEZpeCB0aGlzIGJ5IG51bGwgY2hlY2tpbmcgcGRkIGJlZm9yZSBkZXJlZmVyZW5jaW5n IGl0Lgo+Cj4gQWRkcmVzc2VzLUNvdmVyaXR5LUlEOiAxNDYzNzk0ICgiRGVyZWZlcmVuY2UgbnVs bCByZXR1cm4gdmFsdWUiKQo+IEFkZHJlc3Nlcy1Db3Zlcml0eS1JRDogMTQ2Mzc3MiAoIkRlcmVm ZXJlbmNlIG51bGwgcmV0dXJuIHZhbHVlIikKPiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIu IFNpbHZhIDxnYXJzaWx2YUBlbWJlZGRlZG9yLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRrZmQva2ZkX3Byb2Nlc3MuYyB8IDEyICsrKysrKysrKysrKwo+ICAxIGZpbGUgY2hh bmdlZCwgMTIgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1ka2ZkL2tmZF9wcm9jZXNzLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRf cHJvY2Vzcy5jCj4gaW5kZXggYTIyZmIwNzEuLjI5ZDUxZDUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX3Byb2Nlc3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1ka2ZkL2tmZF9wcm9jZXNzLmMKPiBAQCAtNDYxLDYgKzQ2MSwxMyBAQCBpbnQga2Zk X2JpbmRfcHJvY2Vzc2VzX3RvX2RldmljZShzdHJ1Y3Qga2ZkX2RldiAqZGV2KQo+ICAJaGFzaF9m b3JfZWFjaF9yY3Uoa2ZkX3Byb2Nlc3Nlc190YWJsZSwgdGVtcCwgcCwga2ZkX3Byb2Nlc3Nlcykg ewo+ICAJCW11dGV4X2xvY2soJnAtPm11dGV4KTsKPiAgCQlwZGQgPSBrZmRfZ2V0X3Byb2Nlc3Nf ZGV2aWNlX2RhdGEoZGV2LCBwKTsKPiArCj4gKwkJaWYgKCFwZGQpIHsKPiArCQkJcHJfZXJyKCJQ cm9jZXNzIGRldmljZSBkYXRhIGRvZXNuJ3QgZXhpc3RcbiIpOwo+ICsJCQltdXRleF91bmxvY2so JnAtPm11dGV4KTsKPiArCQkJcmV0dXJuIC1FRkFVTFQ7Cj4gKwkJfQo+ICsKPiAgCQlpZiAocGRk LT5ib3VuZCAhPSBQRERfQk9VTkRfU1VTUEVOREVEKSB7Cj4gIAkJCW11dGV4X3VubG9jaygmcC0+ bXV0ZXgpOwo+ICAJCQljb250aW51ZTsKPiBAQCAtNTAxLDYgKzUwOCwxMSBAQCB2b2lkIGtmZF91 bmJpbmRfcHJvY2Vzc2VzX2Zyb21fZGV2aWNlKHN0cnVjdCBrZmRfZGV2ICpkZXYpCj4gIAkJbXV0 ZXhfbG9jaygmcC0+bXV0ZXgpOwo+ICAJCXBkZCA9IGtmZF9nZXRfcHJvY2Vzc19kZXZpY2VfZGF0 YShkZXYsIHApOwo+ICAKPiArCQlpZiAoIXBkZCkgewo+ICsJCQltdXRleF91bmxvY2soJnAtPm11 dGV4KTsKPiArCQkJcmV0dXJuOwo+ICsJCX0KPiArCj4gIAkJaWYgKHBkZC0+Ym91bmQgPT0gUERE X0JPVU5EKQo+ICAJCQlwZGQtPmJvdW5kID0gUEREX0JPVU5EX1NVU1BFTkRFRDsKPiAgCQltdXRl eF91bmxvY2soJnAtPm11dGV4KTsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1k LWdmeAo=