Re: [PATCH v2 0/3] drm/vmwgfx: Use DRM's vblank timer

[Thomas Zimmermann <tzimmermann@suse.de>]

Hi

Am 28.04.26 um 07:54 schrieb Zack Rusin:
> On Mon, Apr 27, 2026 at 11:02 AM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> Replace vmwgfx's vblank timer with DRM's shared implementation. The
>> common code is mostly equivalent, but provides additional protection
>> against concurrent changes to the vblank counter.
>>
>> Patches 1 and 2 align vmwgfx with the shared code, so that it can be
>> converted easily.
>>
>> The conversion is in patch 3. It replaces vmwgfx's custom timer with
>> calls to DRM's vblank interfaces. Initialization happens internally.
>>
>> This series should get some more testing.
>>
>> v2:
>> - patch 3: fix vblank cancalling in CRTC cleanup (Zack)
>> - patch 2: mention timer restart in commit message (Zack)
>>
>> Thomas Zimmermann (3):
>>    drm/vmwgfx: Determine lock-waiting timeout from vblank state
>>    drm/vmwgfx: Move vblank handling into separate helper
>>    drm/vmwgfx: Convert to DRM vblank timers
>>
>>   drivers/gpu/drm/vmwgfx/vmwgfx_kms.h  |  2 -
>>   drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c  |  1 +
>>   drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c |  1 +
>>   drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c |  1 +
>>   drivers/gpu/drm/vmwgfx/vmwgfx_vkms.c | 70 ++++++++--------------------
>>   drivers/gpu/drm/vmwgfx/vmwgfx_vkms.h |  2 +-
>>   6 files changed, 24 insertions(+), 53 deletions(-)
>>
>> --
>> 2.54.0
>
> Looks great! Feel free to push through drm-misc-next or I can do it
> for you if you prefer.

I'll merge it in a few days if no further reviews come in.

>
> Reviewed-by: Zack Rusin <zack.rusin@broadcom.com>

Thanks a lot.

Best regards
Thomas

>
> z

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)