From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49A4DC4332F for ; Mon, 7 Nov 2022 19:27:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 46BB210E397; Mon, 7 Nov 2022 19:27:19 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAEF410E397 for ; Mon, 7 Nov 2022 19:27:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667849234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=patZqZFG+VP3DSfi5ljEiY21OGL00v17le5HXIzu3EI=; b=VRdhnkhUl+iWTk9TtiNrq1Evcl6myw1og64CiR7QLYU6nbfscD9wjjtJTAJeQTIIS4xKso EZ2jlOm7soFbDyKiGryMSqxC3bGe4v5D7xNqcblPQcyYKTd4TcKfZ2dHS1wd3pNUpc7Xyt W7203K45N7CBuYjAnbedPGy2Xh1p1o4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-247-si1zOBc9NQmzSEqpHksyuQ-1; Mon, 07 Nov 2022 14:27:13 -0500 X-MC-Unique: si1zOBc9NQmzSEqpHksyuQ-1 Received: by mail-wm1-f69.google.com with SMTP id h204-20020a1c21d5000000b003cf4e055442so6218944wmh.1 for ; Mon, 07 Nov 2022 11:27:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=patZqZFG+VP3DSfi5ljEiY21OGL00v17le5HXIzu3EI=; b=nFtut2vH+2nqH44FiclNcFEKqGyZwdg/G8rX14kXGnKrv+IS26ZAFKtUP1WaYCTiWo J4nBJATNz5bryBwd5yfuhPN30NdLxMBEOHEztDLhcSso5Kta34Jxmnxu97nhAYvgDn21 4ZycQhGlxZgdMAZghYgAvAYUlJzZvV/HN3L82XmEOwQjBWzoMkcqmcPfrRCUJvjMXxrO H1DreoeUQS5zP0VyX1nrvjzoky1A7P2g+HzJYc9ugve0B77O5FfCb5mJgotjsxnt4fa0 v+6p40urmd6+uKb6xhDZ+8qDdez+TaA0eSduj6Cav5ny9fUznR1dbqxX9jqGU3FNCCn/ JzQg== X-Gm-Message-State: ACrzQf375Est9kns98oUtI3Kyd3ZCeOHSRsCiPTYjxmOblCFiUKjR9vu 3ftkDH9X23wrwUDjhbIFyv3xxbA8/Zizl7Zd2D41CEpDRfG3/xxhh9Ki2ymAIIgT0qg91Ez9vcX WK404JC/2rTIJRzlnmWUcVP3kT88z X-Received: by 2002:a5d:4487:0:b0:22e:3292:75ab with SMTP id j7-20020a5d4487000000b0022e329275abmr614299wrq.166.1667849232536; Mon, 07 Nov 2022 11:27:12 -0800 (PST) X-Google-Smtp-Source: AMsMyM7WA0QO9a9aE/aCsv95kc1/GI2mA1rxsv3w8NpMMhNZXKsgaEBfixEFS4BMiXoamohO6ncLKQ== X-Received: by 2002:a5d:4487:0:b0:22e:3292:75ab with SMTP id j7-20020a5d4487000000b0022e329275abmr614274wrq.166.1667849232188; Mon, 07 Nov 2022 11:27:12 -0800 (PST) Received: from ?IPV6:2003:cb:c704:7800:3f13:77ac:9360:5e22? (p200300cbc70478003f1377ac93605e22.dip0.t-ipconnect.de. [2003:cb:c704:7800:3f13:77ac:9360:5e22]) by smtp.gmail.com with ESMTPSA id t20-20020a05600c199400b003cf9bf5208esm10877851wmq.19.2022.11.07.11.27.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 11:27:11 -0800 (PST) Message-ID: Date: Mon, 7 Nov 2022 20:27:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH RFC 05/19] mm: add early FAULT_FLAG_WRITE consistency checks To: Nadav Amit References: <20221107161740.144456-1-david@redhat.com> <20221107161740.144456-6-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "dri-devel@lists.freedesktop.org" , Linux-MM , "linux-kselftest@vger.kernel.org" , Andrea Arcangeli , "linux-samsung-soc@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Hugh Dickins , Matthew Wilcox , Jason Gunthorpe , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , Arnd Bergmann , John Hubbard , "etnaviv@lists.freedesktop.org" , Peter Xu , Muchun Song , Vlastimil Babka , Greg Kroah-Hartman , Oded Gabbay , kernel list , Andrew Morton , Mike Kravetz , Linus Torvalds Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 07.11.22 20:03, Nadav Amit wrote: > On Nov 7, 2022, at 8:17 AM, David Hildenbrand wrote: > >> !! External Email >> >> Let's catch abuse of FAULT_FLAG_WRITE early, such that we don't have to >> care in all other handlers and might get "surprises" if we forget to do >> so. >> >> Write faults without VM_MAYWRITE don't make any sense, and our >> maybe_mkwrite() logic could have hidden such abuse for now. >> >> Write faults without VM_WRITE on something that is not a COW mapping is >> similarly broken, and e.g., do_wp_page() could end up placing an >> anonymous page into a shared mapping, which would be bad. >> >> This is a preparation for reliable R/O long-term pinning of pages in >> private mappings, whereby we want to make sure that we will never break >> COW in a read-only private mapping. >> >> Signed-off-by: David Hildenbrand >> --- >> mm/memory.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/mm/memory.c b/mm/memory.c >> index fe131273217a..826353da7b23 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -5159,6 +5159,14 @@ static vm_fault_t sanitize_fault_flags(struct vm_area_struct *vma, >> */ >> if (!is_cow_mapping(vma->vm_flags)) >> *flags &= ~FAULT_FLAG_UNSHARE; >> + } else if (*flags & FAULT_FLAG_WRITE) { >> + /* Write faults on read-only mappings are impossible ... */ >> + if (WARN_ON_ONCE(!(vma->vm_flags & VM_MAYWRITE))) >> + return VM_FAULT_SIGSEGV; >> + /* ... and FOLL_FORCE only applies to COW mappings. */ >> + if (WARN_ON_ONCE(!(vma->vm_flags & VM_WRITE) && >> + !is_cow_mapping(vma->vm_flags))) >> + return VM_FAULT_SIGSEGV; > > Not sure about the WARN_*(). Seems as if it might trigger in benign even if > rare scenarios, e.g., mprotect() racing with page-fault. > We most certainly would want to catch any such broken/racy cases. There are no benign cases I could possibly think of. Page faults need the mmap lock in read. mprotect() / VMA changes need the mmap lock in write. Whoever calls handle_mm_fault() is supposed to properly check VMA permissions. -- Thanks, David / dhildenb