From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v2] drm/scheduler: remove timeout work_struct from drm_sched_job Date: Sat, 22 Sep 2018 09:23:04 +0200 Message-ID: References: <20180921185736.2066-1-nayan26deshmukh@gmail.com> Reply-To: christian.koenig@amd.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86632880C8 for ; Sat, 22 Sep 2018 07:23:07 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id e1-v6so14833172wrt.3 for ; Sat, 22 Sep 2018 00:23:07 -0700 (PDT) In-Reply-To: <20180921185736.2066-1-nayan26deshmukh@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nayan Deshmukh , dri-devel@lists.freedesktop.org Cc: christian.koenig@amd.com List-Id: dri-devel@lists.freedesktop.org QW0gMjEuMDkuMjAxOCB1bSAyMDo1NyBzY2hyaWViIE5heWFuIERlc2htdWtoOgo+IGhhdmluZyBh IGRlbGF5ZWQgd29yayBpdGVtIHBlciBqb2IgaXMgcmVkdW5kYW50IGFzIHdlIG9ubHkgbmVlZCBv bmUKPiBwZXIgc2NoZWR1bGVyIHRvIHRyYWNrIHRoZSB0aW1lIG91dCB0aGUgY3VycmVudGx5IGV4 ZWN1dGluZyBqb2IuCj4KPiB2MjogdGhlIGZpcnN0IGVsZW1lbnQgb2YgdGhlIHJpbmcgbWlycm9y IGxpc3QgaXMgdGhlIGN1cnJlbnRseQo+IGV4ZWN1dGluZyBqb2Igc28gd2UgZG9uJ3QgbmVlZCBh IGFkZGl0aW9uYWwgdmFyaWFibGUgZm9yIGl0Cj4KPiBTaWduZWQtb2ZmLWJ5OiBOYXlhbiBEZXNo bXVraCA8bmF5YW4yNmRlc2htdWtoQGdtYWlsLmNvbT4KPiBTdWdnZXN0ZWQtYnk6IENocmlzdGlh biBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1 L2RybS9zY2hlZHVsZXIvc2NoZWRfbWFpbi5jIHwgMjggKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0tLQo+ICAgaW5jbHVkZS9kcm0vZ3B1X3NjaGVkdWxlci5oICAgICAgICAgICAgfCAgNiArKyst LS0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0p Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMg Yi9kcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL3NjaGVkX21haW4uYwo+IGluZGV4IDljYTc0MWYz YTBiYy4uODhmNmNmZjEzNmYyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zY2hlZHVs ZXIvc2NoZWRfbWFpbi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9t YWluLmMKPiBAQCAtMTk3LDE5ICsxOTcsMTYgQEAgc3RhdGljIHZvaWQgZHJtX3NjaGVkX2pvYl9m aW5pc2goc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAgCSAqIG1hbmFnZXMgdG8gZmluZCB0 aGlzIGpvYiBhcyB0aGUgbmV4dCBqb2IgaW4gdGhlIGxpc3QsIHRoZSBmZW5jZQo+ICAgCSAqIHNp Z25hbGVkIGNoZWNrIGJlbG93IHdpbGwgcHJldmVudCB0aGUgdGltZW91dCB0byBiZSByZXN0YXJ0 ZWQuCj4gICAJICovCj4gLQljYW5jZWxfZGVsYXllZF93b3JrX3N5bmMoJnNfam9iLT53b3JrX3Rk cik7Cj4gKwljYW5jZWxfZGVsYXllZF93b3JrX3N5bmMoJnNjaGVkLT53b3JrX3Rkcik7Cj4gICAK PiAgIAlzcGluX2xvY2soJnNjaGVkLT5qb2JfbGlzdF9sb2NrKTsKPiAgIAkvKiBxdWV1ZSBURFIg Zm9yIG5leHQgam9iICovCj4gKwlsaXN0X2RlbCgmc19qb2ItPm5vZGUpOwo+ICAgCWlmIChzY2hl ZC0+dGltZW91dCAhPSBNQVhfU0NIRURVTEVfVElNRU9VVCAmJgo+IC0JICAgICFsaXN0X2lzX2xh c3QoJnNfam9iLT5ub2RlLCAmc2NoZWQtPnJpbmdfbWlycm9yX2xpc3QpKSB7Cj4gLQkJc3RydWN0 IGRybV9zY2hlZF9qb2IgKm5leHQgPSBsaXN0X25leHRfZW50cnkoc19qb2IsIG5vZGUpOwo+IC0K PiAtCQlpZiAoIWRtYV9mZW5jZV9pc19zaWduYWxlZCgmbmV4dC0+c19mZW5jZS0+ZmluaXNoZWQp KQo+IC0JCQlzY2hlZHVsZV9kZWxheWVkX3dvcmsoJm5leHQtPndvcmtfdGRyLCBzY2hlZC0+dGlt ZW91dCk7Cj4gKwkgICAgIWxpc3RfZW1wdHkoJnNjaGVkLT5yaW5nX21pcnJvcl9saXN0KSkgewo+ ICsJCXNjaGVkdWxlX2RlbGF5ZWRfd29yaygmc2NoZWQtPndvcmtfdGRyLCBzY2hlZC0+dGltZW91 dCk7Cj4gICAJfQoKWW91IGNhbiByZW1vdmUgdGhlIHt9IGhlcmUgYXMgd2VsbC4KCj4gICAJLyog cmVtb3ZlIGpvYiBmcm9tIHJpbmdfbWlycm9yX2xpc3QgKi8KClRoYXQgY29tbWVudCBzaG91bGQg bW92ZSB3aXRoIHRoZSBsaXN0X2RlbCgpLgoKQXBhcnQgZnJvbSB0aGF0IGl0IGxvb2tzIGdvb2Qg dG8gbWUsCkNocmlzdGlhbi4KCj4gLQlsaXN0X2RlbCgmc19qb2ItPm5vZGUpOwo+ICAgCXNwaW5f dW5sb2NrKCZzY2hlZC0+am9iX2xpc3RfbG9jayk7Cj4gICAKPiAgIAlkbWFfZmVuY2VfcHV0KCZz X2pvYi0+c19mZW5jZS0+ZmluaXNoZWQpOwo+IEBAIC0yMzYsMTYgKzIzMywyMSBAQCBzdGF0aWMg dm9pZCBkcm1fc2NoZWRfam9iX2JlZ2luKHN0cnVjdCBkcm1fc2NoZWRfam9iICpzX2pvYikKPiAg IAlpZiAoc2NoZWQtPnRpbWVvdXQgIT0gTUFYX1NDSEVEVUxFX1RJTUVPVVQgJiYKPiAgIAkgICAg bGlzdF9maXJzdF9lbnRyeV9vcl9udWxsKCZzY2hlZC0+cmluZ19taXJyb3JfbGlzdCwKPiAgIAkJ CQkgICAgIHN0cnVjdCBkcm1fc2NoZWRfam9iLCBub2RlKSA9PSBzX2pvYikKPiAtCQlzY2hlZHVs ZV9kZWxheWVkX3dvcmsoJnNfam9iLT53b3JrX3Rkciwgc2NoZWQtPnRpbWVvdXQpOwo+ICsJCXNj aGVkdWxlX2RlbGF5ZWRfd29yaygmc2NoZWQtPndvcmtfdGRyLCBzY2hlZC0+dGltZW91dCk7Cj4g ICAJc3Bpbl91bmxvY2soJnNjaGVkLT5qb2JfbGlzdF9sb2NrKTsKPiAgIH0KPiAgIAo+ICAgc3Rh dGljIHZvaWQgZHJtX3NjaGVkX2pvYl90aW1lZG91dChzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmsp Cj4gICB7Cj4gLQlzdHJ1Y3QgZHJtX3NjaGVkX2pvYiAqam9iID0gY29udGFpbmVyX29mKHdvcmss IHN0cnVjdCBkcm1fc2NoZWRfam9iLAo+IC0JCQkJCQkgd29ya190ZHIud29yayk7Cj4gKwlzdHJ1 Y3QgZHJtX2dwdV9zY2hlZHVsZXIgKnNjaGVkOwo+ICsJc3RydWN0IGRybV9zY2hlZF9qb2IgKmpv YjsKPiArCj4gKwlzY2hlZCA9IGNvbnRhaW5lcl9vZih3b3JrLCBzdHJ1Y3QgZHJtX2dwdV9zY2hl ZHVsZXIsIHdvcmtfdGRyLndvcmspOwo+ICsJam9iID0gbGlzdF9maXJzdF9lbnRyeV9vcl9udWxs KCZzY2hlZC0+cmluZ19taXJyb3JfbGlzdCwKPiArCQkJCSAgICAgICBzdHJ1Y3QgZHJtX3NjaGVk X2pvYiwgbm9kZSk7Cj4gICAKPiAtCWpvYi0+c2NoZWQtPm9wcy0+dGltZWRvdXRfam9iKGpvYik7 Cj4gKwlpZiAoam9iKQo+ICsJCWpvYi0+c2NoZWQtPm9wcy0+dGltZWRvdXRfam9iKGpvYik7Cj4g ICB9Cj4gICAKPiAgIC8qKgo+IEBAIC0zMTUsNyArMzE3LDcgQEAgdm9pZCBkcm1fc2NoZWRfam9i X3JlY292ZXJ5KHN0cnVjdCBkcm1fZ3B1X3NjaGVkdWxlciAqc2NoZWQpCj4gICAJc19qb2IgPSBs aXN0X2ZpcnN0X2VudHJ5X29yX251bGwoJnNjaGVkLT5yaW5nX21pcnJvcl9saXN0LAo+ICAgCQkJ CQkgc3RydWN0IGRybV9zY2hlZF9qb2IsIG5vZGUpOwo+ICAgCWlmIChzX2pvYiAmJiBzY2hlZC0+ dGltZW91dCAhPSBNQVhfU0NIRURVTEVfVElNRU9VVCkKPiAtCQlzY2hlZHVsZV9kZWxheWVkX3dv cmsoJnNfam9iLT53b3JrX3Rkciwgc2NoZWQtPnRpbWVvdXQpOwo+ICsJCXNjaGVkdWxlX2RlbGF5 ZWRfd29yaygmc2NoZWQtPndvcmtfdGRyLCBzY2hlZC0+dGltZW91dCk7Cj4gICAKPiAgIAlsaXN0 X2Zvcl9lYWNoX2VudHJ5X3NhZmUoc19qb2IsIHRtcCwgJnNjaGVkLT5yaW5nX21pcnJvcl9saXN0 LCBub2RlKSB7Cj4gICAJCXN0cnVjdCBkcm1fc2NoZWRfZmVuY2UgKnNfZmVuY2UgPSBzX2pvYi0+ c19mZW5jZTsKPiBAQCAtMzg0LDcgKzM4Niw2IEBAIGludCBkcm1fc2NoZWRfam9iX2luaXQoc3Ry dWN0IGRybV9zY2hlZF9qb2IgKmpvYiwKPiAgIAo+ICAgCUlOSVRfV09SSygmam9iLT5maW5pc2hf d29yaywgZHJtX3NjaGVkX2pvYl9maW5pc2gpOwo+ICAgCUlOSVRfTElTVF9IRUFEKCZqb2ItPm5v ZGUpOwo+IC0JSU5JVF9ERUxBWUVEX1dPUksoJmpvYi0+d29ya190ZHIsIGRybV9zY2hlZF9qb2Jf dGltZWRvdXQpOwo+ICAgCj4gICAJcmV0dXJuIDA7Cj4gICB9Cj4gQEAgLTU3NSw2ICs1NzYsNyBA QCBpbnQgZHJtX3NjaGVkX2luaXQoc3RydWN0IGRybV9ncHVfc2NoZWR1bGVyICpzY2hlZCwKPiAg IAlJTklUX0xJU1RfSEVBRCgmc2NoZWQtPnJpbmdfbWlycm9yX2xpc3QpOwo+ICAgCXNwaW5fbG9j a19pbml0KCZzY2hlZC0+am9iX2xpc3RfbG9jayk7Cj4gICAJYXRvbWljX3NldCgmc2NoZWQtPmh3 X3JxX2NvdW50LCAwKTsKPiArCUlOSVRfREVMQVlFRF9XT1JLKCZzY2hlZC0+d29ya190ZHIsIGRy bV9zY2hlZF9qb2JfdGltZWRvdXQpOwo+ICAgCWF0b21pY19zZXQoJnNjaGVkLT5udW1fam9icywg MCk7Cj4gICAJYXRvbWljNjRfc2V0KCZzY2hlZC0+am9iX2lkX2NvdW50LCAwKTsKPiAgIAo+IGRp ZmYgLS1naXQgYS9pbmNsdWRlL2RybS9ncHVfc2NoZWR1bGVyLmggYi9pbmNsdWRlL2RybS9ncHVf c2NoZWR1bGVyLmgKPiBpbmRleCBkYWVjNTBmODg3YjMuLmQ4N2IyNjhmMTc4MSAxMDA2NDQKPiAt LS0gYS9pbmNsdWRlL2RybS9ncHVfc2NoZWR1bGVyLmgKPiArKysgYi9pbmNsdWRlL2RybS9ncHVf c2NoZWR1bGVyLmgKPiBAQCAtMTc1LDggKzE3NSw2IEBAIHN0cnVjdCBkcm1fc2NoZWRfZmVuY2Ug KnRvX2RybV9zY2hlZF9mZW5jZShzdHJ1Y3QgZG1hX2ZlbmNlICpmKTsKPiAgICAqICAgICAgICAg ICAgICAgZmluaXNoZWQgdG8gcmVtb3ZlIHRoZSBqb2IgZnJvbSB0aGUKPiAgICAqICAgICAgICAg ICAgICAgQGRybV9ncHVfc2NoZWR1bGVyLnJpbmdfbWlycm9yX2xpc3QuCj4gICAgKiBAbm9kZTog dXNlZCB0byBhcHBlbmQgdGhpcyBzdHJ1Y3QgdG8gdGhlIEBkcm1fZ3B1X3NjaGVkdWxlci5yaW5n X21pcnJvcl9saXN0Lgo+IC0gKiBAd29ya190ZHI6IHNjaGVkdWxlcyBhIGRlbGF5ZWQgY2FsbCB0 byBAZHJtX3NjaGVkX2pvYl90aW1lZG91dCBhZnRlciB0aGUgdGltZW91dAo+IC0gKiAgICAgICAg ICAgIGludGVydmFsIGlzIG92ZXIuCj4gICAgKiBAaWQ6IGEgdW5pcXVlIGlkIGFzc2lnbmVkIHRv IGVhY2ggam9iIHNjaGVkdWxlZCBvbiB0aGUgc2NoZWR1bGVyLgo+ICAgICogQGthcm1hOiBpbmNy ZW1lbnQgb24gZXZlcnkgaGFuZyBjYXVzZWQgYnkgdGhpcyBqb2IuIElmIHRoaXMgZXhjZWVkcyB0 aGUgaGFuZwo+ICAgICogICAgICAgICBsaW1pdCBvZiB0aGUgc2NoZWR1bGVyIHRoZW4gdGhlIGpv YiBpcyBtYXJrZWQgZ3VpbHR5IGFuZCB3aWxsIG5vdAo+IEBAIC0xOTUsNyArMTkzLDYgQEAgc3Ry dWN0IGRybV9zY2hlZF9qb2Igewo+ICAgCXN0cnVjdCBkbWFfZmVuY2VfY2IJCWZpbmlzaF9jYjsK PiAgIAlzdHJ1Y3Qgd29ya19zdHJ1Y3QJCWZpbmlzaF93b3JrOwo+ICAgCXN0cnVjdCBsaXN0X2hl YWQJCW5vZGU7Cj4gLQlzdHJ1Y3QgZGVsYXllZF93b3JrCQl3b3JrX3RkcjsKPiAgIAl1aW50NjRf dAkJCWlkOwo+ICAgCWF0b21pY190CQkJa2FybWE7Cj4gICAJZW51bSBkcm1fc2NoZWRfcHJpb3Jp dHkJCXNfcHJpb3JpdHk7Cj4gQEAgLTI1OSw2ICsyNTYsOCBAQCBzdHJ1Y3QgZHJtX3NjaGVkX2Jh Y2tlbmRfb3BzIHsKPiAgICAqICAgICAgICAgICAgICAgICBmaW5pc2hlZC4KPiAgICAqIEBod19y cV9jb3VudDogdGhlIG51bWJlciBvZiBqb2JzIGN1cnJlbnRseSBpbiB0aGUgaGFyZHdhcmUgcXVl dWUuCj4gICAgKiBAam9iX2lkX2NvdW50OiB1c2VkIHRvIGFzc2lnbiB1bmlxdWUgaWQgdG8gdGhl IGVhY2ggam9iLgo+ICsgKiBAd29ya190ZHI6IHNjaGVkdWxlcyBhIGRlbGF5ZWQgY2FsbCB0byBA ZHJtX3NjaGVkX2pvYl90aW1lZG91dCBhZnRlciB0aGUKPiArICogICAgICAgICAgICB0aW1lb3V0 IGludGVydmFsIGlzIG92ZXIuCj4gICAgKiBAdGhyZWFkOiB0aGUga3RocmVhZCBvbiB3aGljaCB0 aGUgc2NoZWR1bGVyIHdoaWNoIHJ1bi4KPiAgICAqIEByaW5nX21pcnJvcl9saXN0OiB0aGUgbGlz dCBvZiBqb2JzIHdoaWNoIGFyZSBjdXJyZW50bHkgaW4gdGhlIGpvYiBxdWV1ZS4KPiAgICAqIEBq b2JfbGlzdF9sb2NrOiBsb2NrIHRvIHByb3RlY3QgdGhlIHJpbmdfbWlycm9yX2xpc3QuCj4gQEAg LTI3OCw2ICsyNzcsNyBAQCBzdHJ1Y3QgZHJtX2dwdV9zY2hlZHVsZXIgewo+ICAgCXdhaXRfcXVl dWVfaGVhZF90CQlqb2Jfc2NoZWR1bGVkOwo+ICAgCWF0b21pY190CQkJaHdfcnFfY291bnQ7Cj4g ICAJYXRvbWljNjRfdAkJCWpvYl9pZF9jb3VudDsKPiArCXN0cnVjdCBkZWxheWVkX3dvcmsJCXdv cmtfdGRyOwo+ICAgCXN0cnVjdCB0YXNrX3N0cnVjdAkJKnRocmVhZDsKPiAgIAlzdHJ1Y3QgbGlz dF9oZWFkCQlyaW5nX21pcnJvcl9saXN0Owo+ICAgCXNwaW5sb2NrX3QJCQlqb2JfbGlzdF9sb2Nr OwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==