dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	mripard@kernel.org, maarten.lankhorst@linux.intel.com,
	daniel@ffwll.ch, airlied@gmail.com
Cc: javierm@redhat.com, amd-gfx@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	laurent.pinchart@ideasonboard.com
Subject: Re: [6/8] drm/ofdrm: Do not include <drm/drm_plane_helper.h>
Date: Tue, 28 Nov 2023 20:01:13 +0800	[thread overview]
Message-ID: <c7713283-032c-4454-823b-d7de9bfd5d5b@linux.dev> (raw)
In-Reply-To: <20231128104723.20622-7-tzimmermann@suse.de>

Hi,


On 2023/11/28 18:45, Thomas Zimmermann wrote:
> Remove unnecessary include statements for <drm/drm_plane_helper.h>.
> The file contains helpers for non-atomic code and should not be
> required by most drivers. No functional changes.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>


Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn>


> ---
>   drivers/gpu/drm/tiny/ofdrm.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c
> index 05a72473cfc65..ab89b7fc7bf61 100644
> --- a/drivers/gpu/drm/tiny/ofdrm.c
> +++ b/drivers/gpu/drm/tiny/ofdrm.c
> @@ -19,7 +19,6 @@
>   #include <drm/drm_gem_shmem_helper.h>
>   #include <drm/drm_managed.h>
>   #include <drm/drm_modeset_helper_vtables.h>
> -#include <drm/drm_plane_helper.h>
>   #include <drm/drm_probe_helper.h>
>   #include <drm/drm_simple_kms_helper.h>
>   

  reply	other threads:[~2023-11-28 12:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 10:45 [PATCH 0/8] drm/plane-helpers: Minor clean ups Thomas Zimmermann
2023-11-28 10:45 ` [PATCH 1/8] drm/plane-helper: Move drm_plane_helper_atomic_check() into udl Thomas Zimmermann
2023-12-01  2:36   ` [1/8] " Sui Jingfeng
2023-12-01  8:22     ` Thomas Zimmermann
2023-12-01 13:57       ` Sui Jingfeng
2023-11-28 10:45 ` [PATCH 2/8] drm/amdgpu: Do not include <drm/drm_plane_helper.h> Thomas Zimmermann
2023-11-28 10:45 ` [PATCH 3/8] drm/loongson: " Thomas Zimmermann
2023-11-28 11:37   ` [3/8] " Sui Jingfeng
2023-11-28 10:45 ` [PATCH 4/8] drm/shmobile: " Thomas Zimmermann
2023-11-28 13:16   ` Geert Uytterhoeven
2023-11-28 10:45 ` [PATCH 5/8] drm/solomon: " Thomas Zimmermann
2023-11-28 13:16   ` Geert Uytterhoeven
2023-12-01  8:42   ` Javier Martinez Canillas
2023-11-28 10:45 ` [PATCH 6/8] drm/ofdrm: " Thomas Zimmermann
2023-11-28 12:01   ` Sui Jingfeng [this message]
2023-11-28 10:45 ` [PATCH 7/8] drm/simpledrm: " Thomas Zimmermann
2023-11-28 11:47   ` [7/8] " Sui Jingfeng
2023-11-28 10:45 ` [PATCH 8/8] drm/xlnx: " Thomas Zimmermann
2023-11-28 11:02   ` Laurent Pinchart
2023-11-28 14:13     ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7713283-032c-4454-823b-d7de9bfd5d5b@linux.dev \
    --to=sui.jingfeng@linux.dev \
    --cc=airlied@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox