From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Ojha Subject: Re: [PATCH v2] drm: rcar-du: fix possible object reference leak Date: Mon, 8 Apr 2019 14:15:54 +0530 Message-ID: References: <1554692313-28882-1-git-send-email-wen.yang99@zte.com.cn> <1554692313-28882-3-git-send-email-wen.yang99@zte.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1554692313-28882-3-git-send-email-wen.yang99@zte.com.cn> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Wen Yang , linux-kernel@vger.kernel.org Cc: wang.yi59@zte.com.cn, Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On 4/8/2019 8:28 AM, Wen Yang wrote: > The call to of_get_parent returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > drivers/gpu/drm/rcar-du/rcar_du_of.c:235:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 216, but without a corresponding object release within this function. > drivers/gpu/drm/rcar-du/rcar_du_of.c:236:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 209, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang > Suggested-by: Laurent Pinchart > Cc: Laurent Pinchart > Cc: Kieran Bingham > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org (open list) > --- > v2->v1: turn the return into a goto done. > > drivers/gpu/drm/rcar-du/rcar_du_of.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_of.c b/drivers/gpu/drm/rcar-du/rcar_du_of.c > index afef696..782bfc7 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_of.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_of.c > @@ -232,7 +232,7 @@ static void __init rcar_du_of_lvds_patch(const struct of_device_id *of_ids) > lvds_node = of_find_compatible_node(NULL, NULL, compatible); > if (lvds_node) { > of_node_put(lvds_node); > - return; > + goto done; > } > you might have to create multiple level to do handling it.. there are unnecessary put being done on "done" which is not valid for this case. -Mukesh > /*