dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	dri-devel@lists.freedesktop.org,
	Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH v2 6/7] drm/msm/dpu: drop temp variable from dpu_encoder_phys_cmd_init()
Date: Mon, 22 May 2023 15:38:02 -0700	[thread overview]
Message-ID: <c7c032b7-082a-cb38-3ba3-e5de0143ea38@quicinc.com> (raw)
In-Reply-To: <20230519023855.3840907-7-dmitry.baryshkov@linaro.org>



On 5/18/2023 7:38 PM, Dmitry Baryshkov wrote:
> There is no need to assign a result to temp varable just to return it
> two lines below. Drop the temporary variable.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>

  reply	other threads:[~2023-05-22 22:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19  2:38 [PATCH v2 0/7] drm/msm/dpu: simplify DPU encoder init Dmitry Baryshkov
2023-05-19  2:38 ` [PATCH v2 1/7] drm/msm/dpu: merge dpu_encoder_init() and dpu_encoder_setup() Dmitry Baryshkov
2023-05-19  2:38 ` [PATCH v2 2/7] drm/msm/dpu: separate common function to init physical encoder Dmitry Baryshkov
2023-05-22 22:34   ` Abhinav Kumar
2023-05-19  2:38 ` [PATCH v2 3/7] drm/msm/dpu: drop duplicated intf/wb indices from encoder structs Dmitry Baryshkov
2023-05-19  2:38 ` [PATCH v2 4/7] drm/msm/dpu: inline dpu_encoder_get_wb() Dmitry Baryshkov
2023-05-19  2:38 ` [PATCH v2 5/7] drm/msm/dpu: call dpu_rm_get_intf() from dpu_encoder_get_intf() Dmitry Baryshkov
2023-05-19  2:38 ` [PATCH v2 6/7] drm/msm/dpu: drop temp variable from dpu_encoder_phys_cmd_init() Dmitry Baryshkov
2023-05-22 22:38   ` Abhinav Kumar [this message]
2023-05-19  2:38 ` [PATCH v2 7/7] drm/msm/dpu: simplify dpu_encoder_phys_wb_init() Dmitry Baryshkov
2023-05-23  1:56   ` Abhinav Kumar
2023-05-23  1:58 ` [Freedreno] [PATCH v2 0/7] drm/msm/dpu: simplify DPU encoder init Abhinav Kumar
2023-05-23  7:20   ` Dmitry Baryshkov
2023-05-23  7:31     ` Neil Armstrong
2023-05-23 14:36       ` Dmitry Baryshkov
2023-05-23 19:13         ` Abhinav Kumar
2023-05-23 19:23           ` Dmitry Baryshkov
2023-05-23 19:30             ` Abhinav Kumar
2023-05-30 23:51               ` Abhinav Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7c032b7-082a-cb38-3ba3-e5de0143ea38@quicinc.com \
    --to=quic_abhinavk@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox