From: Javier Martinez Canillas <javierm@redhat.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: jfalempe@redhat.com, Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 2/2] drm/atomic-helper: Replace drm_atomic_helper_check_crtc_state()
Date: Fri, 7 Oct 2022 09:41:33 +0200 [thread overview]
Message-ID: <c8288c68-2948-7399-594d-7a95995f652c@redhat.com> (raw)
In-Reply-To: <Yz/VZqQN33gvk1Ab@intel.com>
On 10/7/22 09:29, Ville Syrjälä wrote:
[...]
>> drm_for_each_plane_mask(plane, dev, crtc_state->plane_mask)
>> if (plane->type == DRM_PLANE_TYPE_PRIMARY)
>> return 0;
>
> That is exactly what it says not to do.
>
Ah, good to know. I re-read the kernel coding style and see now
that it only applies to single simple statements.
Better then, since not using braces even for single statements
is something that's error prone IMO, as mentioned before.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2022-10-07 7:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 11:40 [PATCH v4 0/2] drm/atomic-helpers: Fix CRTC primary-plane test Thomas Zimmermann
2022-10-05 11:40 ` [PATCH v4 1/2] drm/atomic-helper: Don't allocated plane state in CRTC check Thomas Zimmermann
2022-10-06 20:18 ` Javier Martinez Canillas
2022-10-07 6:55 ` Thomas Zimmermann
2022-10-05 11:40 ` [PATCH v4 2/2] drm/atomic-helper: Replace drm_atomic_helper_check_crtc_state() Thomas Zimmermann
2022-10-06 20:28 ` Javier Martinez Canillas
2022-10-07 7:07 ` Ville Syrjälä
2022-10-07 7:17 ` Javier Martinez Canillas
2022-10-07 7:29 ` Ville Syrjälä
2022-10-07 7:41 ` Javier Martinez Canillas [this message]
2022-10-07 8:06 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8288c68-2948-7399-594d-7a95995f652c@redhat.com \
--to=javierm@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jfalempe@redhat.com \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox