From mboxrd@z Thu Jan 1 00:00:00 1970 From: Woody Suwalski Subject: [PATCH] 4.15 vmgfx boot warning Date: Wed, 22 Nov 2017 16:05:50 -0500 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: Sender: linux-kernel-owner@vger.kernel.org To: Sinclair Yeh Cc: DRI mailing list , LKML , Dave Airlie List-Id: dri-devel@lists.freedesktop.org The 4.15 vmwgfx driver shows a warning during boot (32 bit x86) It is caused by a mismatch between the result of vmw_enable_vblank() and what the drm_atomic_helper expects:    /...    ret = drm_crtc_vblank_get(crtc);    WARN_ONCE(ret != -EINVAL, "driver forgot to call drm_crtc_vblank_off()\n");    /... Signed-off by: Woody Suwalski --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c    2017-11-22 15:29:46.511674079 -0500 +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c    2017-11-22 15:30:35.344559592 -0500 @@ -1869,7 +1869,7 @@ u32 vmw_get_vblank_counter(struct drm_de   */  int vmw_enable_vblank(struct drm_device *dev, unsigned int pipe)  { -    return -ENOSYS; +    return -EINVAL;  }  /**