From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3523DC43458 for ; Tue, 7 Jul 2026 15:25:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D94710E4E6; Tue, 7 Jul 2026 15:25:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=dmitry.osipenko@collabora.com header.b="DkOxlCn4"; dkim-atps=neutral Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id D2EED8930B for ; Tue, 7 Jul 2026 15:25:17 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1783437909; cv=none; d=zohomail.com; s=zohoarc; b=M2BE90D7Q/L3A4yNLBItSkb+g47e1dmiTtt4eOPkIcO/mjaTGeAKe2+IUw6UrkyM5ft2RBqGdmgOmpeWbDaPUVy5kbvL78Htx4X0/oXG+VedKdZR6TrjeLHe/T/GxNtkp4nre8mMD76V3vnZYifX5556MiyiXT8HS9VvKMGvguw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783437909; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=zsHfKDPWHHLaAMDNdNvYd4BAM5Dx0wlAKrG3pw9LTG0=; b=nbLqYLs6GjcFTxT2h5y8SC4li4YxnDVblhWEs2r02O+GdC5nCDvfOeMGa+2Tta1SRUlJ+c5zUUS2+bqMcrZ0lrNXdvaJBG1+8KkVyHgEwAQGQ4gI+rgRpShNZR44RsUmUVq4et3M5lq6kLAuw9bJIlnW5WOwq477+zHzXP/5RbY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1783437909; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=zsHfKDPWHHLaAMDNdNvYd4BAM5Dx0wlAKrG3pw9LTG0=; b=DkOxlCn4VtNQNoD/cFYQdmPW6dIUPLyDRxxolFLF0hcsCU6l14Q+U5q13KvMRvZH IoRtHzSV+uG5/cqUWq1/XwTLJGsTT1rRt3XS+p9ztzB+/O75H42/TyUi15TkR+Cv2cq aaMrqJ56XZvo20V+HxL9vgMoIdGRV9zKbbcV+ek4= Received: by mx.zohomail.com with SMTPS id 17834379067971023.5993710227946; Tue, 7 Jul 2026 08:25:06 -0700 (PDT) Message-ID: Date: Tue, 7 Jul 2026 18:25:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] drm/virtio: honor blob_alignment requirements To: Alyssa Ross , Sergio Lopez , Yiwei Zhang , Sergi Blanch Torne , Valentine Burley Cc: Chia-I Wu , Jason Wang , "Michael S. Tsirkin" , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Xuan Zhuo , linux-kernel@vger.kernel.org, Simona Vetter , Thomas Zimmermann , David Airlie , Gurchetan Singh , Gerd Hoffmann , virtualization@lists.linux.dev, dri-devel@lists.freedesktop.org, Maxime Ripard , Maarten Lankhorst References: <20260428194450.518296-1-slp@redhat.com> <20260428194450.518296-3-slp@redhat.com> Content-Language: en-US From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 7/1/26 14:10, Alyssa Ross wrote: > On Tue, Apr 28, 2026 at 09:44:49PM +0200, Sergio Lopez wrote: >> If VIRTIO_GPU_F_BLOB_ALIGNMENT has been negotiated, blob size must be >> aligned to blob_alignment. Validate this in verify_blob() so that >> invalid requests are rejected early. >> >> Signed-off-by: Sergio Lopez > > FYI: this change breaks crosvm, which is squatting the 5 and 6 values > of VIRTIO_GPU_F_* with different meanings. I've reported it as a > crosvm bug, so hopefully it can be taken care of there. > > https://issuetracker.google.com/issues/529852979 > >> --- >> drivers/gpu/drm/virtio/virtgpu_ioctl.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c >> index c33c057365f8..d0c4edf1eaf4 100644 >> --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c >> +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c >> @@ -489,6 +489,11 @@ static int verify_blob(struct virtio_gpu_device *vgdev, >> params->size = rc_blob->size; >> params->blob = true; >> params->blob_flags = rc_blob->blob_flags; >> + >> + if (vgdev->has_blob_alignment && >> + !IS_ALIGNED(params->size, vgdev->blob_alignment)) >> + return -EINVAL; >> + >> return 0; >> } >> >> -- >> 2.53.0 >> Thanks for the report. Indeed, crosvm will need to fix its experimental caps. CI will likely run into this problem first once it will update guest to 7.2+ kernel. -- Best regards, Dmitry