From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9AABCD4F3D for ; Thu, 21 May 2026 06:44:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1C2410F057; Thu, 21 May 2026 06:44:53 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="F7ivPtzh"; dkim-atps=neutral Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D05610F1F0 for ; Thu, 21 May 2026 05:41:39 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-8383fb7143aso2571374b3a.3 for ; Wed, 20 May 2026 22:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779342099; x=1779946899; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cisA9bq/yMmHLQ79HWa2QEhS3fIz6CIk937mHCPD/uI=; b=F7ivPtzhlgviEW5oHiJ3ZYZzigcTpjgXnZtbo9IIgMNW1+cTaebtVWZRVGZKG5YJXe 2ZXx282mYt34WRnA3I8imu0vyqaUvwx4UWOuKxhoyiS0gfjXSfblOtMOPRFGUcT+dUVZ umEHObtE3/YP6J3v3YycU2FGDpiv0haU1kbZ5Ar+f9CiYvKLNywKn2svCXuCELK+1PKo Fm0UvC7uZnepk54s8KOCcbfyL9g+PSGBgj98QPJFGXCwVsrmixxjkPj9KzxtKdfcso+F mU46T3jBlyzpsVXJ1iOIBI+t5gH7PjHyWVrfhvYVJYsoI6qxUSpKEnJboE+9a1DN/CmD pfkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779342099; x=1779946899; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cisA9bq/yMmHLQ79HWa2QEhS3fIz6CIk937mHCPD/uI=; b=okY3bXP31qvFgrGMsv1ujxP8+fBUjihAK6VBFGyV7AXkvK85dLcLaSdvsCdgIRFoB4 chsIHQpzut55Yf3R67Tc44Bfi8yB7Q5I3fex4GOleF95JQLGqkJyrJ38KdmrVSm/nCu1 9GmJ6jpYL/nftEMClZ6x+/Qjx1TS+GOG0yax99aRO/wGic6J5Zl3oyYB5ROHauY/aZ60 3L+gBdZFtwwLj2eIdvqHkofG0jAowQOwS7qnZrgko4tKeMYlsodVD2h4p/G+jdRnbAw6 TwjgN/z5ql6yurhAopOGF1dfFuEXbfwTpBc73Ie4QY/hos+oygcwuGz30FqXlxa/NVzG baoQ== X-Forwarded-Encrypted: i=1; AFNElJ+fY58pCgohQyHuqkpfUJrgknLWpmkFJFg9B3h5B2XfJInjgChATkSZeLehKNtT+Iql732k30C36GQ=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yydfz+QKILV+inV1DGMM+Z+nF/bVJTgTIl6w7zHFztAKfrQ7ht9 Mg/r1jexr4VB/7MlF1ORYW961MMuf6gBfH2YlV93/BFwjjpkLDqvmFV4 X-Gm-Gg: Acq92OH8me8kO1+qH12sNwnXQwnQ7jZAFnuYBaHVCh98g3Y47E9v6xOj2ad6xoyVptf XBnpsg+DzQc5bbxyl1BO5DPx1kYxmmO5B9pSHMCXMjrgV5GO5qg+rBHn6i98oCg+Mkv8PQt1g5o 3BmT7hSDlPxJBKjZuAPMJCS0SBMyeXjWs7MiItR2BSOqXMWJ2EFWn02ShPa2Lec3LkycfSGXkxq Angj9HHtd7kOYwBbOMMR/YfiBktLSB1eXRnFvYLpqUe0tgZWsiv9l4orTO6e3twLb2GqazdJ8Wl qTaO1u0VkmMupKs7VBpNAWjBlfhxqq5L5nR+sBUzxWh7wIzqZtla70qWlg2kM7jw232kIo6qANH B1SnB4+14EahIF7TOUMpZWiB7z/Hv4TmGoX3p89JDE0dmX4mB/oje5b1l6a7Z/At7NhcRl1HzDM BO+2q0pkpVWCX+E4fW+iRpgrUAj2HWWrkFcZJ0mRymX53bNv7rkX4htPn9AC52ck/I9WS2/2uEC +bE X-Received: by 2002:a05:6a00:10d2:b0:838:a932:de26 with SMTP id d2e1a72fcca58-8414ac7b2cemr1502998b3a.1.1779342098580; Wed, 20 May 2026 22:41:38 -0700 (PDT) Received: from [192.168.0.100] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19f7cd19sm23019794b3a.54.2026.05.20.22.41.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 22:41:37 -0700 (PDT) Message-ID: Date: Thu, 21 May 2026 13:41:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] dt-bindings: display: verisilicon, dc: generalize for single-output variants To: Icenowy Zheng , Conor Dooley Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260519055114.1886525-1-a0987203069@gmail.com> <20260519055114.1886525-2-a0987203069@gmail.com> <20260519-fretful-blush-1aac18fa1360@spud> <47a06094541da642cabcb6b7d2f92d5125d365ea.camel@iscas.ac.cn> Content-Language: en-US From: Joey Lu In-Reply-To: <47a06094541da642cabcb6b7d2f92d5125d365ea.camel@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Thu, 21 May 2026 06:44:53 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 5/20/2026 12:07 PM, Icenowy Zheng wrote: > 在 2026-05-20三的 11:06 +0800，Joey Lu写道： >> On 5/20/2026 12:47 AM, Conor Dooley wrote: >>> On Tue, May 19, 2026 at 03:26:58PM +0800, Icenowy Zheng wrote: >>>> 在 2026-05-19二的 13:51 +0800，Joey Lu写道： >>>>> The existing schema assumes a fixed clock/reset topology and >>>>> dual- >>>>> output >>>>> port structure matching the DC8200 IP block.  This prevents >>>>> reuse for >>>>> single-output variants such as the Verisilicon DCU Lite used in >>>>> the >>>>> Nuvoton MA35D1 SoC. >>>>> >>>>> Rework the schema so that variant-specific constraints are >>>>> expressed >>>>> via allOf/if-then-else: >>>>> >>>>> - The thead,th1520-dc8200 compatible keeps its existing five- >>>>> clock, >>>>>    three-reset, dual-port requirements. >>>>> >>>>> - A standalone verisilicon,dc compatible covers IPs whose >>>>> identity is >>>>>    discovered entirely through hardware registers; these have >>>>> flexible >>>>>    clock and reset counts, a single 'port' property, and no >>>>> 'ports' >>>>>    requirement. >>>>> >>>>> Changes to the base schema: >>>>> - Replace the fixed clock/reset items lists with >>>>> minItems/maxItems >>>>>    ranges; variant sub-schemas tighten the constraints via if- >>>>> then- >>>>> else. >>>>> - Add a 'port' property (graph.yaml single-port alias) >>>>> alongside the >>>>>    existing 'ports', for single-output variants. >>>>> - Drop the unconditional 'ports' requirement; each if-branch >>>>> enforces >>>>>    its own port topology. >>>>> - Tighten additionalProperties to unevaluatedProperties to >>>>> allow >>>>>    per-variant schemas to add their own constraints cleanly. >>>>> - Fix a stray space in the port@0 description. >>>>> - Add a DT example for the generic verisilicon,dc compatible >>>>>    (Nuvoton MA35D1 DCU Lite). >>>>> >>>>> Signed-off-by: Joey Lu >>>>> --- >>>>>   .../bindings/display/verisilicon,dc.yaml      | 135 >>>>> ++++++++++++++-- >>>>> -- >>>>>   1 file changed, 108 insertions(+), 27 deletions(-) >>>>> >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml >>>>> b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml >>>>> index 9dc35ab973f2..3a814c2e083e 100644 >>>>> --- >>>>> a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml >>>>> +++ >>>>> b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml >>>>> @@ -14,10 +14,12 @@ properties: >>>>>       pattern: "^display@[0-9a-f]+$" >>>>> >>>>>     compatible: >>>>> -    items: >>>>> -      - enum: >>>>> -          - thead,th1520-dc8200 >>>> You should add a fallback compatible here for your SoC, in case >>>> its >>>> integration gets something quirky; this compatible is usually not >>>> consumed by the driver (see how thead,th1520-dc8200 exists in the >>>> binding but not the driver). >>> s/fallback compatible/soc-specific compatible/, but yes. >>> NAK to what's been done here, especially after the discussions on >>> earlier versions of this verisilicon binding. >>> pw-bot: changes-requested >> Understood. I will add `nuvoton,ma35d1-dcu` as the SoC-specific >> compatible string paired with `verisilicon,dc` as the generic >> fallback, >> matching the pattern used for `thead,th1520-dc8200`. The standalone >> `verisilicon,dc` compatible will be removed from the binding. The >> driver > No, please don't remove compatible strings from existing binding, and > the generic compatible is still used for driver binding. > > The SoC-specific compatible is informative here, it needs to exist, but > it doesn't supersede "verisilicon,dc" . > > In addition, the SoC-specific compatible is also used for verification > of the SoC device tree, which is the reason if clauses exist with > compatible match and additional constraints (e.g. for the nuvoton DCU > it's invalid to have a 2nd output port). Sorry for the misunderstanding. I now see that a standalone generic fallback compatible is not preferred here, and that the SoC-specific compatible is strictly required for DT validation. I will add `nuvoton,ma35d1-dcu` as the SoC-specific compatible string in the existing compatible items list, without adding or removing anything else. >> match table is not changed since hardware detection is done via ID >> registers. >>>>> -      - const: verisilicon,dc # DC IPs have discoverable >>>>> ID/revision >>>>> registers >>>>> +    oneOf: >>>>> +      - items: >>>>> +          - enum: >>>>> +              - thead,th1520-dc8200 >>>>> +          - const: verisilicon,dc >>>>> +      - const: verisilicon,dc  # DC IPs have discoverable >>>>> ID/revision registers >>>>> >>>>>     reg: >>>>>       maxItems: 1 >>>>> @@ -26,32 +28,24 @@ properties: >>>>>       maxItems: 1 >>>>> >>>>>     clocks: >>>>> -    items: >>>>> -      - description: DC Core clock >>>>> -      - description: DMA AXI bus clock >>>>> -      - description: Configuration AHB bus clock >>>>> -      - description: Pixel clock of output 0 >>>>> -      - description: Pixel clock of output 1 >>>>> +    minItems: 2 >>>>> +    maxItems: 5 >>>>> >>>>>     clock-names: >>>>> -    items: >>>>> -      - const: core >>>>> -      - const: axi >>>>> -      - const: ahb >>>>> -      - const: pix0 >>>>> -      - const: pix1 >>>>> +    minItems: 2 >>>>> +    maxItems: 5 >>>>> >>>>>     resets: >>>>> -    items: >>>>> -      - description: DC Core reset >>>>> -      - description: DMA AXI bus reset >>>>> -      - description: Configuration AHB bus reset >>>>> +    minItems: 1 >>>>> +    maxItems: 3 >>>>> >>>>>     reset-names: >>>>> -    items: >>>>> -      - const: core >>>>> -      - const: axi >>>>> -      - const: ahb >>>>> +    minItems: 1 >>>>> +    maxItems: 3 >>>>> + >>>>> +  port: >>>>> +    $ref: /schemas/graph.yaml#/properties/port >>>>> +    description: Single video output port for single-output >>>>> variants. >>>> Maybe the endpoint numbering rule needs a move to here? (I am not >>>> very >>>> sure). >> I will add a description to the `port` property noting that endpoint >> 0 >> is used for DPI output, which is the only output type for >> DCUltraLite. > Please note that DC8000 exists, which is single-port but supports both > DPI and DP. To make it simple, the `port` property will not be added. `ports` remains the sole port property and is kept in the global `required:` list as in the original. The MA35D1 example will use `ports { port@0 { ... } }`, consistent with how other single-output DT nodes are written in the kernel. >>>>> >>>>>     ports: >>>>>       $ref: /schemas/graph.yaml#/properties/ports >>>>> @@ -59,7 +53,7 @@ properties: >>>>>       properties: >>>>>         port@0: >>>>>           $ref: /schemas/graph.yaml#/properties/port >>>>> -        description: The first output channel , endpoint 0 >>>>> should be >>>>> +        description: The first output channel, endpoint 0 >>>>> should be >>>>>             used for DPI format output and endpoint 1 should be >>>>> used >>>>>             for DP format output. >>>>> >>>>> @@ -75,9 +69,75 @@ required: >>>>>     - interrupts >>>>>     - clocks >>>>>     - clock-names >>>>> -  - ports >>>>> >>>>> -additionalProperties: false >>>>> +allOf: >>>>> +  - if: >>>>> +      properties: >>>>> +        compatible: >>>>> +          contains: >>>>> +            const: thead,th1520-dc8200 >>>>> +    then: >>>>> +      properties: >>>>> +        clocks: >>>>> +          items: >>>>> +            - description: DC Core clock >>>>> +            - description: DMA AXI bus clock >>>>> +            - description: Configuration AHB bus clock >>>>> +            - description: Pixel clock of output 0 >>>>> +            - description: Pixel clock of output 1 >>>>> + >>>>> +        clock-names: >>>>> +          items: >>>>> +            - const: core >>>>> +            - const: axi >>>>> +            - const: ahb >>>>> +            - const: pix0 >>>>> +            - const: pix1 >>>>> + >>>>> +        resets: >>>>> +          items: >>>>> +            - description: DC Core reset >>>>> +            - description: DMA AXI bus reset >>>>> +            - description: Configuration AHB bus reset >>>>> + >>>>> +        reset-names: >>>>> +          items: >>>>> +            - const: core >>>>> +            - const: axi >>>>> +            - const: ahb >>>>> + >>>>> +      required: >>>>> +        - ports >>>>> + >>>>> +    else: >>>>> +      properties: >>>>> +        clocks: >>>>> +          items: >>>>> +            - description: Bus clock that gates register >>>>> access >>>>> +            - description: Pixel clock divider for display >>>>> timing >>>> Please don't make compatible-specific description strings for >>>> individual compatibles, and keep these descriptions outside of >>>> the if. >>>> The compatible-specific part should be used to specify what's >>>> required >>>> for the specific SoC, for dt validation purpose. >>>> >>>> BTW if the clock is both the working clock and bus clock for the >>>> controller, I suggest listing it twice, except if the IP core is >>>> provided without a dedicated core clock (in the case I suggest to >>>> use >>>> "bus" only). >>> I agree. If the same clock is provided to two+ ports on the IP, >>> that >>> should still be two+ clocks in the devicetree. >>> >>>> Here's an example for "listing it twice": >>>> ``` >>>> clocks = <&clk DCU_GATE>, <&clk DCU_GATE>, <&clk DCUP_DIV>; >>>> clock-names = "core", "bus", "pix0"; >>>> ``` >>>> >>>> Well nonetheless the name "core" does not match the description >>>> "Bus >>>> clock that gates register access". >>>> >>>> Thanks, >>>> Icenowy >> Understood. I will remove all description strings from the if/else >> branches; the if/then clauses will only constrain clock-names and >> reset-names items (name values only, no descriptions). Regarding >> clock > Well I think a required properties list is also needed in the if/then > clause, to prevent DT's from lacking properties. Since `ports` is kept in the global `required:` list, neither if/then block needs a `required:` entry for port topology. Each if/then only constrains clock-names and reset-names for DT validation. The `else` branch has been eliminated; each variant has its own independent `if/then` in the `allOf` array. >> naming: DCU_GATE on MA35D1 is a peripheral gate clock without a >> separate >> dedicated core working clock, so I will keep "core" as the name and > Do you mean there's no seperate dedicated bus clock? I find that in the > clock driver dcu_gate has no parent as bus clocks -- its parent is > dcu_mux, and dcu_mux's 2 parents are both pll ("epll_div2" and > "syspll"). > > Thanks, > Icenowy You are right — DCU_GATE has no parent as a bus clock. For this case, I prefer to keep "core" as the sole gate clock name alongside "pix0". Thanks. Here is what the v3 yaml would look like: ```yaml compatible:   items:     - enum: [nuvoton,ma35d1-dcu, thead,th1520-dc8200]     - const: verisilicon,dc properties:   clocks: minItems: 2, items with descriptions   resets: minItems: 1, items with descriptions required:   [compatible, reg, interrupts, clocks, clock-names, ports] allOf:   - if: compatible contains thead,th1520-dc8200     then:       clock-names: [core, axi, ahb, pix0, pix1]       reset-names: [core, axi, ahb]   - if: compatible contains nuvoton,ma35d1-dcu     then:       clock-names: [core, pix0]       reset-names: [core] ``` >> drop >> the misleading description "Bus clock that gates register access". >> The >> description mismatch was entirely in the if/else strings which are >> now >> removed. >> >> Thanks. >> >>>>> + >>>>> +        clock-names: >>>>> +          items: >>>>> +            - const: core >>>>> +            - const: pix0 >>>>> + >>>>> +        resets: >>>>> +          maxItems: 1 >>>>> +          description: >>>>> +            Reset line for the display controller. >>>>> + >>>>> +        reset-names: >>>>> +          items: >>>>> +            - const: core >>>>> + >>>>> +      required: >>>>> +        - port >>>>> + >>>>> +      not: >>>>> +        required: >>>>> +          - ports >>>>> + >>>>> +unevaluatedProperties: false >>>>> >>>>>   examples: >>>>>     - | >>>>> @@ -120,3 +180,24 @@ examples: >>>>>           }; >>>>>         }; >>>>>       }; >>>>> + >>>>> +  - | >>>>> +    #include >>>>> +    #include >>>>> +    #include >>>>> + >>>>> +    display@40260000 { >>>>> +        compatible = "verisilicon,dc"; >>>>> +        reg = <0x40260000 0x20000>; >>>>> +        interrupts = ; >>>>> +        clocks = <&clk DCU_GATE>, <&clk DCUP_DIV>; >>>>> +        clock-names = "core", "pix0"; >>>>> +        resets = <&sys MA35D1_RESET_DISP>; >>>>> +        reset-names = "core"; >>>>> + >>>>> +        port { >>>>> +            dpi_out: endpoint { >>>>> +                remote-endpoint = <&panel_in>; >>>>> +            }; >>>>> +        }; >>>>> +    };