dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: "Mikhail Gavrilov" <mikhail.v.gavrilov@gmail.com>,
	"Christian König" <christian.koenig@amd.com>
Cc: "Deucher, Alexander" <alexander.deucher@amd.com>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [6.1][regression] after commit dd80d9c8eecac8c516da5b240d01a35660ba6cb6 some games (Cyberpunk 2077, Forza Horizon 4/5) hang at start
Date: Tue, 1 Nov 2022 18:52:43 +0100	[thread overview]
Message-ID: <ca6c98eb-fdb0-5fee-3925-5b697e3e6b50@gmail.com> (raw)
In-Reply-To: <CABXGCsMCfACsJRDPqZDYQGMpaA_6LKhQ0XqAmDN04GSMeetXnA@mail.gmail.com>

Hi Mikhail,

Am 30.10.22 um 23:05 schrieb Mikhail Gavrilov:
> On Wed, Oct 26, 2022 at 12:29 PM Christian König
> <christian.koenig@amd.com> wrote:
>> Attached is the original test patch rebased on current amd-staging-drm-next.
>>
>> Can you test if this is enough to make sure that the games start without
>> crashing by fetching the userptrs?
> 1. Over the past week the list of games affected by this issue updated
> with new games: The Outlast Trials, Gotham Knights, Sackboy: A Big
> Adventure.
>
> 2. I tested the patch and it really solves the problem with the launch
> of all the listed games and does not create new problems.
>
> 3. The only thing I noticed is that in the game Sackboy: A Big
> Adventure, when using the kernel built from the commit
> b229b6ca5abbd63ff40c1396095b1b36b18139c3 + the attached patch, I can’t
> connect to friend coop session due to the steam client hangs. The
> kernel built from commit 736ec9fadd7a1fde8480df7e5cfac465c07ff6f3
> (this is the commit prior to dd80d9c8eecac8c516da5b240d01a35660ba6cb6)
> free of this problem.
>
> I need to spend some more time to find the commit after which leads to
> hanging [3] the steam client.

Let's focus on one problem at a time.

The issue here is that somehow userptr handling became racy after we 
removed the lock, but I don't see why.

We need to fix this ASAP since it is probably a much wider problem and 
the additional lock just hides it somehow.

Going to provide you with an updated patch tomorrow.

Thanks,
Christian.

>
> Thanks.
>


  reply	other threads:[~2022-11-01 17:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21  8:08 [6.1][regression] after commit dd80d9c8eecac8c516da5b240d01a35660ba6cb6 some games (Cyberpunk 2077, Forza Horizon 4/5) hang at start Mikhail Gavrilov
2022-10-21  8:32 ` Christian König
2022-10-21 12:36   ` Mikhail Gavrilov
2022-10-26  7:29     ` Christian König
2022-10-30 22:05       ` Mikhail Gavrilov
2022-11-01 17:52         ` Christian König [this message]
2022-11-02 13:36           ` Mikhail Gavrilov
2022-11-02 13:43             ` Christian König
2022-11-14  9:43               ` Thorsten Leemhuis
2022-11-14 13:22               ` Christian König
2022-11-20 17:25                 ` [6.1][regression] after commit dd80d9c8eecac8c516da5b240d01a35660ba6cb6 some games (Cyberpunk 2077, Forza Horizon 4/5) hang at start #forregzbot Thorsten Leemhuis
2022-11-27 10:56                   ` Thorsten Leemhuis
2022-11-21 23:42                 ` [6.1][regression] after commit dd80d9c8eecac8c516da5b240d01a35660ba6cb6 some games (Cyberpunk 2077, Forza Horizon 4/5) hang at start Mikhail Gavrilov
2022-11-22  7:16                   ` Christian König
2022-11-28 23:16                     ` Mikhail Gavrilov
2022-10-23 13:20 ` [6.1][regression] after commit dd80d9c8eecac8c516da5b240d01a35660ba6cb6 some games (Cyberpunk 2077, Forza Horizon 4/5) hang at start #forregzbot Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca6c98eb-fdb0-5fee-3925-5b697e3e6b50@gmail.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mikhail.v.gavrilov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox