From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Agner Subject: Re: [PATCH v2 5/6] drm/tinydrm: Use drm_mode_config_helper_suspend/resume() Date: Tue, 14 Nov 2017 16:40:29 +0100 Message-ID: References: <20171106191812.38927-1-noralf@tronnes.org> <20171106191812.38927-6-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kmu-office.ch (mail.kmu-office.ch [IPv6:2a02:418:6a02::a2]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4EB36E122 for ; Tue, 14 Nov 2017 15:44:50 +0000 (UTC) In-Reply-To: <20171106191812.38927-6-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Cc: daniel.vetter@ffwll.ch, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, alison.wang@freescale.com List-Id: dri-devel@lists.freedesktop.org T24gMjAxNy0xMS0wNiAyMDoxOCwgTm9yYWxmIFRyw7hubmVzIHdyb3RlOgo+IFJlcGxhY2UgZHJp dmVyJ3MgY29kZSB3aXRoIHRoZSBnZW5lcmljIGhlbHBlcnMgdGhhdCBkbyB0aGUgc2FtZSB0aGlu Zy4KPiBSZW1vdmUgdG9kbyBlbnRyeS4KClRoaXMgcGF0Y2ggbG9va3MgZ29vZCB0byBtZToKUmV2 aWV3ZWQtYnk6IFN0ZWZhbiBBZ25lciA8c3RlZmFuQGFnbmVyLmNoPgoKT25lIHF1ZXN0aW9uIGJl bG93IHRob3VnaDoKCj4gCj4gU2lnbmVkLW9mZi1ieTogTm9yYWxmIFRyw7hubmVzIDxub3JhbGZA dHJvbm5lcy5vcmc+Cj4gLS0tCj4gIERvY3VtZW50YXRpb24vZ3B1L3RvZG8ucnN0ICAgICAgICAg ICAgICAgICAgfCAgNSAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0vY29yZS90aW55ZHJt LWNvcmUuYyB8IDY3IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS90aW55ZHJtL21pMDI4M3F0LmMgICAgICAgICAgfCAgNyArKy0KPiAgaW5jbHVkZS9kcm0v dGlueWRybS90aW55ZHJtLmggICAgICAgICAgICAgICB8ICA0IC0tCj4gIDQgZmlsZXMgY2hhbmdl ZCwgNSBpbnNlcnRpb25zKCspLCA3OCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvRG9j dW1lbnRhdGlvbi9ncHUvdG9kby5yc3QgYi9Eb2N1bWVudGF0aW9uL2dwdS90b2RvLnJzdAo+IGlu ZGV4IGU5ODQwZDY5M2E4Ni4uYTQ0ZjM3OWQyYjI1IDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRp b24vZ3B1L3RvZG8ucnN0Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9ncHUvdG9kby5yc3QKPiBAQCAt NDA0LDExICs0MDQsNiBAQCB0aG9zZSBkcml2ZXJzIGFzIHNpbXBsZSBhcyBwb3NzaWJsZSwgc28g bG90cyBvZgo+IHJvb20gZm9yIHJlZmFjdG9yaW5nOgo+ICAgIGEgZHJtX2RldmljZSB3cm9uZy4g RG9lc24ndCBtYXR0ZXIsIHNpbmNlIGV2ZXJ5b25lIGVsc2UgZ2V0cyBpdCB3cm9uZwo+ICAgIHRv byA6LSkKPiAgCj4gLS0gV2l0aCB0aGUgZmJkZXYgcG9pbnRlciBpbiBkZXYtPm1vZGVfY29uZmln IHdlIGNvdWxkIGFsc28gbWFrZQo+IC0gIHN1c3BlbmQvcmVzdW1lIGhlbHBlcnMgZW50aXJlbHkg Z2VuZXJpYywgYXQgbGVhc3QgaWYgd2UgYWRkIGEKPiAtICBkZXYtPm1vZGVfY29uZmlnLnN1c3Bl bmRfc3RhdGUuIFdlIGNvdWxkIGV2ZW4gcHJvdmlkZSBhIGdlbmVyaWMgcG1fb3BzCj4gLSAgc3Ry dWN0dXJlIHdpdGggdGhvc2UuCj4gLQo+ICAtIGFsc28gcmV3b3JrIHRoZSBkcm1fZnJhbWVidWZm ZXJfZnVuY3MtPmRpcnR5IGhvb2sgd2lyZS11cCwgc2VlIGFib3ZlLgo+ICAKPiAgQ29udGFjdDog Tm9yYWxmIFRyw7hubmVzLCBEYW5pZWwgVmV0dGVyCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS90aW55ZHJtL2NvcmUvdGlueWRybS1jb3JlLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS90aW55 ZHJtL2NvcmUvdGlueWRybS1jb3JlLmMKPiBpbmRleCAxYThhNTdjYWQ0MzEuLmJkN2I4MjgyNGEz NCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdGlueWRybS9jb3JlL3Rpbnlkcm0tY29y ZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0vY29yZS90aW55ZHJtLWNvcmUuYwo+ IEBAIC0yOTIsNzEgKzI5Miw0IEBAIHZvaWQgdGlueWRybV9zaHV0ZG93bihzdHJ1Y3QgdGlueWRy bV9kZXZpY2UgKnRkZXYpCj4gIH0KPiAgRVhQT1JUX1NZTUJPTCh0aW55ZHJtX3NodXRkb3duKTsK PiAgCj4gLS8qKgo+IC0gKiB0aW55ZHJtX3N1c3BlbmQgLSBTdXNwZW5kIHRpbnlkcm0KPiAtICog QHRkZXY6IHRpbnlkcm0gZGV2aWNlCj4gLSAqCj4gLSAqIFVzZWQgaW4gZHJpdmVyIFBNIG9wZXJh dGlvbnMgdG8gc3VzcGVuZCB0aW55ZHJtLgo+IC0gKiBTdXNwZW5kcyBmYmRldiBhbmQgRFJNLgo+ IC0gKiBSZXN1bWUgd2l0aCB0aW55ZHJtX3Jlc3VtZSgpLgo+IC0gKgo+IC0gKiBSZXR1cm5zOgo+ IC0gKiBaZXJvIG9uIHN1Y2Nlc3MsIG5lZ2F0aXZlIGVycm9yIGNvZGUgb24gZmFpbHVyZS4KPiAt ICovCj4gLWludCB0aW55ZHJtX3N1c3BlbmQoc3RydWN0IHRpbnlkcm1fZGV2aWNlICp0ZGV2KQo+ IC17Cj4gLQlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7Cj4gLQo+IC0JaWYgKHRkZXYt PnN1c3BlbmRfc3RhdGUpIHsKPiAtCQlEUk1fRVJST1IoIkZhaWxlZCB0byBzdXNwZW5kOiBzdGF0 ZSBhbHJlYWR5IHNldFxuIik7Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQl9CgpIZXJlIHlvdSB1 c2VkIHRvIGNoZWNrIHdoZXRoZXIgc3VzcGVuZF9zdGF0ZSBpcyBhbHJlYWR5IHNldC4gSG93ZXZl ciwgaW4KZHJtX21vZGVfY29uZmlnX2hlbHBlcl9zdXNwZW5kIHlvdSBkb24ndCAod2hpbGUgeW91 IHN0aWxsIGRvIGluCmRybV9tb2RlX2NvbmZpZ19oZWxwZXJfcmVzdW1lKS4gSSB0aGluayB3ZSBz aG91bGQgYmUgY29uc2lzdGVudCAoY2hlY2sKaW4gc3VzcGVuZCBhbmQgcmVzdW1lIG9yIGluIG5v bm8gb2YgdGhvc2UpLgoKLS0KU3RlZmFuCgo+IC0KPiAtCWRybV9mYmRldl9jbWFfc2V0X3N1c3Bl bmRfdW5sb2NrZWQodGRldi0+ZmJkZXZfY21hLCAxKTsKPiAtCXN0YXRlID0gZHJtX2F0b21pY19o ZWxwZXJfc3VzcGVuZCh0ZGV2LT5kcm0pOwo+IC0JaWYgKElTX0VSUihzdGF0ZSkpIHsKPiAtCQlk cm1fZmJkZXZfY21hX3NldF9zdXNwZW5kX3VubG9ja2VkKHRkZXYtPmZiZGV2X2NtYSwgMCk7Cj4g LQkJcmV0dXJuIFBUUl9FUlIoc3RhdGUpOwo+IC0JfQo+IC0KPiAtCXRkZXYtPnN1c3BlbmRfc3Rh dGUgPSBzdGF0ZTsKPiAtCj4gLQlyZXR1cm4gMDsKPiAtfQo+IC1FWFBPUlRfU1lNQk9MKHRpbnlk cm1fc3VzcGVuZCk7Cj4gLQo+IC0vKioKPiAtICogdGlueWRybV9yZXN1bWUgLSBSZXN1bWUgdGlu eWRybQo+IC0gKiBAdGRldjogdGlueWRybSBkZXZpY2UKPiAtICoKPiAtICogVXNlZCBpbiBkcml2 ZXIgUE0gb3BlcmF0aW9ucyB0byByZXN1bWUgdGlueWRybS4KPiAtICogU3VzcGVuZCB3aXRoIHRp bnlkcm1fc3VzcGVuZCgpLgo+IC0gKgo+IC0gKiBSZXR1cm5zOgo+IC0gKiBaZXJvIG9uIHN1Y2Nl c3MsIG5lZ2F0aXZlIGVycm9yIGNvZGUgb24gZmFpbHVyZS4KPiAtICovCj4gLWludCB0aW55ZHJt X3Jlc3VtZShzdHJ1Y3QgdGlueWRybV9kZXZpY2UgKnRkZXYpCj4gLXsKPiAtCXN0cnVjdCBkcm1f YXRvbWljX3N0YXRlICpzdGF0ZSA9IHRkZXYtPnN1c3BlbmRfc3RhdGU7Cj4gLQlpbnQgcmV0Owo+ IC0KPiAtCWlmICghc3RhdGUpIHsKPiAtCQlEUk1fRVJST1IoIkZhaWxlZCB0byByZXN1bWU6IHN0 YXRlIGlzIG5vdCBzZXRcbiIpOwo+IC0JCXJldHVybiAtRUlOVkFMOwo+IC0JfQo+IC0KPiAtCXRk ZXYtPnN1c3BlbmRfc3RhdGUgPSBOVUxMOwo+IC0KPiAtCXJldCA9IGRybV9hdG9taWNfaGVscGVy X3Jlc3VtZSh0ZGV2LT5kcm0sIHN0YXRlKTsKPiAtCWlmIChyZXQpIHsKPiAtCQlEUk1fRVJST1Io IkVycm9yIHJlc3VtaW5nIHN0YXRlOiAlZFxuIiwgcmV0KTsKPiAtCQlyZXR1cm4gcmV0Owo+IC0J fQo+IC0KPiAtCWRybV9mYmRldl9jbWFfc2V0X3N1c3BlbmRfdW5sb2NrZWQodGRldi0+ZmJkZXZf Y21hLCAwKTsKPiAtCj4gLQlyZXR1cm4gMDsKPiAtfQo+IC1FWFBPUlRfU1lNQk9MKHRpbnlkcm1f cmVzdW1lKTsKPiAtCj4gIE1PRFVMRV9MSUNFTlNFKCJHUEwiKTsKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL3Rpbnlkcm0vbWkwMjgzcXQuYwo+IGIvZHJpdmVycy9ncHUvZHJtL3Rpbnlk cm0vbWkwMjgzcXQuYwo+IGluZGV4IDZhODNiMzA5MzI1NC4uNzBhZTRmNzZmNDU1IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS90aW55ZHJtL21pMDI4M3F0LmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vdGlueWRybS9taTAyODNxdC5jCj4gQEAgLTksNiArOSw3IEBACj4gICAqIChhdCB5 b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCj4gICAqLwo+ICAKPiArI2luY2x1ZGUgPGRy bS9kcm1fbW9kZXNldF9oZWxwZXIuaD4KPiAgI2luY2x1ZGUgPGRybS90aW55ZHJtL2lsaTkzNDEu aD4KPiAgI2luY2x1ZGUgPGRybS90aW55ZHJtL21pcGktZGJpLmg+Cj4gICNpbmNsdWRlIDxkcm0v dGlueWRybS90aW55ZHJtLWhlbHBlcnMuaD4KPiBAQCAtMjMxLDcgKzIzMiw3IEBAIHN0YXRpYyBp bnQgX19tYXliZV91bnVzZWQKPiBtaTAyODNxdF9wbV9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRl dikKPiAgCXN0cnVjdCBtaXBpX2RiaSAqbWlwaSA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+ICAJ aW50IHJldDsKPiAgCj4gLQlyZXQgPSB0aW55ZHJtX3N1c3BlbmQoJm1pcGktPnRpbnlkcm0pOwo+ ICsJcmV0ID0gZHJtX21vZGVfY29uZmlnX2hlbHBlcl9zdXNwZW5kKG1pcGktPnRpbnlkcm0uZHJt KTsKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAgCj4gQEAgLTI0OSw3ICsyNTAsOSBA QCBzdGF0aWMgaW50IF9fbWF5YmVfdW51c2VkCj4gbWkwMjgzcXRfcG1fcmVzdW1lKHN0cnVjdCBk ZXZpY2UgKmRldikKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAgCj4gLQlyZXR1cm4g dGlueWRybV9yZXN1bWUoJm1pcGktPnRpbnlkcm0pOwo+ICsJZHJtX21vZGVfY29uZmlnX2hlbHBl cl9yZXN1bWUobWlwaS0+dGlueWRybS5kcm0pOwo+ICsKPiArCXJldHVybiAwOwo+ICB9Cj4gIAo+ ICBzdGF0aWMgY29uc3Qgc3RydWN0IGRldl9wbV9vcHMgbWkwMjgzcXRfcG1fb3BzID0gewo+IGRp ZmYgLS1naXQgYS9pbmNsdWRlL2RybS90aW55ZHJtL3Rpbnlkcm0uaCBiL2luY2x1ZGUvZHJtL3Rp bnlkcm0vdGlueWRybS5oCj4gaW5kZXggNDc3NGZlM2Q0MjczLi5mYjBkODY2MDBlYTMgMTAwNjQ0 Cj4gLS0tIGEvaW5jbHVkZS9kcm0vdGlueWRybS90aW55ZHJtLmgKPiArKysgYi9pbmNsdWRlL2Ry bS90aW55ZHJtL3Rpbnlkcm0uaAo+IEBAIC0yMCw3ICsyMCw2IEBACj4gICAqIEBwaXBlOiBEaXNw bGF5IHBpcGUgc3RydWN0dXJlCj4gICAqIEBkaXJ0eV9sb2NrOiBTZXJpYWxpemVzIGZyYW1lYnVm ZmVyIGZsdXNoaW5nCj4gICAqIEBmYmRldl9jbWE6IENNQSBmYmRldiBzdHJ1Y3R1cmUKPiAtICog QHN1c3BlbmRfc3RhdGU6IEF0b21pYyBzdGF0ZSB3aGVuIHN1c3BlbmRlZAo+ICAgKiBAZmJfZnVu Y3M6IEZyYW1lYnVmZmVyIGZ1bmN0aW9ucyB1c2VkIHdoZW4gY3JlYXRpbmcgZnJhbWVidWZmZXJz Cj4gICAqLwo+ICBzdHJ1Y3QgdGlueWRybV9kZXZpY2Ugewo+IEBAIC0yOCw3ICsyNyw2IEBAIHN0 cnVjdCB0aW55ZHJtX2RldmljZSB7Cj4gIAlzdHJ1Y3QgZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGUg cGlwZTsKPiAgCXN0cnVjdCBtdXRleCBkaXJ0eV9sb2NrOwo+ICAJc3RydWN0IGRybV9mYmRldl9j bWEgKmZiZGV2X2NtYTsKPiAtCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdXNwZW5kX3N0YXRl Owo+ICAJY29uc3Qgc3RydWN0IGRybV9mcmFtZWJ1ZmZlcl9mdW5jcyAqZmJfZnVuY3M7Cj4gIH07 Cj4gIAo+IEBAIC05Miw4ICs5MCw2IEBAIGludCBkZXZtX3Rpbnlkcm1faW5pdChzdHJ1Y3QgZGV2 aWNlICpwYXJlbnQsIHN0cnVjdAo+IHRpbnlkcm1fZGV2aWNlICp0ZGV2LAo+ICAJCSAgICAgIHN0 cnVjdCBkcm1fZHJpdmVyICpkcml2ZXIpOwo+ICBpbnQgZGV2bV90aW55ZHJtX3JlZ2lzdGVyKHN0 cnVjdCB0aW55ZHJtX2RldmljZSAqdGRldik7Cj4gIHZvaWQgdGlueWRybV9zaHV0ZG93bihzdHJ1 Y3QgdGlueWRybV9kZXZpY2UgKnRkZXYpOwo+IC1pbnQgdGlueWRybV9zdXNwZW5kKHN0cnVjdCB0 aW55ZHJtX2RldmljZSAqdGRldik7Cj4gLWludCB0aW55ZHJtX3Jlc3VtZShzdHJ1Y3QgdGlueWRy bV9kZXZpY2UgKnRkZXYpOwo+ICAKPiAgdm9pZCB0aW55ZHJtX2Rpc3BsYXlfcGlwZV91cGRhdGUo c3RydWN0IGRybV9zaW1wbGVfZGlzcGxheV9waXBlICpwaXBlLAo+ICAJCQkJIHN0cnVjdCBkcm1f cGxhbmVfc3RhdGUgKm9sZF9zdGF0ZSk7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=