From: "Ruhl, Michael J" <michael.j.ruhl@intel.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"airlied@gmail.com" <airlied@gmail.com>,
"ray.huang@amd.com" <ray.huang@amd.com>
Subject: RE: [PATCH] drm/ttm: remove ttm_bo_unmap_virtual_locked declaration
Date: Wed, 7 Oct 2020 11:43:07 +0000 [thread overview]
Message-ID: <cb699f27e94f491db3e38f674815cbda@intel.com> (raw)
In-Reply-To: <20201007085222.16586-1-christian.koenig@amd.com>
>-----Original Message-----
>From: Christian König <ckoenig.leichtzumerken@gmail.com>
>Sent: Wednesday, October 7, 2020 4:52 AM
>To: dri-devel@lists.freedesktop.org; airlied@gmail.com;
>ray.huang@amd.com; Ruhl, Michael J <michael.j.ruhl@intel.com>
>Subject: [PATCH] drm/ttm: remove ttm_bo_unmap_virtual_locked
>declaration
>
>That was missed during the cleanup.
>
>Signed-off-by: Christian König <christian.koenig@amd.com>
>---
> include/drm/ttm/ttm_bo_driver.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
>diff --git a/include/drm/ttm/ttm_bo_driver.h
>b/include/drm/ttm/ttm_bo_driver.h
>index 9897a16c0a9d..b58dedce7079 100644
>--- a/include/drm/ttm/ttm_bo_driver.h
>+++ b/include/drm/ttm/ttm_bo_driver.h
>@@ -449,15 +449,6 @@ int ttm_bo_device_init(struct ttm_bo_device *bdev,
> */
> void ttm_bo_unmap_virtual(struct ttm_buffer_object *bo);
>
>-/**
>- * ttm_bo_unmap_virtual
>- *
>- * @bo: tear down the virtual mappings for this BO
>- *
>- * The caller must take ttm_mem_io_lock before calling this function.
>- */
>-void ttm_bo_unmap_virtual_locked(struct ttm_buffer_object *bo);
greping for ttm_bo_unmap_virtual_locked revealed this:
drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c: * This is similar to ttm_bo_unmap_virtual_locked() except it takes a subrange.
include/drm/ttm/ttm_bo_driver.h:void ttm_bo_unmap_virtual_locked(struct ttm_buffer_object *bo);
Should you clean up the vmwgvx comment to avoid confusion? 😊
Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
m
>-
> /**
> * ttm_bo_reserve:
> *
>--
>2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-07 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 8:52 [PATCH] drm/ttm: remove ttm_bo_unmap_virtual_locked declaration Christian König
2020-10-07 11:43 ` Ruhl, Michael J [this message]
2020-10-07 11:44 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb699f27e94f491db3e38f674815cbda@intel.com \
--to=michael.j.ruhl@intel.com \
--cc=airlied@gmail.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ray.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox