From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33705C02194 for ; Thu, 6 Feb 2025 13:04:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AC51410E2D3; Thu, 6 Feb 2025 13:04:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="pDZ2ygPJ"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id CA23B10E2D3 for ; Thu, 6 Feb 2025 13:04:28 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7F1C55C57E4; Thu, 6 Feb 2025 13:03:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 773E5C4CEDD; Thu, 6 Feb 2025 13:04:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738847068; bh=HcPtGRcTHAOfFGOkTyn/W0r0zfnZmlWtrN18FEpXJh8=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=pDZ2ygPJsmDFa8WwJ3UD3N5GE6qpleBBL5vG7ZH/EnrMA+YS+Euxx8GgnLzhwSC3e Mk5a0IwDMiUW13tzHVnwrZqM8PqUTbEt5UeLzUSdxFjSfBjh4f5hsk24BkpzE5m6Yf pJ8E2hhl4IYgr5mYL854fDdkqVJKP3nz5MsZA842RI+JCzvt65rFQtQL9dL+8Guvmo N0msJyO/UuXWpzRfEa6Az05uyqbHFlBAQ6l3fgz13Ho0DD4gSALD5xQz9JtQ+0l6/x i1W39I4VgyzT7A76IR5D+W2/rdNNy5jveHMG9NZmA2OeVjiSc/fTX+Q3byEdInWMXn IDVqw/q55Aw0A== Message-ID: Date: Thu, 06 Feb 2025 13:04:25 +0000 From: "Maxime Ripard" To: "Herve Codina" Subject: Re: [PATCH v5 3/4] drm/vc4: hdmi: Use drm_atomic_helper_reset_crtc() In-Reply-To: <20250203161607.223731-4-herve.codina@bootlin.com> References: <20250203161607.223731-4-herve.codina@bootlin.com> Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Alexander Stein" , "Andrzej Hajda" , "Conor Dooley" , "Dave Stevenson" , "David Airlie" , "Jernej Skrabec" , "Jonas Karlman" , "Krzysztof Kozlowski" , "Laurent Pinchart" , "Louis Chauvet" , "Luca Ceresoli" , "Maarten Lankhorst" , "Marek Vasut" , "Maxime Ripard" , =?utf-8?b?TWHDrXJhIENhbmFs?= , "Neil Armstrong" , "Raspberry Pi Kernel Maintenance" , "Rob Herring" , "Robert Foss" , "Simona Vetter" , "Thomas Petazzoni" , "Thomas Zimmermann" Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 3 Feb 2025 17:16:05 +0100, Herve Codina wrote: > The current code uses a the reset_pipe() local function to reset the > CRTC outputs. > > drm_atomic_helper_reset_crtc() has been introduced recently and it > performs exact same operations. > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime