From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 710F3C10DC3 for ; Mon, 4 Dec 2023 19:03:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 20A8B10E21E; Mon, 4 Dec 2023 19:03:20 +0000 (UTC) Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 41BD410E21E for ; Mon, 4 Dec 2023 19:03:17 +0000 (UTC) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B4ITrwa006167; Mon, 4 Dec 2023 19:03:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=5b6CoS6IQNTgY04Hz+pBuIrLVTg1eASLDvg9Xd041FU=; b=YUmlq5D3FDM3WbPl339P0exs7JUB/5E1fBHyJwIrDi4VQiKbBY8p1kYJc7aCBZPIPa5u xmxE66rn+ArGau7bSWrA5y8qIt9jO7juhIdg9ptc9zhqdV8c3nwduUCHOLQIYoM/OERk Sr8Z0815kRwOW6GlpZ7OHlwC/xlQZOtmalQ5L0IEwaXrf5Fq2Ma/32qNjbAqRmxj+eJT oKY0Xs0vb/WoysL3PYKhrIUEf+tTZqeeNeO88rF7jbr+i6wiqsArWBqsiPiBCUYWI96a 4QE+mX9S7YdHITkdoZwpv25KEfBiVHsRTx7yr/n7us7867DbMPGj/peR+hW/KSX5CCIx dw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3usekts40v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Dec 2023 19:03:13 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3B4J3CM4007230 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 4 Dec 2023 19:03:12 GMT Received: from [10.226.59.182] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 4 Dec 2023 11:03:12 -0800 Message-ID: Date: Mon, 4 Dec 2023 12:03:11 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH] accel/ivpu/37xx: Fix interrupt_clear_with_0 WA initialization Content-Language: en-US To: Jacek Lawrynowicz , References: <20231204122331.40560-1-jacek.lawrynowicz@linux.intel.com> From: Jeffrey Hugo In-Reply-To: <20231204122331.40560-1-jacek.lawrynowicz@linux.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: bPqTv9H44CMn0yc13MgV742Z_efVfAlI X-Proofpoint-ORIG-GUID: bPqTv9H44CMn0yc13MgV742Z_efVfAlI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-04_18,2023-12-04_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 spamscore=0 phishscore=0 impostorscore=0 mlxlogscore=612 suspectscore=0 clxscore=1011 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2312040147 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrzej Kacprowski Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 12/4/2023 5:23 AM, Jacek Lawrynowicz wrote: > From: Andrzej Kacprowski > > Using PCI Device ID/Revision to initialize the interrupt_clear_with_0 > workaround is problematic - there are many pre-production > steppings with different behavior, even with the same PCI ID/Revision > > Instead of checking for PCI Device ID/Revision, check the VPU > buttress interrupt status register behavior - if this register > is not zero after writing 1s it means there register is RW > instead of RW1C and we need to enable the interrupt_clear_with_0 > workaround. > > Fixes: 7f34e01f77f8 ("accel/ivpu: Clear specific interrupt status bits on C0") > Signed-off-by: Andrzej Kacprowski > Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo