From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A690CC433EF for ; Thu, 27 Jan 2022 09:38:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 699D410E496; Thu, 27 Jan 2022 09:38:04 +0000 (UTC) Received: from ste-pvt-msa1.bahnhof.se (ste-pvt-msa1.bahnhof.se [213.80.101.70]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3606610E496; Thu, 27 Jan 2022 09:38:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ste-pvt-msa1.bahnhof.se (Postfix) with ESMTP id F22253F6A1; Thu, 27 Jan 2022 10:38:00 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at bahnhof.se Authentication-Results: ste-pvt-msa1.bahnhof.se (amavisd-new); dkim=pass (1024-bit key) header.d=shipmail.org Received: from ste-pvt-msa1.bahnhof.se ([127.0.0.1]) by localhost (ste-pvt-msa1.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HV0cfcZUN293; Thu, 27 Jan 2022 10:37:59 +0100 (CET) Received: by ste-pvt-msa1.bahnhof.se (Postfix) with ESMTPA id CD9B13F636; Thu, 27 Jan 2022 10:37:57 +0100 (CET) Received: from [192.168.0.209] (unknown [192.55.54.50]) by mail1.shipmail.org (Postfix) with ESMTPSA id D6B953626A5; Thu, 27 Jan 2022 10:37:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=shipmail.org; s=mail; t=1643276277; bh=T0bnNFvqHkTrNJF5LWMl+KiCnilYvzbUtJvNeImUEEk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kFJ4XKzuXOQC0TqVyxd9+200cUOqF0fpOQc+cIWPB9f8pDi92dAI8UaAl+LftpA0v FgO4ULBJxdhBdRUm/DTLJZMXkPkylDIfQuduMVrRJcWOO5xtK9Dn1M7MBQa9D59KaK 9aJaqv2K4c/kusNguko16tV8oCOWfaIMbCMzXQgc= Message-ID: Date: Thu, 27 Jan 2022 10:37:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [Intel-gfx] [PATCH v5 1/5] drm/i915: add needs_compact_pt flag Content-Language: en-US To: Robert Beckett , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter References: <20220125193530.3272386-1-bob.beckett@collabora.com> <20220125193530.3272386-2-bob.beckett@collabora.com> <6d0a57e7-daf7-6436-e806-7cc8794c2d50@shipmail.org> <19bf8290-9308-b5c6-eb73-4020fa81aa66@collabora.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m_=28Intel=29?= In-Reply-To: <19bf8290-9308-b5c6-eb73-4020fa81aa66@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Matthew Auld Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 1/26/22 18:11, Robert Beckett wrote: > > > On 26/01/2022 13:49, Thomas Hellström (Intel) wrote: >> >> On 1/25/22 20:35, Robert Beckett wrote: >>> From: Ramalingam C >>> >>> Add a new platform flag, needs_compact_pt, to mark the requirement of >>> compact pt layout support for the ppGTT when using 64K GTT pages. >>> >>> With this flag has_64k_pages will only indicate requirement of 64K >>> GTT page sizes or larger for device local memory access. >>> >>> Suggested-by: Matthew Auld >>> Signed-off-by: Ramalingam C >>> Signed-off-by: Robert Beckett >>> --- >>>   drivers/gpu/drm/i915/i915_drv.h          | 10 +++++++--- >>>   drivers/gpu/drm/i915/i915_pci.c          |  2 ++ >>>   drivers/gpu/drm/i915/intel_device_info.h |  1 + >>>   3 files changed, 10 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/i915/i915_drv.h >>> b/drivers/gpu/drm/i915/i915_drv.h >>> index 44c1f98144b4..1258b7779705 100644 >>> --- a/drivers/gpu/drm/i915/i915_drv.h >>> +++ b/drivers/gpu/drm/i915/i915_drv.h >>> @@ -1512,12 +1512,16 @@ IS_SUBPLATFORM(const struct drm_i915_private >>> *i915, >>>   /* >>>    * Set this flag, when platform requires 64K GTT page sizes or >>> larger for >>> - * device local memory access. Also this flag implies that we >>> require or >>> - * at least support the compact PT layout for the ppGTT when using >>> the 64K >>> - * GTT pages. >> >> Why do we remove these comment lines? > Because HAS_64K_PAGES now means just 64K page, it no longer means also > requires compact pt. > This is to support other products that will have 64K but not have the > PDE non-sharing restriction in future. > > Those lines moved to the next change NEEDS_COMPACT_PT, which is now > separate. Yes, NEEDS_COMPACT_PT indicates that compact is *required* but does "HAS_64K_PAGES" still mean compact is supported? That information is lost. /Thomas