From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harry Wentland Subject: Re: [PATCH] drm/amd: DC pull request review Date: Wed, 27 Sep 2017 09:47:26 -0400 Message-ID: References: <1506476167-2637-1-git-send-email-alexander.deucher@amd.com> <20170927101550.23176-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0061.outbound.protection.outlook.com [104.47.38.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD05E6E327 for ; Wed, 27 Sep 2017 14:02:20 +0000 (UTC) In-Reply-To: <20170927101550.23176-1-daniel.vetter@ffwll.ch> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , DRI Development Cc: Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gMjAxNy0wOS0yNyAwNjoxNSBBTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPaywgaGVyZSdz IG9uZSBtb3JlIGF0dGVtcHQgYXQgc2Nyb2xsaW5nIHRocm91Z2ggMTMwayBkaWZmLgo+IAo+IE92 ZXJhbGwgdmVyZGljdCBmcm9tIG1lIGlzIHRoYXQgREMgaXMgYmlnIHByb2plY3QsIGFuZCBsaWtl IGFueSBiaWcKPiBwcm9qZWN0IGl0J3MgbmV2ZXIgZG9uZS4gU28gYXQgbGVhc3QgZm9yIG1lIHRo ZSBnb2FsIGlzbid0IHRvIG1ha2UKPiB0aGluZ3MgcGVyZmVjdCwgYmVjYXVlIGlmIHRoYXQncyB0 aGUgaG9vcCB0byBqdW1wIHRocm91Z2ggd2Ugd291bGRuJ3QKPiBoYXZlIGFueSBncHUgZHJpdmVy cyBhdCBhbGwuIE1vcmUgaW1wb3J0YW50IGlzIHdoZXRoZXIgbWVyZ2luZyBhIG5ldwo+IGRyaXZl ciBiYXNlIHdpbGwgYmVuZWZpdCB0aGUgb3ZlcmFsbCBzdWJzeXN0ZW0sIGFuZCBoZXJlIHRoaXMK PiBwcmltYXJpbHkgbWVhbnMgd2hldGhlciB0aGUgREMgdGVhbSB1bmRlcnN0YW5kcyBob3cgdXBz dHJlYW0gd29ya3MgYW5kCj4gaXMgZGVzaWduZWQsIGFuZCB3aGV0aGVyIHRoZSBjb2RlIGlzIGxh cmdlbHkgYWxpZ25lZCB3aXRoIHVwc3RyZWFtCj4gKGVzcGVjaWFsbHkgdGhlIGF0b21pYyBtb2Rl c2V0KSBhcmNoaXRlY3R1cmUuCj4gCj4gTG9va2luZyBiYWNrIG92ZXIgdGhlIGxhc3QgdHdvIHll YXJzIEkgdGhpbmsgdGhhdCdzIHRoZSBjYXNlIG5vdywgc28KPiAKPiBBY2tlZC1ieTogRGFuaWVs IFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiAKPiBmb3IgbWVyZ2luZyB0aGlzIHB1 bGwuCj4gCj4gV2hpbGUgc2Nyb2xsaW5nIHRocm91Z2ggdGhlIHB1bGwgSSBzcG90dGVkIGEgYnVu Y2ggbW9yZSB0aGluZ3MgdGhhdAo+IHNob3VsZCBiZSByZWZhY3RvcmVkLCBidXQgbW9zdCBvZiB0 aGVzZSB3aWxsIGJlIGEgcmVhbCBwYWluIHdpdGggREMKPiBpcyBvdXQgb2YgdHJlZSwgYW5kIG11 Y2ggZWFzaWVyIGluIHRyZWUgc2luY2UgaW4gbWFueSBvZiB0aGVzZSBhcmVhcwo+IHRoZSBpbi10 cmVlIGhlbHBlcnMgYXJlbid0IHVwIHRvIHNudWZmIHlldCBmb3Igd2hhdCBEQyBuZWVkcy4gVGhh dAo+IGtpbmQgb2Ygd29yayBpcyBiZXN0IGRvbmUgd2hlbiB0aGVyZSdzIG9uZSB0cmVlIHdpdGgg ZXZlcnl0aGluZwo+IGludGVncmF0ZWQuCj4gCj4gVGhhdCdzIGFsc28gd2h5IEkgdGhpbmsgd2Ug c2hvdWxkIG1lcmdlIERDIGludG8gZHJtLW5leHQgZGlyZWN0bHksIHNvCj4gd2UgY2FuIGdldCBz dGFydGVkIG9uIHRoZSBpbnRlZ3JhdGlvbiBwb2xpc2ggcmlnaHQgYXdheS4gVGhhdCBoYXMgYQo+ IGJpdCBoaWdoZXIgcmlzayBvZiBMaW51cyBoYXZpbmcgYSBzcGF6eiwgc28gaGVyZSdzIG15IHJl Y29tbWVuZGF0aW9uCj4gZm9yIG1lcmdpbmc6Cj4gCj4gLSBUaGVyZSdzIGEgZmV3IGFkZGl0aW9u cyB0byBkcm1fZHBfaGVscGVyLmggc3ByaW5rbGVkIGFsbCBvdmVyIHRoZQo+ICAgcHVsbC4gSSB0 aGluayB0aG9zZSBzaG91bGQgYmUgcHV0IGludG8gYSBwYXRjaCBvZiBpdCdzIG93biwgYW5kCj4g ICBtZXJnZWQgZmlyc3QuIE5vIG5lZWQgdG8gcmViYXNlIERDLCBnaXQgbWVyZ2Ugd2lsbCBkdHJ0 IGFuZCBub3QgZW5kCj4gICB1cCB3aXRoIGR1cGxpY2F0ZXMuCj4gCj4gLSBkbV9hbGxvYy9yZWFs bG9jL2ZyZWUgaXMgc29tZXRoaW5nIERhdmUgQWlybGllIG5vdGljZWQsIGFuZCBJIGFncmVlCj4g ICBpdCdzIGFuIGVhc3kgcmVkIGZsYWcgdGhhdCBtaWdodCB1cHNldCBMaW51cy4gY29jY2kgY2Fu IGZpeCB0aGlzCj4gICBlYXN5LCBzbyBubyByZWFsIHByb2JsZW0gSSB0aGluayB0byBwYXRjaCB1 cCBpbiBvbmUgYmlnIHBhdGNoIChJCj4gICB0aG91Z2h0IHdlJ3ZlIGhhZCBhICJyZW1vdmUgbWFs bG9jIHdyYXBwZXJzIiB0b2RvIGl0ZW0gaW4gdGhlIHZlcnkKPiAgIGZpcnN0IHJldmlldywgYXBw YXJlbnRseSB0aGVyZSB3YXMgbW9yZSB0aGFuIG9uZSBzdWNoIHdyYXBwZXIpLgo+IAo+IC0gVGhl IGhpc3RvcnkgaXMgaHVnZSwgYnV0IEFNRCBmb2xrcyB3YW50IHRvIGtlZXAgaXQgaWYgcG9zc2li bGUsIGFuZAo+ICAgSSBzZWUgdGhlIHZhbHVlIGluIHRoYXQuIFdvdWxkIGJlIGdvb2QgdG8gZ2V0 IGFuIGFjayBmcm9tIExpbnVzIGZvcgo+ICAgdGhhdCAoYnV0IHNob3VsZG4ndCBiZSBhbiBpc3N1 ZSwgbm90IHRoZSBmaXJzdCB0aW1lIHdlJ3ZlIG1lcmdlZCB0aGUKPiAgIGZ1bGwgaGlzdG9yeSBv ZiBvdXQtb2YtdHJlZSB3b3JrKS4KPiAKPiBTaG9ydCZsb25nZXIgdGVybSBUT0RPIGl0ZW1zIGFy ZSBzdGlsbCB0cmFja2VkLCBtaWdodCBiZSBhIGdvb2QgaWRlYQo+IHRvIGludGVncmF0ZSB0aG9z ZSB0aGUgb3ZlcmFsbCBkcm0gdG9kbyBpbiBvdXIgZ3B1IGRvY3VtZW50YXRpb24sIGZvcgo+IG1v cmUgdmlzaWJpbGl0eS4KPiAKPiBTbyBpbiBhIHdheSB0aGlzIGlzIGtpbmRhIGxpa2Ugc3RhZ2lu ZywgZXhjZXB0IG5vdCB3aXRoIHRoZSBob3JyaWJseQo+IGJyb2tlbiBwcm9jZXNzIG9mIGhhdmlu ZyBhbiBlbnRpcmVseSBzZXBhcmF0ZSB0cmVlIGZvciBzdGFnaW5nIGRyaXZlcnMKPiB3aGljaCBq dXN0IG1ha2VzIHJlZmFjdG9yaW5nIG5lZWRsZXNzbHkgcGFpbmZ1bCAod2hpY2ggZGVmZWF0cyB0 aGUKPiBwb2ludCBvZiBzdGFnaW5nIHJlYWxseSkuIFNvIHN0YWdpbmctd2l0aGluLXRoZS1zdWJz eXN0ZW0uIFdlJ3ZlIGhhZAo+IHRoYXQgYmVmb3JlLCB3aXRoIGVhcmx5IG5vdXZlYXUuCj4gCj4g QW5kIHllcyBzb21lIG9mIHRoZSBmaWxlcyBhcmUgdXR0ZXJseSBob3JyaWJsZSB0byByZWFkIGFu ZCBub3QKPiBhbnl0aGluZyBjbG9zZSB0byBrZXJuZWwgY29kaW5nIHN0eWxlIHN0YW5kYXJkcy4g QnV0IHRoYXQncyB0aGUgcG9pbnQsCj4gdGhleSdyZSBlc3NlbnRpYWxseSBnb3NwZWwgZnJvbSBo dyBlbmdpbmVlcnMgdGhhdCBoYXBwZW5zIHRvIGJlCj4gcGFyc2VhYmxlIGJ5IGdjYy4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KClRo YW5rcyBmb3IgdGhlIGZlZWRiYWNrLCBhY2sgYW5kIGhlbHAgYWxvbmcgdGhlIHdheS4KClRoaXMg cGF0Y2ggaXMKUmV2aWV3ZWQtYnk6IEhhcnJ5IFdlbnRsYW5kIDxoYXJyeS53ZW50bGFuZEBhbWQu Y29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L1RPRE8gfCAzMSArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAzMSBpbnNlcnRp b25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9UT0RP IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L1RPRE8KPiBpbmRleCAyNzM3ODczZGIxMmQu LmVlYTY0NWIxMDJhMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkv VE9ETwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9UT0RPCj4gQEAgLTc5LDMg Kzc5LDM0IEBAIFRPRE9zCj4gIAo+ICAxMi4gZHJtX21vZGVzZXRfbG9jayBpbiBNU1Qgc2hvdWxk IG5vIGxvbmdlciBiZSBuZWVkZWQgaW4gcmVjZW50IGtlcm5lbHMKPiAgICAgICogQWRvcHQgYXBw cm9wcmlhdGUgbG9ja2luZyBzY2hlbWUKPiArCj4gKzEzLiBnZXRfbW9kZXMgYW5kIGJlc3RfZW5j b2RlciBjYWxsYmFja3MgbG9vayBhIGJpdCBmdW5ueS4gQ2FuIHByb2JhYmx5IHJpcCBvdXQKPiAr YSBmZXcgaW5kaXJlY3Rpb25zLCBhbmQgY29uc2lkZXIgcmVtb3ZpbmcgZW50aXJlbHkgYW5kIHVz aW5nIHRoZQo+ICtkcm1fYXRvbWljX2hlbHBlcl9iZXN0X2VuY29kZXIgZGVmYXVsdCBiZWhhdmlv dXIuCj4gKwo+ICsxNC4gY29yZS9kY19kZWJ1Zy5jLCBjb25zaWRlciBzd2l0Y2hpbmcgdG8gdGhl IGF0b21pYyBzdGF0ZSBkZWJ1ZyBoZWxwZXJzIGFuZAo+ICttb3ZpbmcgYWxsIHlvdXIgZHJpdmVy IHN0YXRlIHByaW50aW5nIGludG8gdGhlIHZhcmlvdXMgYXRvbWljX3ByaW50X3N0YXRlCj4gK2Nh bGxiYWNrcy4gVGhlcmUncyBhbHNvIHBsYW5zIHRvIGV4cG9zZSB0aGlzIHN0dWZmIGluIGEgc3Rh bmRhcmQgd2F5IGFjcm9zcyBhbGwKPiArZHJpdmVycywgdG8gbWFrZSBkZWJ1Z2dpbmcgdXNlcnNw YWNlIGNvbXBvc2l0b3JzIGVhc2llciBhY3Jvc3MgZGlmZmVyZW50IGh3Lgo+ICsKPiArMTUuIE1v dmUgRFAvSERNSSBkdWFsIG1vZGUgYWRhcHRvcnMgdG8gZHJtX2RwX2R1YWxfbW9kZV9oZWxwZXIu Yy4KPiArCj4gKzE2LiBNb3ZlIHRvIGNvcmUgU0NEQyBoZWxwZXJzIChJIHRoaW5rIHRob3NlIGFy ZSBuZXcgc2luY2UgaW5pdGlhbCBEQyByZXZpZXcpLgo+ICsKPiArMTcuIFRoZXJlJ3Mgc3RpbGwg YSBwcmV0dHkgbWFzc2l2ZSBsYXllciBjYWtlIGFyb3VuZCBkcCBhdXggYW5kIERQQ0QgaGFuZGxp bmcsCj4gK3dpdGggbGlrZSAzIGxldmVscyBvZiBhYnN0cmFjdGlvbiBhbmQgdXNpbmcgeW91ciBv d24gc3RydWN0dXJlcyBpbnN0ZWFkIG9mIHRoZQo+ICtzdHVmZiBpbiBkcm1fZHBfaGVscGVyLmgu IGRybV9kcF9oZWxwZXIuaCBpc24ndCByZWFsbHkgZ3JlYXQgYW5kIGFscmVhZHkgaGFzIDIKPiAr aW5jb21wYXRpYmxlIHN0eWxlcywganVzdCBtZWFucyBtb3JlIHJlYXNvbnMgbm90IHRvIGFkZCBh IHRoaXJkIChvciB3ZWxsIHRoaXJkCj4gK29uZSBnZXRzIHRvIGRvIHRoZSBjbGVhbnVwIHJlZmFj dG9yKS4KPiArCj4gKzE4LiBUaGVyZSdzIGEgcGlsZSBvZiBzaW5rIGhhbmRsaW5nIGNvZGUsIGJv dGggZm9yIERQIGFuZCBIRE1JIHdoZXJlIEkgZGlkbid0Cj4gK2ltbWVkaWF0ZWx5IHJlY29nbml6 ZSB0aGUgc3RhbmRhcmQuIEkgdGhpbmsgbG9uZyB0ZXJtIGl0J2QgYmUgYmVzdCBmb3IgdGhlIGRy bQo+ICtzdWJzeXN0ZW0gaWYgd2UgdHJ5IHRvIG1vdmUgYXMgbXVjaCBvZiB0aGF0IGludG8gaGVs cGVycy9jb3JlIGFzIHBvc3NpYmxlLCBhbmQKPiArc2hhcmUgaXQgd2l0aCBkcml2ZXJzLiBCdXQg dGhhdCdzIGEgdmVyeSBsb25nIHRlcm0gZ29hbCwgYW5kIGJ5IGZhciBub3QganVzdCBhbgo+ICtp c3N1ZSB3aXRoIERDIC0gb3RoZXIgZHJpdmVycywgZXNwZWNpYWxseSBhcm91bmQgRFAgc2luayBo YW5kbGluZywgYXJlIGVxdWFsbHkKPiArZ3VpbHR5Lgo+ICsKPiArMTkuIFRoZSBEQyBsb2dnZXIg aXMgc3RpbGwgYSByYXRoZXIgc29yZSB0aGluZywgYnV0IEkga25vdyB0aGF0IHRoZSBEUk1fREVC VUcKPiArc3R1ZmYganVzdCBpc24ndCB1cCB0byB0aGUgY2hhbGxlbmdlcyBlaXRoZXIuIFdlIG5l ZWQgdG8gZmlndXJlIG91dCBzb21ldGhpbmcKPiArdGhhdCBpbnRlZ3JhdGVzIGJldHRlciB3aXRo IERSTSBhbmQgbGludXggZGVidWcgcHJpbnRpbmcsIHdoaWxlIG5vdCBiZWluZwo+ICt1c2VsZXNz IHdpdGggZmlsdGVyaW5nIG91dHB1dC4gZHluYW1pYyBkZWJ1ZyBwcmludGluZyBtaWdodCBiZSBh biBvcHRpb24uCj4gCgpIYXZlIHRoZXJlIGJlZW4gYW55IHRob3VnaHRzIG9uIGltcHJvdmluZyBs b2cgZmlsdGVyaW5nIGluIERSTT8gSSB0aGluawpvdXIgS0ZEIGd1eXMgKHdoaWNoIGhvcGVmdWxs eSBnbyB1cHN0cmVhbSBzb29uIGFzIHdlbGwpIGFyZSB1c2luZwpkeW5hbWljIGRlYnVnIHByaW50 cyBmb3IgaXQgYnV0IG5vdCBzdXJlIGlmIHRoYXQncyBlbnRpcmVseSB0aGUgcmlnaHQKYXBwcm9h Y2guCgpIYXJyeQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK