dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: dri-devel@lists.freedesktop.org
Cc: Jyri Sarha <jsarha@ti.com>,
	tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com
Subject: [PATCH 15/21] drm/tilcdc: cleanup irq handling
Date: Thu, 4 Feb 2016 11:31:08 +0200	[thread overview]
Message-ID: <cf6dbf8c666942ad44d49530da7866a8ef82690a.1454577570.git.jsarha@ti.com> (raw)
In-Reply-To: <cover.1454577570.git.jsarha@ti.com>

From: Tomi Valkeinen <tomi.valkeinen@ti.com>

Cleanup irq handling. Clear the irq status unconditionally and
restructure the status bit conditions.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
[Added description to the patch]
Signed-off-by: Jyri Sarha <jsarha@ti.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index fe2aed7..280c76a 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
@@ -656,11 +656,12 @@ irqreturn_t tilcdc_crtc_irq(struct drm_crtc *crtc)
 	struct tilcdc_crtc *tilcdc_crtc = to_tilcdc_crtc(crtc);
 	struct drm_device *dev = crtc->dev;
 	struct tilcdc_drm_private *priv = dev->dev_private;
-	uint32_t stat = tilcdc_read_irqstatus(dev);
+	uint32_t stat;
 
-	if (stat & LCDC_PL_LOAD_DONE) {
-		tilcdc_clear_irqstatus(dev, stat);
-	} else {
+	stat = tilcdc_read_irqstatus(dev);
+	tilcdc_clear_irqstatus(dev, stat);
+
+	if ((stat & LCDC_END_OF_FRAME0) || (stat & LCDC_END_OF_FRAME1)) {
 		struct drm_pending_vblank_event *event;
 		unsigned long flags;
 		uint32_t dirty = tilcdc_crtc->dirty & stat;
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-02-04  9:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04  9:30 [PATCH 00/21] drm/ticdc: Accumulated fixes over the past couple of years Jyri Sarha
2016-02-04  9:30 ` [PATCH 01/21] drm/tilcdc: disable console switching during pm operations Jyri Sarha
2016-02-08 20:00   ` Tomi Valkeinen
2016-02-09  9:41     ` Daniel Vetter
2016-02-04  9:30 ` [PATCH 02/21] drm/tilcdc: rewrite pixel clock calculation Jyri Sarha
2016-02-04  9:30 ` [PATCH 03/21] drm/tilcdc: verify fb pitch Jyri Sarha
2016-02-04  9:30 ` [PATCH 04/21] drm/tilcdc: adopt pinctrl support Jyri Sarha
2016-02-04  9:30 ` [PATCH 05/21] drm/tilcdc: fix kernel panic on suspend when no hdmi monitor connected Jyri Sarha
2016-02-04  9:30 ` [PATCH 06/21] drm/tilcdc: make frame_done interrupt active at all times Jyri Sarha
2016-02-04  9:31 ` [PATCH 07/21] drm/tilcdc: disable the lcd controller/dma engine when suspend invoked Jyri Sarha
2016-02-04  9:31 ` [PATCH 08/21] drm/tilcdc: Implement dma-buf support for tilcdc Jyri Sarha
2016-02-04  9:31 ` [PATCH 09/21] drm/tilcdc: fix build error when !CONFIG_CPU_FREQ Jyri Sarha
2016-02-04  9:31 ` [PATCH 10/21] drm/tilcdc: Allocate register storage based on the actual number registers Jyri Sarha
2016-02-04  9:31 ` [PATCH 11/21] drm/tilcdc: cleanup runtime PM handling Jyri Sarha
2016-02-04  9:31 ` [PATCH 12/21] drm/tilcdc: disable crtc on unload Jyri Sarha
2016-02-04  9:31 ` [PATCH 13/21] drm/tilcdc: split reset to a separate function Jyri Sarha
2016-02-04  9:31 ` [PATCH 14/21] drm/tilcdc: remove broken error handling Jyri Sarha
2016-02-04  9:31 ` Jyri Sarha [this message]
2016-02-04  9:31 ` [PATCH 16/21] drm/tilcdc: Get rid of complex ping-pong mechanism Jyri Sarha
2016-02-04  9:31 ` [PATCH 17/21] drm/tilcdc: Do not update the next frame buffer close to vertical blank Jyri Sarha
2016-02-04  9:31 ` [PATCH 18/21] drm/tilcdc: Fix interrupt enable/disable code for version 2 tilcdc Jyri Sarha
2016-02-04  9:31 ` [PATCH 19/21] drm/tilcdc: Remove the duplicate LCDC_INT_ENABLE_SET_REG in registers[] Jyri Sarha
2016-02-04  9:31 ` [PATCH 20/21] drm/tilcdc: Add prints on sync lost and FIFO underrun interrupts Jyri Sarha
2016-02-04  9:31 ` [PATCH 21/21] drm/tilcdc: Disable sync lost interrupt if it fires on every frame Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf6dbf8c666942ad44d49530da7866a8ef82690a.1454577570.git.jsarha@ti.com \
    --to=jsarha@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).