From: Lukas Wunner <lukas@wunner.de>
To: dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org,
Seth Forshee <seth.forshee@canonical.com>,
Ben Skeggs <bskeggs@redhat.com>,
nouveau@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
Dave Airlie <airlied@redhat.com>,
Thierry Reding <treding@nvidia.com>,
Darren Hart <dvhart@infradead.org>
Subject: [PATCH v5 00/12] Enable GPU switching on pre-retina MacBook Pro
Date: Mon, 11 Jan 2016 20:09:20 +0100 [thread overview]
Message-ID: <cover.1452525860.git.lukas@wunner.de> (raw)
Enable GPU switching on the pre-retina MacBook Pro (2008 - 2013), v5.
The main obstacle on these machines is that the panel mode in VBIOS
is bogus. Fortunately gmux can switch DDC independently from the
display, thereby allowing the inactive GPU to probe the panel's EDID.
In short, vga_switcheroo and apple-gmux are amended with hooks to
switch DDC, DRM core is amended with a drm_get_edid_switcheroo() helper,
and relevant drivers are amended to call that for LVDS outputs.
The retina MacBook Pro (2012 - present) uses eDP and cannot switch
AUX independently from the main link. The main obstacle there is link
training, I'm currently working on this, it will be addressed in a
future patch set.
This series is also reviewable on GitHub:
https://github.com/l1k/linux/commits/mbp_switcheroo_v5
Changes:
* New patch [01/12]: vga_switcheroo handler flags
Alex Deucher asked if this series might regress on non-Apple laptops.
To address this concern, I let handlers declare their capabilities in
a bitmask. DRM drivers call drm_get_edid_switcheroo() only if the
handler has set the VGA_SWITCHEROO_CAN_SWITCH_DDC flag.
Currently just one other flag is defined which is used on retinas.
* Changed patch [02/12]: vga_switcheroo DDC locking
Rename ddc_lock to mux_hw_lock, suggested by Daniel Vetter.
* New patch [03/12]: track switch state of apple-gmux
Fixes a bug in previous versions of this series which occurred if
the system was suspended while DDC was temporarily switched:
On resume DDC was switched to the wrong GPU.
* New patches [09/12 - 12/12]: deferred probing
Previously I used connector reprobing if the inactive GPU's driver
loaded before gmux. I've ditched that in favor of deferred driver
probing, which is much simpler. Thanks to Daniel Vetter for the
suggestion.
Caution: Patch [09/12] depends on a new acpi_dev_present() API which
will land in 4.5 via Rafael J. Wysocki's tree.
I would particularly be interested in feedback on the handler flags
patch [01/12]. I'm not 100% happy with the number of characters
required to query the flags (e.g.: if (vga_switcheroo_handler_flags() &
VGA_SWITCHEROO_CAN_SWITCH_DDC)), but failed to come up with something
shorter. Thierry Reding used a struct of bools instead of a bitmask
for his recent drm_dp_link_caps patches. Maybe use that instead?
http://lists.freedesktop.org/archives/dri-devel/2015-December/097025.html
Thanks,
Lukas
Lukas Wunner (12):
vga_switcheroo: Add handler flags infrastructure
vga_switcheroo: Add support for switching only the DDC
apple-gmux: Track switch state
apple-gmux: Add switch_ddc support
drm/edid: Switch DDC when reading the EDID
drm/i915: Switch DDC when reading the EDID
drm/nouveau: Switch DDC when reading the EDID
drm/radeon: Switch DDC when reading the EDID
apple-gmux: Add helper for presence detect
drm/i915: Defer probe if gmux is present but its driver isn't
drm/nouveau: Defer probe if gmux is present but its driver isn't
drm/radeon: Defer probe if gmux is present but its driver isn't
Documentation/DocBook/gpu.tmpl | 5 +
drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 3 +-
drivers/gpu/drm/drm_edid.c | 26 +++++
drivers/gpu/drm/i915/i915_drv.c | 12 +++
drivers/gpu/drm/i915/intel_lvds.c | 8 +-
drivers/gpu/drm/nouveau/nouveau_acpi.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_connector.c | 21 +++-
drivers/gpu/drm/nouveau/nouveau_drm.c | 11 +++
drivers/gpu/drm/radeon/radeon_atpx_handler.c | 3 +-
drivers/gpu/drm/radeon/radeon_connectors.c | 6 ++
drivers/gpu/drm/radeon/radeon_drv.c | 11 +++
drivers/gpu/vga/vga_switcheroo.c | 119 ++++++++++++++++++++++-
drivers/platform/x86/apple-gmux.c | 111 ++++++++++++++++-----
include/drm/drm_crtc.h | 2 +
include/linux/apple-gmux.h | 39 ++++++++
include/linux/vga_switcheroo.h | 36 ++++++-
16 files changed, 382 insertions(+), 33 deletions(-)
create mode 100644 include/linux/apple-gmux.h
--
1.8.5.2 (Apple Git-48)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2016-01-11 19:09 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 19:09 Lukas Wunner [this message]
2016-01-11 19:09 ` [PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't Lukas Wunner
2016-02-09 9:04 ` Daniel Vetter
2016-02-14 12:10 ` Lukas Wunner
2016-02-14 12:46 ` Daniel Vetter
2016-02-16 15:58 ` Lukas Wunner
2016-02-16 16:08 ` Daniel Vetter
2016-02-18 20:34 ` Lukas Wunner
2016-02-18 21:39 ` Daniel Vetter
2016-02-18 22:20 ` Lukas Wunner
2016-02-18 23:11 ` Daniel Vetter
2016-02-18 23:53 ` Deucher, Alexander
2016-01-11 19:09 ` [PATCH v5 06/12] drm/i915: Switch DDC when reading the EDID Lukas Wunner
2016-01-11 19:09 ` [PATCH v5 08/12] drm/radeon: " Lukas Wunner
2016-01-11 19:09 ` [PATCH v5 11/12] drm/nouveau: Defer probe if gmux is present but its driver isn't Lukas Wunner
2016-01-11 19:09 ` [PATCH v5 05/12] drm/edid: Switch DDC when reading the EDID Lukas Wunner
2016-01-11 19:09 ` [PATCH v5 09/12] apple-gmux: Add helper for presence detect Lukas Wunner
2016-01-11 19:09 ` [PATCH v5 01/12] vga_switcheroo: Add handler flags infrastructure Lukas Wunner
2016-01-11 19:09 ` [PATCH v5 12/12] drm/radeon: Defer probe if gmux is present but its driver isn't Lukas Wunner
2016-01-11 19:09 ` [PATCH v5 07/12] drm/nouveau: Switch DDC when reading the EDID Lukas Wunner
2016-01-11 19:09 ` [PATCH v5 03/12] apple-gmux: Track switch state Lukas Wunner
2016-01-11 19:09 ` [PATCH v5 02/12] vga_switcheroo: Add support for switching only the DDC Lukas Wunner
2016-01-11 19:09 ` [PATCH v5 04/12] apple-gmux: Add switch_ddc support Lukas Wunner
[not found] ` <cover.1452525860.git.lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-02-01 22:49 ` [PATCH v5 00/12] Enable GPU switching on pre-retina MacBook Pro Lukas Wunner
2016-02-02 1:10 ` Dave Airlie
2016-02-02 1:19 ` Dave Airlie
2016-02-02 15:03 ` Lukas Wunner
[not found] ` <20160201224944.GA12944-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-02-02 6:33 ` Pierre Moreau
2016-02-08 18:10 ` Darren Hart
[not found] ` <20160208181000.GL1779-Z5kFBHtJu+EzCVHREhWfF0EOCMrvLtNR@public.gmane.org>
2016-02-09 9:01 ` Daniel Vetter
[not found] ` <loom.20160304T170007-454@post.gmane.org>
2016-03-05 14:16 ` [Intel-gfx] [PATCH v5 00/12] Enable GPU switching on pre-retina?MacBook Pro Lukas Wunner
2016-03-05 16:31 ` Bastien Nocera
2016-03-09 23:30 ` Dave Airlie
2016-03-10 15:29 ` Bastien Nocera
2016-03-10 15:33 ` Bastien Nocera
2016-03-14 12:41 ` [Intel-gfx] " Lukas Wunner
2016-03-14 13:37 ` Bastien Nocera
2016-03-15 7:51 ` Daniel Vetter
2016-03-15 11:10 ` [Intel-gfx] " Dave Airlie
2016-03-15 11:55 ` Bastien Nocera
2016-04-05 16:59 ` Bastien Nocera
2016-04-05 17:43 ` Lukas Wunner
2016-03-05 17:28 ` [Intel-gfx] " Bastien Nocera
2016-03-05 18:10 ` Alex Deucher
2016-03-15 17:54 ` Lukas Wunner
2016-03-15 18:33 ` Alex Deucher
2016-03-15 20:41 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1452525860.git.lukas@wunner.de \
--to=lukas@wunner.de \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=bskeggs@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=dvhart@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=seth.forshee@canonical.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).