From: Georgiana Chelu <georgiana.chelu93@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Julia Lawall" <julia.lawall@lip6.fr>,
"Christian König" <christian.koenig@amd.com>,
dri-devel@lists.freedesktop.org
Subject: [PATCH v2 0/3] drm/amd/powerplay: Fix coccinelle and checkpatch issues
Date: Tue, 17 Oct 2017 23:22:06 +0300 [thread overview]
Message-ID: <cover.1508270576.git.georgiana.chelu93@gmail.com> (raw)
The first two patches fix coccinelle issues and the last patch fix
a checkpatch issue.
First patch: The return value of kzalloc does not need a cast because
the assignment operator will take care of this.
Second patch: The 'result' variable does not change its value until the
end of the function. Instead of using the variable, return its default value.
Third patch: Placing the constant on the right side will make the code easier
to read, as most of the people read from right to left.
Changes in v2:
* adjusted the subject prefix of the patches
* added the cocci script used to generate the patches
Georgiana Chelu (3):
drm/amd/powerplay: Don't cast kzalloc() return value
drm/amd/powerplay: Remove useless variable
drm/amd/powerplay: Place the constant on the right side of the test
.../amd/powerplay/hwmgr/vega10_processpptables.c | 35 ++++++++--------------
1 file changed, 13 insertions(+), 22 deletions(-)
--
2.11.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2017-10-17 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 20:22 Georgiana Chelu [this message]
2017-10-17 20:22 ` [PATCH v2 1/3] drm/amd/powerplay: Don't cast kzalloc() return value Georgiana Chelu
2017-10-17 20:22 ` [PATCH v2 2/3] drm/amd/powerplay: Remove useless variable Georgiana Chelu
2017-10-17 20:22 ` [PATCH v2 3/3] drm/amd/powerplay: Place the constant on the right side of the test Georgiana Chelu
2017-10-19 18:45 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1508270576.git.georgiana.chelu93@gmail.com \
--to=georgiana.chelu93@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=julia.lawall@lip6.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox