From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Ojha Subject: Re: [PATCH] gpu: v3d: fix a missing check of pm_runtime_get_sync Date: Mon, 25 Mar 2019 12:11:59 +0530 Message-ID: References: <20190324231602.2436-1-kjlu@umn.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0833495394==" Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5083B6E651 for ; Mon, 25 Mar 2019 06:42:10 +0000 (UTC) In-Reply-To: <20190324231602.2436-1-kjlu@umn.edu> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kangjie Lu Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, pakki001@umn.edu List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============0833495394== Content-Type: multipart/alternative; boundary="------------AA8871D15FBADDD7400A7574" Content-Language: en-US This is a multi-part message in MIME format. --------------AA8871D15FBADDD7400A7574 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 3/25/2019 4:46 AM, Kangjie Lu wrote: > pm_runtime_get_sync could fail and thus deserves a check. > > The patch adds such a check and return its error code upstream > if it indeed failed. > > Signed-off-by: Kangjie Lu Reviewed-by: Mukesh Ojha > Thanks. Mukesh > --- > drivers/gpu/drm/v3d/v3d_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c > index f0afcec72c34..99daad11fac2 100644 > --- a/drivers/gpu/drm/v3d/v3d_drv.c > +++ b/drivers/gpu/drm/v3d/v3d_drv.c > @@ -101,6 +101,8 @@ static int v3d_get_param_ioctl(struct drm_device *dev, void *data, > return -EINVAL; > > ret = pm_runtime_get_sync(v3d->dev); > + if (ret < 0) > + return ret; > if (args->param >= DRM_V3D_PARAM_V3D_CORE0_IDENT0 && > args->param <= DRM_V3D_PARAM_V3D_CORE0_IDENT2) { > args->value = V3D_CORE_READ(0, offset); --------------AA8871D15FBADDD7400A7574 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit


On 3/25/2019 4:46 AM, Kangjie Lu wrote:
pm_runtime_get_sync could fail and thus deserves a check.

The patch adds such a check and return its error code upstream
if it indeed failed.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>


Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Thanks.
Mukesh 

---
 drivers/gpu/drm/v3d/v3d_drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
index f0afcec72c34..99daad11fac2 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.c
+++ b/drivers/gpu/drm/v3d/v3d_drv.c
@@ -101,6 +101,8 @@ static int v3d_get_param_ioctl(struct drm_device *dev, void *data,
 			return -EINVAL;
 
 		ret = pm_runtime_get_sync(v3d->dev);
+		if (ret < 0)
+			return ret;
 		if (args->param >= DRM_V3D_PARAM_V3D_CORE0_IDENT0 &&
 		    args->param <= DRM_V3D_PARAM_V3D_CORE0_IDENT2) {
 			args->value = V3D_CORE_READ(0, offset);
--------------AA8871D15FBADDD7400A7574-- --===============0833495394== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0833495394==--