From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83C35C77B75 for ; Tue, 18 Apr 2023 18:06:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D69BA10E008; Tue, 18 Apr 2023 18:06:31 +0000 (UTC) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by gabe.freedesktop.org (Postfix) with ESMTPS id 051FB10E19A for ; Tue, 18 Apr 2023 18:06:29 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id v20-20020a05600c471400b003ed8826253aso1328622wmo.0 for ; Tue, 18 Apr 2023 11:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681841187; x=1684433187; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M30du5mqmgKvrK4t9HuuHfHAn0tr6/r+1Nuzg/l+qDw=; b=aCFj1du12kahKPc813jpwjYOXhr5FL7OFbCUYDvNavWqd0SK6oPxKM2dMsxip95R6a 4/03EZc+qS79tO4AruGAqF5tD8wrk3HvYkbuTFMlMKrtCPMvCRs/aNl1bpoJtldQ9HCN uOpyl6p8LXdvzbDD4gRNPiQqWyiIA3PDpjIc4XHRaTO4UmWif9MAa21W/tEpYWQFNa9C /fbzoBhh+Go6lC97jomf/vHXaJZ40IA+jKnTOkzJ19J1aZ9+dL29RbP7CZVrvTblP8U5 MQ2yQsE5upoSJ6/BkX3VSoEOQZ3TVAUDzsy63IsUV9Hn1Klx99gVdfbeVcn+mvLuwFZx Z8Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681841187; x=1684433187; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M30du5mqmgKvrK4t9HuuHfHAn0tr6/r+1Nuzg/l+qDw=; b=WzHLRGabQ8RQnJYboVMgdsgmHK6rCZ++CnwoAdw2ubktTU5/9pOvH1/AANwihP9aWB Yx98HTrIOclvp9z/IZwNtJbixv1aMR1DQT31hxQ+TwhHzn4P4J43ox7zAkVQ0bkes7cU DvP+LixAecqgTaFK3Kdq+0KtQGwEVDMFV9Bf+/xe0WsIsMLM3UxkVuhLGRHnPjWKrdhN 0AC+Hm6OxhdH6kmPuKtfP3VssT9+Y+aUGdYDRc9dHbY3/opTpvNpsUnRwxL3sYwh3HCZ kVq/mrA4veOvgpopUV/+UVna+pvPwZv+owCveG1CkpHX/En+VCX2W9jguP2o9CQEG9dm Prlg== X-Gm-Message-State: AAQBX9ctksqRpmcd4N2YrB4XiCGcFnN7l+SMsfBypYvbbsHCqyebWxni Uz9fl1eCddbukJbnSFRRswo= X-Google-Smtp-Source: AKy350affcKRPRnr6w7/Il+mJ10enRJnyp2KpkDOKh2W7Jw2M7JNi/J3H08mo2ox0CzAMVjiUCBrdg== X-Received: by 2002:a05:600c:218c:b0:3f1:6980:2cff with SMTP id e12-20020a05600c218c00b003f169802cffmr8162883wme.14.1681841186582; Tue, 18 Apr 2023 11:06:26 -0700 (PDT) Received: from [192.168.1.135] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id l11-20020a5d480b000000b002f2783ba25asm13649277wrq.65.2023.04.18.11.06.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 11:06:25 -0700 (PDT) Message-ID: Date: Tue, 18 Apr 2023 20:06:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] phy: mediatek/mt8195: fx mtk_hdmi_pll_calc() return code Content-Language: en-US To: Arnd Bergmann , Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , AngeloGioacchino Del Regno , Guillaume Ranquet References: <20230414075842.4006164-1-arnd@kernel.org> From: Matthias Brugger In-Reply-To: <20230414075842.4006164-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Arnd, On 14/04/2023 09:58, Arnd Bergmann wrote: > From: Arnd Bergmann > > The newly added function returns an uninitialized variable: > > drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized] > > Wire it up to the return code of the function called just before, > assuming that this was the intention originally. > > Fixes: 45810d486bb4 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195") > Signed-off-by: Arnd Bergmann > --- > drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c > index abfc077fb0a8..c8e540665fcb 100644 > --- a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c > +++ b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c > @@ -292,7 +292,7 @@ static int mtk_hdmi_pll_calc(struct mtk_hdmi_phy *hdmi_phy, struct clk_hw *hw, > if (!(digital_div <= 32 && digital_div >= 1)) > return -EINVAL; > > - mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low, > + ret = mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low, > PLL_FBKDIV_HS3, posdiv1, posdiv2, txprediv, > txposdiv, digital_div); > if (ret) I think this is the third patch that fixes this :) Your solution look quite similar to this one: 20230413-fixes-for-mt8195-hdmi-phy-v2-1-bbad62e64321@baylibre.com Regards, Mmatthias