From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90780C10F27 for ; Mon, 9 Mar 2020 08:14:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 679FA20728 for ; Mon, 9 Mar 2020 08:14:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="E16JOUrN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 679FA20728 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 825136E32E; Mon, 9 Mar 2020 08:13:44 +0000 (UTC) Received: from mail27.static.mailgun.info (mail27.static.mailgun.info [104.130.122.27]) by gabe.freedesktop.org (Postfix) with ESMTPS id 06A7289FC3 for ; Mon, 9 Mar 2020 06:27:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1583735275; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=qy2xY/dZyMiOpfQufKuG+wtf2moSQrlU/AD39JqMigc=; b=E16JOUrNvr4BSUMLbZHb3jlO4SfnUpLY4RI6CIkuG5skPMOkr80cHnAHTtQ3CvsBz5krkaR4 uwDjVR22t7iRJOOBk5UhAjUcYdZl8I468ZSen8TUevvSzYI4J1gXNBKmekro4efFjOALKtZC 0qyHuAEbCbwuYOlD/eKrOuxbNMg= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e65e1e6.7fc043af7c38-smtp-out-n01; Mon, 09 Mar 2020 06:27:50 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B4BACC44788; Mon, 9 Mar 2020 06:27:49 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: kgunda) by smtp.codeaurora.org (Postfix) with ESMTPSA id E94B8C433D2; Mon, 9 Mar 2020 06:27:48 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 09 Mar 2020 11:57:48 +0530 From: kgunda@codeaurora.org To: Bjorn Andersson Subject: Re: [PATCH V1 2/2] backlight: qcom-wled: Add support for WLED5 peripheral in PM8150L In-Reply-To: <20200308214748.GL1094083@builder> References: <1583153739-19170-1-git-send-email-kgunda@codeaurora.org> <1583153739-19170-3-git-send-email-kgunda@codeaurora.org> <20200308214748.GL1094083@builder> Message-ID: X-Sender: kgunda@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-Mailman-Approved-At: Mon, 09 Mar 2020 08:13:37 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, daniel.thompson@linaro.org, b.zolnierkie@samsung.com, jingoohan1@gmail.com, Andy Gross , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, robh+dt@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, linux-arm-msm@vger.kernel.org, lee.jones@linaro.org, linux-arm-msm-owner@vger.kernel.org, linux-leds@vger.kernel.org, Dan Murphy Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-03-09 03:17, Bjorn Andersson wrote: > On Mon 02 Mar 04:55 PST 2020, Kiran Gunda wrote: >> diff --git a/drivers/video/backlight/qcom-wled.c >> b/drivers/video/backlight/qcom-wled.c > [..] >> @@ -147,14 +187,39 @@ struct wled { >> u32 max_brightness; >> u32 short_count; >> u32 auto_detect_count; >> + u32 version; >> bool disabled_by_short; >> bool has_short_detect; >> + bool cabc_disabled; >> int short_irq; >> int ovp_irq; >> >> struct wled_config cfg; >> struct delayed_work ovp_work; >> int (*wled_set_brightness)(struct wled *wled, u16 brightness); >> + int (*cabc_config)(struct wled *wled, bool enable); >> + int (*wled_sync_toggle)(struct wled *wled); > > Please split this patch in one that adds these and breaks out the wled3 > support, and then a second patch that adds wled5. > Sure. Will make this change in the next post. >> +}; >> + > [..] >> +static int wled5_set_brightness(struct wled *wled, u16 brightness) >> +{ >> + int rc, offset; >> + u16 low_limit = wled->max_brightness * 1 / 1000; >> + u8 v[2], brightness_msb_mask; >> + >> + /* WLED5's lower limit is 0.1% */ >> + if (brightness > 0 && brightness < low_limit) >> + brightness = low_limit; >> + >> + brightness_msb_mask = 0xf; >> + if (wled->max_brightness == WLED5_SINK_REG_BRIGHT_MAX_15B) >> + brightness_msb_mask = 0x7f; > > Why not just brightness &= wled->max_brightness? But given that it > seems > like the framework ensures that brightness <= max_brightness, why not > skip this altogether? > Okay. I will modify the code to remove the min/max, low_limit checks in next post. >> + >> + v[0] = brightness & 0xff; >> + v[1] = (brightness >> 8) & brightness_msb_mask; >> + >> + offset = wled5_brightness_reg[wled->cfg.mod_sel]; >> + rc = regmap_bulk_write(wled->regmap, wled->sink_addr + offset, >> + v, 2); >> + return rc; >> +} >> + >> static int wled4_set_brightness(struct wled *wled, u16 brightness) >> { >> int rc, i; >> @@ -237,7 +325,28 @@ static int wled_module_enable(struct wled *wled, >> int val) >> return 0; >> } >> >> -static int wled_sync_toggle(struct wled *wled) >> +static int wled5_sync_toggle(struct wled *wled) >> +{ >> + int rc; >> + u8 val; >> + >> + val = (wled->cfg.mod_sel == MOD_A) ? WLED5_SINK_REG_SYNC_MOD_A_BIT : >> + WLED5_SINK_REG_SYNC_MOD_B_BIT; >> + rc = regmap_update_bits(wled->regmap, >> + wled->sink_addr + WLED5_SINK_REG_MOD_SYNC_BIT, >> + WLED5_SINK_REG_SYNC_MASK, val); >> + if (rc < 0) >> + return rc; >> + >> + val = 0; > > Just plug 0 in the function call. > Sure. Will do it in next post. >> + rc = regmap_update_bits(wled->regmap, >> + wled->sink_addr + WLED5_SINK_REG_MOD_SYNC_BIT, >> + WLED5_SINK_REG_SYNC_MASK, val); >> + >> + return rc; > > And return regmap_update_bits(...); > Sure. Will do it in next post. >> +} >> + > > Regards, > Bjorn _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel