From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F353C2D0C0 for ; Sat, 21 Dec 2019 14:04:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EE5C2072B for ; Sat, 21 Dec 2019 14:04:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EE5C2072B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C68B06E082; Sat, 21 Dec 2019 14:04:42 +0000 (UTC) X-Greylist: delayed 462 seconds by postgrey-1.36 at gabe; Sat, 21 Dec 2019 14:04:41 UTC Received: from smtprelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7ACEF6E082 for ; Sat, 21 Dec 2019 14:04:41 +0000 (UTC) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave04.hostedemail.com (Postfix) with ESMTP id 1640A1801C4ED for ; Sat, 21 Dec 2019 13:57:00 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id EC9741801BE94; Sat, 21 Dec 2019 13:56:58 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: cable34_59e6e64a1c804 X-Filterd-Recvd-Size: 1921 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Sat, 21 Dec 2019 13:56:57 +0000 (UTC) Message-ID: Subject: Re: [PATCH v1 6/8] drm/print: add drm_dev_* logging functions From: Joe Perches To: Sam Ravnborg , dri-devel@lists.freedesktop.org, Jani Nikula , Daniel Vetter Date: Sat, 21 Dec 2019 05:56:17 -0800 In-Reply-To: <20191221095553.13332-7-sam@ravnborg.org> References: <20191221095553.13332-1-sam@ravnborg.org> <20191221095553.13332-7-sam@ravnborg.org> User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, 2019-12-21 at 10:55 +0100, Sam Ravnborg wrote: > There are a lot of cases where we have a device * but no drm_device *. > Add drm_dev_* variants of the logging functions to cover these cases. [] > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h [] > @@ -468,6 +511,60 @@ static inline bool drm_debug_enabled(enum drm_debug_category category) > #define drm_dbg_dp(drm, fmt, ...) \ > __drm_cat_printk((drm), DRM_UT_DP, fmt, ##__VA_ARGS__) > > +/* struct device based logging. */ > +#define __drm_dev_printk(dev, level, type, fmt, ...) \ > + dev_##level##type(dev, "[drm] " fmt, ##__VA_ARGS__) > + > +#define __drm_dev_cat_printk(dev, cat, type, fmt, ...) \ > +({ \ > + if (drm_debug_enabled(cat)) \ > + dev_dbg##type((dev), "[drm] " fmt, ##__VA_ARGS__); \ trivia: The parentheses around dev aren't necessary. > +}) > + > +#define drm_dev_info(dev, fmt, ...) \ > + __drm_dev_printk((dev), info,, fmt, ##__VA_ARGS__) etc... _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel