From: Thomas Zimmermann <tzimmermann@suse.de>
To: chuguangqing <chuguangqing@inspur.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] gpu: drm: fix compilation errors in drm_vram_helper
Date: Mon, 11 Aug 2025 14:48:02 +0200 [thread overview]
Message-ID: <d20ea5f0-737e-48a7-8311-fba8474bfd7a@suse.de> (raw)
In-Reply-To: <20250729060728.82402-1-chuguangqing@inspur.com>
Hi
Am 29.07.25 um 08:07 schrieb chuguangqing:
> We encountered the following errors while compiling drm_vram_helper.ko
>
> ERROR: modpost: "drm_gem_ttm_print_info" [drivers/gpu/drm/drm_vram_helper.ko] undefined!
> ERROR: modpost: "drm_gem_ttm_mmap" [drivers/gpu/drm/drm_vram_helper.ko] undefined!
>
> The functions drm_gem_ttm_mmap and drm_gem_ttm_print_info are defined in drm_gem_ttm_helper.c. This patch adds drm_gem_ttm_helper.o to DRM_VRAM_HELPER to resolve the undefined symbol errors.
You need to select DRM_TTM_HELPER for your driver.
Best regards
Thomas
>
> Signed-off-by: chuguangqing <chuguangqing@inspur.com>
> ---
> drivers/gpu/drm/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index 4dafbdc8f86a..abbe32ddf6d0 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -125,7 +125,7 @@ drm_suballoc_helper-y := drm_suballoc.o
> obj-$(CONFIG_DRM_SUBALLOC_HELPER) += drm_suballoc_helper.o
>
> drm_vram_helper-y := drm_gem_vram_helper.o
> -obj-$(CONFIG_DRM_VRAM_HELPER) += drm_vram_helper.o
> +obj-$(CONFIG_DRM_VRAM_HELPER) += drm_vram_helper.o drm_gem_ttm_helper.o
>
> drm_ttm_helper-y := drm_gem_ttm_helper.o
> drm_ttm_helper-$(CONFIG_DRM_FBDEV_EMULATION) += drm_fbdev_ttm.o
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
next prev parent reply other threads:[~2025-08-11 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 6:07 [PATCH 1/1] gpu: drm: fix compilation errors in drm_vram_helper chuguangqing
2025-07-30 2:19 ` kernel test robot
2025-07-30 7:29 ` [PATCH v2 " chuguangqing
2025-08-11 12:48 ` Thomas Zimmermann [this message]
[not found] <202507300646.kTchyjvh-lkp@intel.com>
2025-07-30 7:09 ` [PATCH " chuguangqing
-- strict thread matches above, loose matches on Subject: below --
2025-08-13 1:38 Gary Chu(楚光庆)
2025-08-13 6:58 ` Thomas Zimmermann
2025-08-13 7:22 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d20ea5f0-737e-48a7-8311-fba8474bfd7a@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=chuguangqing@inspur.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).