From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: dri-devel@lists.freedesktop.org,
Nayan Deshmukh <nayan26deshmukh@gmail.com>,
"Grodzovsky, Andrey" <Andrey.Grodzovsky@amd.com>
Subject: Re: [PATCH] drm/scheduler: Remove entity->rq NULL check
Date: Mon, 6 Aug 2018 16:13:19 +0200 [thread overview]
Message-ID: <d2948455-3a23-b651-c9e3-49841d05e1a4@gmail.com> (raw)
In-Reply-To: <20180803110810.2055-1-christian.koenig@amd.com>
Ping. Any objections to that?
Christian.
Am 03.08.2018 um 13:08 schrieb Christian König:
> That is superflous now.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/scheduler/gpu_scheduler.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c
> index 85908c7f913e..65078dd3c82c 100644
> --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c
> +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c
> @@ -590,11 +590,6 @@ void drm_sched_entity_push_job(struct drm_sched_job *sched_job,
> if (first) {
> /* Add the entity to the run queue */
> spin_lock(&entity->rq_lock);
> - if (!entity->rq) {
> - DRM_ERROR("Trying to push to a killed entity\n");
> - spin_unlock(&entity->rq_lock);
> - return;
> - }
> drm_sched_rq_add_entity(entity->rq, entity);
> spin_unlock(&entity->rq_lock);
> drm_sched_wakeup(entity->rq->sched);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-08-06 14:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 11:08 [PATCH] drm/scheduler: Remove entity->rq NULL check Christian König
2018-08-06 14:13 ` Christian König [this message]
2018-08-06 14:18 ` Nayan Deshmukh
2018-08-09 19:49 ` Andrey Grodzovsky
2018-08-10 13:27 ` Christian König
2018-08-10 13:44 ` Andrey Grodzovsky
2018-08-13 16:43 ` Andrey Grodzovsky
2018-08-14 7:05 ` Christian König
2018-08-14 15:17 ` Andrey Grodzovsky
2018-08-14 15:26 ` Christian König
2018-08-14 16:32 ` Andrey Grodzovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2948455-3a23-b651-c9e3-49841d05e1a4@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Andrey.Grodzovsky@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=nayan26deshmukh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).