From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harry Wentland Subject: Re: [PATCH] drm/amd/display: Remove extra pairs of parentheses in dce_calcs.c Date: Wed, 7 Feb 2018 15:48:19 -0500 Message-ID: References: <20180207194928.93869-1-mka@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180207194928.93869-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Matthias Kaehlcke , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Zhou , David Airlie , Tony Cheng , Dmytro Laktyushkin , Joshua Aberback Cc: Craig Bergstrom , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Justin TerAvest , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Guenter Roeck List-Id: dri-devel@lists.freedesktop.org T24gMjAxOC0wMi0wNyAwMjo0OSBQTSwgTWF0dGhpYXMgS2FlaGxja2Ugd3JvdGU6Cj4gVGhlIGRv dWJsZSBwYXJlbnRoZXNlcyBhcmUgbm90IG5lZWRlZC4gUmVtb3ZpbmcgdGhlbSBmaXhlcyBtdWx0 aXBsZQo+IHdhcm5pbmdzIGxpa2UgdGhpcyB3aGVuIGJ1aWxkaW5nIHdpdGggY2xhbmc6Cj4gCj4g ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlzcGxheS9kYy9jYWxjcy9kY2VfY2FsY3Mu Yzo2MTc6NDI6Cj4gICBlcnJvcjogZXF1YWxpdHkgY29tcGFyaXNvbiB3aXRoIGV4dHJhbmVvdXMg cGFyZW50aGVzZXMKPiAgICAgWy1XZXJyb3IsLVdwYXJlbnRoZXNlcy1lcXVhbGl0eV0KPiAgIGlm ICgoZGF0YS0+Z3JhcGhpY3NfbWljcm9fdGlsZV9tb2RlID09IGJ3X2RlZl9yb3RhdGVkX21pY3Jv X3RpbGluZykpIHsKPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYXR0aGlhcyBLYWVobGNrZSA8bWthQGNo cm9taXVtLm9yZz4KClRoYW5rcy4KUmV2aWV3ZWQtYnk6IEhhcnJ5IFdlbnRsYW5kIDxoYXJyeS53 ZW50bGFuZEBhbWQuY29tPgoKSGFycnkKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvZGlz cGxheS9kYy9jYWxjcy9kY2VfY2FsY3MuYyB8IDIyICsrKysrKysrKysrLS0tLS0tLS0tLS0KPiAg MSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvY2FsY3MvZGNlX2NhbGNz LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvY2FsY3MvZGNlX2NhbGNzLmMKPiBp bmRleCAyZTExZmFjMmE2M2QuLmJiMDNhOWM2NGQ1YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vYW1kL2Rpc3BsYXkvZGMvY2FsY3MvZGNlX2NhbGNzLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2Rpc3BsYXkvZGMvY2FsY3MvZGNlX2NhbGNzLmMKPiBAQCAtNjIzLDcgKzYyMyw3 IEBAIHN0YXRpYyB2b2lkIGNhbGN1bGF0ZV9iYW5kd2lkdGgoCj4gIAkJCQl9Cj4gIAkJCQllbHNl IHsKPiAgCQkJCQkvKmdyYXBoaWNzIHBvcnRyYWl0IHRpbGluZyBtb2RlKi8KPiAtCQkJCQlpZiAo KGRhdGEtPmdyYXBoaWNzX21pY3JvX3RpbGVfbW9kZSA9PSBid19kZWZfcm90YXRlZF9taWNyb190 aWxpbmcpKSB7Cj4gKwkJCQkJaWYgKGRhdGEtPmdyYXBoaWNzX21pY3JvX3RpbGVfbW9kZSA9PSBi d19kZWZfcm90YXRlZF9taWNyb190aWxpbmcpIHsKPiAgCQkJCQkJZGF0YS0+b3J0aG9nb25hbF9y b3RhdGlvbltpXSA9IDA7Cj4gIAkJCQkJfQo+ICAJCQkJCWVsc2Ugewo+IEBAIC02MzQsNyArNjM0 LDcgQEAgc3RhdGljIHZvaWQgY2FsY3VsYXRlX2JhbmR3aWR0aCgKPiAgCQkJZWxzZSB7Cj4gIAkJ CQlpZiAoKGkgPCA0KSkgewo+ICAJCQkJCS8qdW5kZXJsYXkgbGFuZHNjYXBlIHRpbGluZyBtb2Rl IGlzIG9ubHkgc3VwcG9ydGVkKi8KPiAtCQkJCQlpZiAoKGRhdGEtPnVuZGVybGF5X21pY3JvX3Rp bGVfbW9kZSA9PSBid19kZWZfZGlzcGxheV9taWNyb190aWxpbmcpKSB7Cj4gKwkJCQkJaWYgKGRh dGEtPnVuZGVybGF5X21pY3JvX3RpbGVfbW9kZSA9PSBid19kZWZfZGlzcGxheV9taWNyb190aWxp bmcpIHsKPiAgCQkJCQkJZGF0YS0+b3J0aG9nb25hbF9yb3RhdGlvbltpXSA9IDA7Cj4gIAkJCQkJ fQo+ICAJCQkJCWVsc2Ugewo+IEBAIC02NDMsNyArNjQzLDcgQEAgc3RhdGljIHZvaWQgY2FsY3Vs YXRlX2JhbmR3aWR0aCgKPiAgCQkJCX0KPiAgCQkJCWVsc2Ugewo+ICAJCQkJCS8qZ3JhcGhpY3Mg bGFuZHNjYXBlIHRpbGluZyBtb2RlKi8KPiAtCQkJCQlpZiAoKGRhdGEtPmdyYXBoaWNzX21pY3Jv X3RpbGVfbW9kZSA9PSBid19kZWZfZGlzcGxheV9taWNyb190aWxpbmcpKSB7Cj4gKwkJCQkJaWYg KGRhdGEtPmdyYXBoaWNzX21pY3JvX3RpbGVfbW9kZSA9PSBid19kZWZfZGlzcGxheV9taWNyb190 aWxpbmcpIHsKPiAgCQkJCQkJZGF0YS0+b3J0aG9nb25hbF9yb3RhdGlvbltpXSA9IDA7Cj4gIAkJ CQkJfQo+ICAJCQkJCWVsc2Ugewo+IEBAIC05NDcsMTQgKzk0NywxNCBAQCBzdGF0aWMgdm9pZCBj YWxjdWxhdGVfYmFuZHdpZHRoKAo+ICAJfQo+ICAJZm9yIChpID0gMDsgaSA8PSBtYXhpbXVtX251 bWJlcl9vZl9zdXJmYWNlcyAtIDE7IGkrKykgewo+ICAJCWlmIChkYXRhLT5lbmFibGVbaV0pIHsK PiAtCQkJaWYgKChkYXRhLT5udW1iZXJfb2ZfZGlzcGxheXMgPT0gMSAmJiBkYXRhLT5udW1iZXJf b2ZfdW5kZXJsYXlfc3VyZmFjZXMgPT0gMCkpIHsKPiArCQkJaWYgKGRhdGEtPm51bWJlcl9vZl9k aXNwbGF5cyA9PSAxICYmIGRhdGEtPm51bWJlcl9vZl91bmRlcmxheV9zdXJmYWNlcyA9PSAwKSB7 Cj4gIAkJCQkvKnNldCBtYXhpbXVtIGNodW5rIGxpbWl0IGlmIG9ubHkgb25lIGdyYXBoaWMgcGlw ZSBpcyBlbmFibGVkKi8KPiAgCQkJCWRhdGEtPm91dHN0YW5kaW5nX2NodW5rX3JlcXVlc3RfbGlt aXRbaV0gPSBid19pbnRfdG9fZml4ZWQoMTI3KTsKPiAgCQkJfQo+ICAJCQllbHNlIHsKPiAgCQkJ CWRhdGEtPm91dHN0YW5kaW5nX2NodW5rX3JlcXVlc3RfbGltaXRbaV0gPSBid19jZWlsMihid19k aXYoZGF0YS0+YWRqdXN0ZWRfZGF0YV9idWZmZXJfc2l6ZVtpXSwgZGF0YS0+cGlwZV9jaHVua19z aXplX2luX2J5dGVzW2ldKSwgYndfaW50X3RvX2ZpeGVkKDEpKTsKPiAgCQkJCS8qY2xhbXAgbWF4 aW11bSBjaHVuayBsaW1pdCBpbiB0aGUgZ3JhcGhpYyBkaXNwbGF5IHBpcGUqLwo+IC0JCQkJaWYg KChpID49IDQpKSB7Cj4gKwkJCQlpZiAoaSA+PSA0KSB7Cj4gIAkJCQkJZGF0YS0+b3V0c3RhbmRp bmdfY2h1bmtfcmVxdWVzdF9saW1pdFtpXSA9IGJ3X21heDIoYndfaW50X3RvX2ZpeGVkKDEyNyks IGRhdGEtPm91dHN0YW5kaW5nX2NodW5rX3JlcXVlc3RfbGltaXRbaV0pOwo+ICAJCQkJfQo+ICAJ CQl9Cj4gQEAgLTEzMzcsNyArMTMzNyw3IEBAIHN0YXRpYyB2b2lkIGNhbGN1bGF0ZV9iYW5kd2lk dGgoCj4gIAkvKmlmIHN0dXR0ZXIgYW5kIGRyYW0gY2xvY2sgc3RhdGUgY2hhbmdlIGFyZSBnYXRl ZCBiZWZvcmUgY3Vyc29yIHRoZW4gdGhlIGN1cnNvciBsYXRlbmN5IGhpZGluZyBkb2VzIG5vdCBs aW1pdCBzdHV0dGVyIG9yIGRyYW0gY2xvY2sgc3RhdGUgY2hhbmdlKi8KPiAgCWZvciAoaSA9IDA7 IGkgPD0gbWF4aW11bV9udW1iZXJfb2Zfc3VyZmFjZXMgLSAxOyBpKyspIHsKPiAgCQlpZiAoZGF0 YS0+ZW5hYmxlW2ldKSB7Cj4gLQkJCWlmICgoZGNlaXAtPmdyYXBoaWNzX2xiX25vZG93bnNjYWxp bmdfbXVsdGlfbGluZV9wcmVmZXRjaGluZyA9PSAxKSkgewo+ICsJCQlpZiAoZGNlaXAtPmdyYXBo aWNzX2xiX25vZG93bnNjYWxpbmdfbXVsdGlfbGluZV9wcmVmZXRjaGluZyA9PSAxKSB7Cj4gIAkJ CQlkYXRhLT5tYXhpbXVtX2xhdGVuY3lfaGlkaW5nW2ldID0gYndfYWRkKGRhdGEtPm1pbmltdW1f bGF0ZW5jeV9oaWRpbmdbaV0sIGJ3X211bChid19mcmNfdG9fZml4ZWQoOCwgMTApLCBkYXRhLT50 b3RhbF9kbWlmbWNfdXJnZW50X2xhdGVuY3kpKTsKPiAgCQkJfQo+ICAJCQllbHNlIHsKPiBAQCAt MTM5Niw3ICsxMzk2LDcgQEAgc3RhdGljIHZvaWQgY2FsY3VsYXRlX2JhbmR3aWR0aCgKPiAgCX0K PiAgCS8qZGV0ZXJtaW5lIHRoZSBudW1iZXIgb2YgZGlzcGxheXMgd2l0aCBtYXJnaW4gdG8gc3dp dGNoIGluIHRoZSB2X2FjdGl2ZSByZWdpb24qLwo+ICAJZm9yIChrID0gMDsgayA8PSBtYXhpbXVt X251bWJlcl9vZl9zdXJmYWNlcyAtIDE7IGsrKykgewo+IC0JCWlmICgoZGF0YS0+ZW5hYmxlW2td ID09IDEgJiYgZGF0YS0+ZGlzcGxheV9wc3RhdGVfY2hhbmdlX2VuYWJsZVtrXSA9PSAxKSkgewo+ ICsJCWlmIChkYXRhLT5lbmFibGVba10gPT0gMSAmJiBkYXRhLT5kaXNwbGF5X3BzdGF0ZV9jaGFu Z2VfZW5hYmxlW2tdID09IDEpIHsKPiAgCQkJbnVtYmVyX29mX2Rpc3BsYXlzX2VuYWJsZWRfd2l0 aF9tYXJnaW4gPSBudW1iZXJfb2ZfZGlzcGxheXNfZW5hYmxlZF93aXRoX21hcmdpbiArIDE7Cj4g IAkJfQo+ICAJfQo+IEBAIC0xNDQyLDcgKzE0NDIsNyBAQCBzdGF0aWMgdm9pZCBjYWxjdWxhdGVf YmFuZHdpZHRoKAo+ICAJCWRhdGEtPm5icF9zdGF0ZV9jaGFuZ2VfZW5hYmxlID0gYndfZGVmX25v Owo+ICAJfQo+ICAJLypkcmFtIGNsb2NrIGNoYW5nZSBpcyBwb3NzaWJsZSBvbmx5IGluIHZibGFu ayBpZiBhbGwgZGlzcGxheXMgYXJlIGFsaWduZWQgYW5kIGhhdmUgbm8gbWFyZ2luKi8KPiAtCWlm ICgobnVtYmVyX29mX2FsaWduZWRfZGlzcGxheXNfd2l0aF9ub19tYXJnaW4gPT0gbnVtYmVyX29m X2Rpc3BsYXlzX2VuYWJsZWQpKSB7Cj4gKwlpZiAobnVtYmVyX29mX2FsaWduZWRfZGlzcGxheXNf d2l0aF9ub19tYXJnaW4gPT0gbnVtYmVyX29mX2Rpc3BsYXlzX2VuYWJsZWQpIHsKPiAgCQluYnBf c3RhdGVfY2hhbmdlX2VuYWJsZV9ibGFuayA9IGJ3X2RlZl95ZXM7Cj4gIAl9Cj4gIAllbHNlIHsK PiBAQCAtMTQ3MCw3ICsxNDcwLDcgQEAgc3RhdGljIHZvaWQgY2FsY3VsYXRlX2JhbmR3aWR0aCgK PiAgCQl9Cj4gIAl9Cj4gIAkvKmNvbXB1dGUgbWluaW11bSB0aW1lIHRvIHJlYWQgb25lIGNodW5r IGZyb20gdGhlIGRtaWYgYnVmZmVyKi8KPiAtCWlmICgobnVtYmVyX29mX2Rpc3BsYXlzX2VuYWJs ZWQgPiAyKSkgewo+ICsJaWYgKG51bWJlcl9vZl9kaXNwbGF5c19lbmFibGVkID4gMikgewo+ICAJ CWRhdGEtPmNodW5rX3JlcXVlc3RfZGVsYXkgPSAwOwo+ICAJfQo+ICAJZWxzZSB7Cj4gQEAgLTE4 MDQsNyArMTgwNCw3IEBAIHN0YXRpYyB2b2lkIGNhbGN1bGF0ZV9iYW5kd2lkdGgoCj4gIAkJCQlk YXRhLT5zdHV0dGVyX2V4aXRfd2F0ZXJtYXJrW2ldID0gYndfYWRkKGJ3X3N1Yih2Ymlvcy0+c3R1 dHRlcl9zZWxmX3JlZnJlc2hfZXhpdF9sYXRlbmN5LCBkYXRhLT50b3RhbF9kbWlmbWNfdXJnZW50 X2xhdGVuY3kpLCBkYXRhLT51cmdlbnRfd2F0ZXJtYXJrW2ldKTsKPiAgCQkJCWRhdGEtPnN0dXR0 ZXJfZW50cnlfd2F0ZXJtYXJrW2ldID0gYndfYWRkKGJ3X3N1Yihid19hZGQodmJpb3MtPnN0dXR0 ZXJfc2VsZl9yZWZyZXNoX2V4aXRfbGF0ZW5jeSwgdmJpb3MtPnN0dXR0ZXJfc2VsZl9yZWZyZXNo X2VudHJ5X2xhdGVuY3kpLCBkYXRhLT50b3RhbF9kbWlmbWNfdXJnZW50X2xhdGVuY3kpLCBkYXRh LT51cmdlbnRfd2F0ZXJtYXJrW2ldKTsKPiAgCQkJCS8qdW5jb25kaXRpb25hbGx5IHJlbW92ZSBi bGFjayBvdXQgdGltZSBmcm9tIHRoZSBuYiBwX3N0YXRlIHdhdGVybWFyayovCj4gLQkJCQlpZiAo KGRhdGEtPmRpc3BsYXlfcHN0YXRlX2NoYW5nZV9lbmFibGVbaV0gPT0gMSkpIHsKPiArCQkJCWlm IChkYXRhLT5kaXNwbGF5X3BzdGF0ZV9jaGFuZ2VfZW5hYmxlW2ldID09IDEpIHsKPiAgCQkJCQlk YXRhLT5uYnBfc3RhdGVfY2hhbmdlX3dhdGVybWFya1tpXSA9IGJ3X2FkZChid19hZGQodmJpb3Mt Pm5icF9zdGF0ZV9jaGFuZ2VfbGF0ZW5jeSwgZGF0YS0+ZG1pZl9idXJzdF90aW1lW2RhdGEtPnlf Y2xrX2xldmVsXVtkYXRhLT5zY2xrX2xldmVsXSksIGJ3X21heDIoZGF0YS0+bGluZV9zb3VyY2Vf cGl4ZWxzX3RyYW5zZmVyX3RpbWUsIGRhdGEtPmRyYW1fc3BlZWRfY2hhbmdlX2xpbmVfc291cmNl X3RyYW5zZmVyX3RpbWVbaV1bZGF0YS0+eV9jbGtfbGV2ZWxdW2RhdGEtPnNjbGtfbGV2ZWxdKSk7 Cj4gIAkJCQl9Cj4gIAkJCQllbHNlIHsKPiBAQCAtMTgxNiw3ICsxODE2LDcgQEAgc3RhdGljIHZv aWQgY2FsY3VsYXRlX2JhbmR3aWR0aCgKPiAgCQkJCWRhdGEtPnVyZ2VudF93YXRlcm1hcmtbaV0g PSBid19hZGQoYndfYWRkKGJ3X2FkZChid19hZGQoYndfYWRkKHZiaW9zLT5tY2lmd3JtY191cmdl bnRfbGF0ZW5jeSwgZGF0YS0+bWNpZndyX2J1cnN0X3RpbWVbZGF0YS0+eV9jbGtfbGV2ZWxdW2Rh dGEtPnNjbGtfbGV2ZWxdKSwgYndfbWF4MihkYXRhLT5saW5lX3NvdXJjZV9waXhlbHNfdHJhbnNm ZXJfdGltZSwgZGF0YS0+bGluZV9zb3VyY2VfdHJhbnNmZXJfdGltZVtpXVtkYXRhLT55X2Nsa19s ZXZlbF1bZGF0YS0+c2Nsa19sZXZlbF0pKSwgdmJpb3MtPmJsYWNrb3V0X2R1cmF0aW9uKSwgZGF0 YS0+Y2h1bmtfcmVxdWVzdF90aW1lKSwgZGF0YS0+Y3Vyc29yX3JlcXVlc3RfdGltZSk7Cj4gIAkJ CQlkYXRhLT5zdHV0dGVyX2V4aXRfd2F0ZXJtYXJrW2ldID0gYndfaW50X3RvX2ZpeGVkKDApOwo+ ICAJCQkJZGF0YS0+c3R1dHRlcl9lbnRyeV93YXRlcm1hcmtbaV0gPSBid19pbnRfdG9fZml4ZWQo MCk7Cj4gLQkJCQlpZiAoKGRhdGEtPmRpc3BsYXlfcHN0YXRlX2NoYW5nZV9lbmFibGVbaV0gPT0g MSkpIHsKPiArCQkJCWlmIChkYXRhLT5kaXNwbGF5X3BzdGF0ZV9jaGFuZ2VfZW5hYmxlW2ldID09 IDEpIHsKPiAgCQkJCQlkYXRhLT5uYnBfc3RhdGVfY2hhbmdlX3dhdGVybWFya1tpXSA9IGJ3X2Fk ZChid19hZGQodmJpb3MtPm5icF9zdGF0ZV9jaGFuZ2VfbGF0ZW5jeSwgZGF0YS0+bWNpZndyX2J1 cnN0X3RpbWVbZGF0YS0+eV9jbGtfbGV2ZWxdW2RhdGEtPnNjbGtfbGV2ZWxdKSwgYndfbWF4Mihk YXRhLT5saW5lX3NvdXJjZV9waXhlbHNfdHJhbnNmZXJfdGltZSwgZGF0YS0+ZHJhbV9zcGVlZF9j aGFuZ2VfbGluZV9zb3VyY2VfdHJhbnNmZXJfdGltZVtpXVtkYXRhLT55X2Nsa19sZXZlbF1bZGF0 YS0+c2Nsa19sZXZlbF0pKTsKPiAgCQkJCX0KPiAgCQkJCWVsc2Ugewo+IApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAph bWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK