From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A763C433DB for ; Mon, 22 Feb 2021 12:28:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCF6760C3E for ; Mon, 22 Feb 2021 12:28:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCF6760C3E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vaga.pv.it Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1898F89361; Mon, 22 Feb 2021 12:28:52 +0000 (UTC) X-Greylist: delayed 505 seconds by postgrey-1.36 at gabe; Mon, 22 Feb 2021 12:22:04 UTC Received: from mx.kolabnow.com (mx.kolabnow.com [95.128.36.40]) by gabe.freedesktop.org (Postfix) with ESMTPS id D7FC56E4CF for ; Mon, 22 Feb 2021 12:22:04 +0000 (UTC) Received: from localhost (unknown [127.0.0.1]) by ext-mx-out001.mykolab.com (Postfix) with ESMTP id 04947AAD; Mon, 22 Feb 2021 13:13:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= message-id:references:in-reply-to:subject:subject:from:from:date :date:content-transfer-encoding:content-type:content-type :mime-version:received:received:received; s=dkim20160331; t= 1613996015; x=1615810416; bh=su6lN/wfDzpqvIMHiCSOa35nXcRiEiL67qu Y39rTeko=; b=bM0Y5l8y5eb5/KPO2JNE8jFtVjv6yO7e2++iJoOYhuf0nbqsWPU lpLCwWbqoUAQa2xzqBhJTanYdzMxcEFlm04tWblVBSTwH+RatT44DmjjNpgKzipQ SWwTK+lhtFB1FkRL9m+7aNNnGrJcjqQeW1aQNdeLqHM89QRAqUxPw/bolSmzWf+x 6JcwYfBjUBTJDLCyFwKdU3LQjYeBZoptDj7AesXuMTY5aOyJJhi/5PhjBdK4CqRe eKUo49vLEMq7KdA4oQc3XJyot+sQegPgyrBP8XGIkH6mUkceehlDfieXeBwBXP9P 3TEPVNanoWPGj6mpwBHONwrGS69y6VLSVCbW8BeuNd1kpyf960OMa+HnaDO3wMP1 M5UkqYqqePqb4hnKkQ6gvROcM2TK1yRojKFETbtDe3LkpJU1cU02YD8L5pXRzYbM RVxmQOQKuf9GEJLlNd1E6cvarxQ6qzHQfzU1KcUea/YDVOPbVnmbxHYl3wHjz/TU RN6qXa495mCEc4rd9gzFcfqQKaYBz+9qgpotD9EZ/5amflvn4GOCpcvm7DHf54N2 Puy5M4GwIfOZK/EfnJehegp4xh4pz6SLY0W7FgJfwNFr8p2d2/pyRDzVPmCynmrd vsYCyvzJeZiuUJX7J4jGXx/OjpzObu8raySiv+Q00CfwB49uhhbbYHAE= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AdfDJeDEk9-6; Mon, 22 Feb 2021 13:13:35 +0100 (CET) Received: from int-mx003.mykolab.com (unknown [10.9.13.3]) by ext-mx-out001.mykolab.com (Postfix) with ESMTPS id 0D0F35ED; Mon, 22 Feb 2021 13:13:34 +0100 (CET) Received: from int-subm002.mykolab.com (unknown [10.9.37.2]) by int-mx003.mykolab.com (Postfix) with ESMTPS id 81279A4C; Mon, 22 Feb 2021 13:13:32 +0100 (CET) MIME-Version: 1.0 Date: Mon, 22 Feb 2021 13:13:30 +0100 From: Federico Vaga To: Masahiro Yamada Subject: Re: [PATCH] doc: use KCFLAGS instead of EXTRA_CFLAGS to pass flags from command line In-Reply-To: <20210221152524.197693-1-masahiroy@kernel.org> References: <20210221152524.197693-1-masahiroy@kernel.org> Message-ID: X-Sender: federico.vaga@vaga.pv.it X-Mailman-Approved-At: Mon, 22 Feb 2021 12:28:50 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, David Airlie , Tomi Valkeinen , Jonathan Corbet , linux-kernel@vger.kernel.org, Jyri Sarha , Harry Wei , dri-devel@lists.freedesktop.org, Alex Shi Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-02-21 16:25, Masahiro Yamada wrote: > You should use KCFLAGS to pass additional compiler flags from the > command line. Using EXTRA_CFLAGS is wrong. > > EXTRA_CFLAGS is supposed to specify flags applied only to the current > Makefile (and now deprecated in favor of ccflags-y). > > It is still used in arch/mips/kvm/Makefile (and possibly in external > modules too). Passing EXTRA_CFLAGS from the command line overwrites > it and breaks the build. > > I also fixed drivers/gpu/drm/tilcdc/Makefile because commit > 816175dd1fd7 > ("drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in > EXTRA_CFLAGS") was based on the same misunderstanding. > > Signed-off-by: Masahiro Yamada > --- > > Documentation/process/4.Coding.rst | 2 +- > Documentation/process/submit-checklist.rst | 2 +- > Documentation/translations/it_IT/process/4.Coding.rst | 2 +- > Documentation/translations/it_IT/process/submit-checklist.rst | 2 +- > Documentation/translations/zh_CN/process/4.Coding.rst | 2 +- > drivers/gpu/drm/tilcdc/Makefile | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) Acked-by: Federico Vaga -- Federico Vaga http://www.federicovaga.it/ _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel