From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B0ABCAC5B8 for ; Mon, 6 Oct 2025 16:43:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BCA2F10E42E; Mon, 6 Oct 2025 16:43:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="p1YtwLrU"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 09FA710E42E for ; Mon, 6 Oct 2025 16:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1759768977; bh=MJpXLH2WyUVVbdTuWfHINRtUwiFCM4iGx0TBERf8ldA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=p1YtwLrUcTQd2vh/f18Hp0b/5gML91x22BaAvA3JhDCTTN6r+8UcPX3jjHgp0cZyz OXYa5bWkAcjehab+PZFYKN065fcf2xEbL8v9/4EzN1PYwfwmzp6iyuhJVNlW34XH37 qG0mKLuW5kZI6dtMxFcQp91koW7cuH0afLLviwqW8Uvtqof26ZUcZIThOMfTrLyszV G4ykG9jZUMaNq25VKnEgSONSmgpco4bKZMPn9bkMwleMd/Qn2gV3KSwg/KpPSNlpXk ahVYebKW6tc9D1rig9xVgrJ0DwiCfLapaLUkWqmi/1idLR9JyD/AlOIyshKSetrVqy VhA7WZ0qxdxUw== Received: from [192.168.1.90] (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id A51F517E02B0; Mon, 6 Oct 2025 18:42:56 +0200 (CEST) Message-ID: Date: Mon, 6 Oct 2025 19:42:56 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] dt-bindings: display: rk3588-dw-hdmi-qp: Add tmds-enable-gpios property To: Laurent Pinchart , Dmitry Baryshkov Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Alexey Charkov , Algea Cao , Andy Yan , Cenk Uluisik , Conor Dooley , Heiko Stuebner , Jimmy Hon , Kever Yang , Krzysztof Kozlowski , Maxime Ripard , Muhammed Efe Cetin , Ondrej Jirman , Rob Herring , Sandy Huang References: <20251005235542.1017-1-laurent.pinchart@ideasonboard.com> <20251005235542.1017-2-laurent.pinchart@ideasonboard.com> <20251006162518.GJ5944@pendragon.ideasonboard.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <20251006162518.GJ5944@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 10/6/25 7:25 PM, Laurent Pinchart wrote: > On Mon, Oct 06, 2025 at 02:19:24PM +0300, Dmitry Baryshkov wrote: >> On Mon, Oct 06, 2025 at 02:55:37AM +0300, Laurent Pinchart wrote: >>> From: Cristian Ciocaltea >>> >>> Add an optional property to RK3588 HDMI TX Controller binding describing >>> a GPIO line to be asserted when operating in HDMI 1.4/2.0 TMDS mode and >>> deasserted for HDMI 2.1 FRL. >>> >>> This is used to control an external level shifter for HDMI data lines. >>> >>> Signed-off-by: Cristian Ciocaltea >>> Signed-off-by: Laurent Pinchart >>> --- >>> .../display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml >>> index 96b4b088eebe..eec0d40c91ea 100644 >>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml >>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml >>> @@ -113,6 +113,13 @@ properties: >>> description: >>> Additional HDMI QP related data is accessed through VO GRF regs. >>> >>> + tmds-enable-gpios: >>> + description: >>> + Optional GPIO line to be asserted when operating in HDMI 1.4/2.0 >>> + TMDS mode and deasserted for HDMI 2.1 FRL. It can be used to control >>> + an external level shifter for HDMI data lines. >>> + maxItems: 1 >> >> Just my 2c: since TMDS is assumed to be a default mode, shouldn't this >> be a frl-enable-gpios instead? > > I don't mind either way. Cristian, any opinion ? No strong opinion either; we could go for Dmitry's suggestion. >>> + >>> required: >>> - compatible >>> - reg >