From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AA16CA0EEB for ; Tue, 19 Aug 2025 13:43:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 88AEF10E1A6; Tue, 19 Aug 2025 13:43:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ih5KrQAg"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC4ED10E1A6 for ; Tue, 19 Aug 2025 13:43:44 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id A609F61428; Tue, 19 Aug 2025 13:43:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9335DC113CF; Tue, 19 Aug 2025 13:43:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755611012; bh=26yGzcpoEMSGrmdlxNcFoAgjBUvz7SP8XHQo/OesNlU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=ih5KrQAghMQipKwCv3CPpu9ILPwXk74370NIfZ4Xw6s2a0G2Ve2ctgh/nohKO5S8P r1p5B1mjnbqsVFjyS8cTMqUhnjHQvjyTcOD9q6woTvJoiBXAjjyvKrLecdB56dApKg 3cACFEapvKWVlL+K8DYJnQ3KCPqb8sDYKjjVjsSR4KDohjL38uAFiRm0REpkwkULXH 5DLb2QD/2c7cC+sCrQHzT1fOrCUkH2glqgsuC43yEhaVWer0v78tQwJ1E43mtFDbB7 H5oFTSuPzpPSwzDlk1ZQRzP6y7JGKpUnkVMeNcIk1BFXc2lS/hBmO44KBdYlYlSrHP Z6794vLZioVfQ== Message-ID: Date: Tue, 19 Aug 2025 13:43:29 +0000 From: "Maxime Ripard" To: "Luca Ceresoli" Subject: Re: [PATCH v2 1/9] drm/display: bridge-connector: use scope-specific variable for the bridge pointer In-Reply-To: <20250808-drm-bridge-alloc-getput-for_each_bridge-v2-1-edb6ee81edf1@bootlin.com> References: <20250808-drm-bridge-alloc-getput-for_each_bridge-v2-1-edb6ee81edf1@bootlin.com> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, "Andrzej Hajda" , "Bill Wendling" , "Chaoyi Chen" , "David Airlie" , "Dmitry Baryshkov" , "Hui Pu" , "Jernej Skrabec" , "Jonas Karlman" , "Justin Stitt" , "Laurent Pinchart" , "Maarten Lankhorst" , "Maxime Ripard" , "Miguel Ojeda" , "Nathan Chancellor" , "Neil Armstrong" , "Nick Desaulniers" , "Robert Foss" , "Simona Vetter" , "Thomas Petazzoni" , "Thomas Zimmermann" , "Tomi Valkeinen" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 8 Aug 2025 16:49:08 +0200, Luca Ceresoli wrote: > Currently drm_bridge_connector_init() reuses the 'bridge' variable, first > as a loop variable in the long drm_for_each_bridge_in_chain() and then in > the HDMI-specific code as a shortcut to bridge_connector->bridge_cec. >=20 > We are about to remove the 'bridge' loop variable for >=20 > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime